From: Simon Horman <horms@kernel.org>
To: Marcin Szycik <marcin.szycik@linux.intel.com>
Cc: Martyna Szapar-Mudlaw <martyna.szapar-mudlaw@linux.intel.com>,
netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
michal.swiatkowski@linux.intel.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-net 1/2] ice: Fix deinitializing VF in error path
Date: Sat, 15 Feb 2025 19:31:02 +0000 [thread overview]
Message-ID: <20250215193102.GV1615191@kernel.org> (raw)
In-Reply-To: <72975a9c-0daf-4100-b31a-cee0f52e2514@linux.intel.com>
On Thu, Feb 13, 2025 at 01:32:38PM +0100, Marcin Szycik wrote:
>
>
> On 13.02.2025 11:55, Simon Horman wrote:
> > On Tue, Feb 11, 2025 at 06:43:21PM +0100, Marcin Szycik wrote:
> >> If ice_ena_vfs() fails after calling ice_create_vf_entries(), it frees
> >> all VFs without removing them from snapshot PF-VF mailbox list, leading
> >> to list corruption.
> >>
> >> Reproducer:
> >> devlink dev eswitch set $PF1_PCI mode switchdev
> >> ip l s $PF1 up
> >> ip l s $PF1 promisc on
> >> sleep 1
> >> echo 1 > /sys/class/net/$PF1/device/sriov_numvfs
> >
> > Should the line above be "echo 0" to remove the VFs before creating VFs
> > below (I'm looking at sriov_numvfs_store())?
>
> Both "echo 1" commands fail (I'm fixing it in patch 2/2), that's why there's
> no "echo 0" in between. Also, in this minimal example I'm assuming no VFs
> were initially present.
>
> Thanks for reviewing!
Likewise, thanks for the clarification.
...
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Marcin Szycik <marcin.szycik@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
michal.swiatkowski@linux.intel.com,
Sujai Buvaneswaran <sujai.buvaneswaran@intel.com>,
Martyna Szapar-Mudlaw <martyna.szapar-mudlaw@linux.intel.com>
Subject: Re: [PATCH iwl-net 1/2] ice: Fix deinitializing VF in error path
Date: Sat, 15 Feb 2025 19:31:02 +0000 [thread overview]
Message-ID: <20250215193102.GV1615191@kernel.org> (raw)
In-Reply-To: <72975a9c-0daf-4100-b31a-cee0f52e2514@linux.intel.com>
On Thu, Feb 13, 2025 at 01:32:38PM +0100, Marcin Szycik wrote:
>
>
> On 13.02.2025 11:55, Simon Horman wrote:
> > On Tue, Feb 11, 2025 at 06:43:21PM +0100, Marcin Szycik wrote:
> >> If ice_ena_vfs() fails after calling ice_create_vf_entries(), it frees
> >> all VFs without removing them from snapshot PF-VF mailbox list, leading
> >> to list corruption.
> >>
> >> Reproducer:
> >> devlink dev eswitch set $PF1_PCI mode switchdev
> >> ip l s $PF1 up
> >> ip l s $PF1 promisc on
> >> sleep 1
> >> echo 1 > /sys/class/net/$PF1/device/sriov_numvfs
> >
> > Should the line above be "echo 0" to remove the VFs before creating VFs
> > below (I'm looking at sriov_numvfs_store())?
>
> Both "echo 1" commands fail (I'm fixing it in patch 2/2), that's why there's
> no "echo 0" in between. Also, in this minimal example I'm assuming no VFs
> were initially present.
>
> Thanks for reviewing!
Likewise, thanks for the clarification.
...
next prev parent reply other threads:[~2025-02-15 19:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 17:43 [Intel-wired-lan] [PATCH iwl-net 1/2] ice: Fix deinitializing VF in error path Marcin Szycik
2025-02-11 17:43 ` Marcin Szycik
2025-02-11 17:43 ` [Intel-wired-lan] [PATCH iwl-net 2/2] ice: Avoid setting default Rx VSI twice in switchdev setup Marcin Szycik
2025-02-11 17:43 ` Marcin Szycik
2025-02-13 11:00 ` [Intel-wired-lan] " Simon Horman
2025-02-13 11:00 ` Simon Horman
2025-02-21 8:16 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2025-02-21 8:16 ` Buvaneswaran, Sujai
2025-02-13 10:55 ` [Intel-wired-lan] [PATCH iwl-net 1/2] ice: Fix deinitializing VF in error path Simon Horman
2025-02-13 10:55 ` Simon Horman
2025-02-13 12:32 ` [Intel-wired-lan] " Marcin Szycik
2025-02-13 12:32 ` Marcin Szycik
2025-02-15 19:31 ` Simon Horman [this message]
2025-02-15 19:31 ` Simon Horman
2025-02-21 8:15 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2025-02-21 8:15 ` Buvaneswaran, Sujai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250215193102.GV1615191@kernel.org \
--to=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=marcin.szycik@linux.intel.com \
--cc=martyna.szapar-mudlaw@linux.intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.