From: Stephen Hemminger <stephen@networkplumber.org>
To: Ariel Otilibili <ariel.otilibili@6wind.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
David Marchand <david.marchand@redhat.com>,
Reshma Pattan <reshma.pattan@intel.com>,
stable@dpdk.org
Subject: Re: [PATCH 1/1] pcapng: fix null dereference in rte_pcapng_close
Date: Sun, 16 Feb 2025 08:51:29 -0800 [thread overview]
Message-ID: <20250216085129.4b2666f3@hermes.local> (raw)
In-Reply-To: <20250216160833.3216001-2-ariel.otilibili@6wind.com>
On Sun, 16 Feb 2025 17:08:33 +0100
Ariel Otilibili <ariel.otilibili@6wind.com> wrote:
> rte_pcapng_close() might dereference a null pointer; as example,
> PVS-Studio gives its usage in test_pcapng.c: indeed, that call to
> rte_pcapng_close() might receive a null pointer.
>
> Link: https://pvs-studio.com/en/docs/warnings/v522/
> Link: https://github.com/DPDK/dpdk/blob/e5176f23ae8b31437c3e5eb875c81f95bf3a9942/app/test/test_pcapng.c#L438
> Fixes: 8d23ce8f5ee9 ("pcapng: add new library for writing pcapng files")
> Signed-off-by: Ariel Otilibili <ariel.otilibili@6wind.com>
Not sure this is necessary.
The analgous function is fclose() and calling fclose() with NULL will crash.
I would rather update the documentation than silently ignore buggy programs.
next prev parent reply other threads:[~2025-02-16 16:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-16 16:08 [PATCH 0/1] pcapng: fix null dereference in rte_pcapng_close Ariel Otilibili
2025-02-16 16:08 ` [PATCH 1/1] " Ariel Otilibili
2025-02-16 16:51 ` Stephen Hemminger [this message]
2025-02-23 21:41 ` [PATCH v2 0/1] warn if NULL is passed to rte_pcapng_close Ariel Otilibili
2025-02-23 21:41 ` [PATCH v2 1/1] pcapng: " Ariel Otilibili
2025-02-23 22:04 ` Dmitry Kozlyuk
2025-02-24 15:42 ` Stephen Hemminger
2025-02-24 16:42 ` Ariel Otilibili
2025-02-25 20:39 ` Patrick Robb
2025-02-26 15:09 ` Ariel Otilibili
2025-03-04 16:56 ` Patrick Robb
2025-02-24 16:40 ` [PATCH v3 0/1] pcapng: fix null dereference in rte_pcapng_close Ariel Otilibili
2025-02-24 16:40 ` [PATCH v3 1/1] " Ariel Otilibili
2025-06-11 11:52 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250216085129.4b2666f3@hermes.local \
--to=stephen@networkplumber.org \
--cc=ariel.otilibili@6wind.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.