From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Ariel Otilibili <ariel.otilibili@6wind.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
David Marchand <david.marchand@redhat.com>,
Reshma Pattan <reshma.pattan@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>,
stable@dpdk.org
Subject: Re: [PATCH v2 1/1] pcapng: warn if NULL is passed to rte_pcapng_close
Date: Mon, 24 Feb 2025 01:04:04 +0300 [thread overview]
Message-ID: <20250224010404.32b9a34a@sovereign> (raw)
In-Reply-To: <20250223214123.447579-2-ariel.otilibili@6wind.com>
2025-02-23 22:41 (UTC+0100), Ariel Otilibili:
> diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng/rte_pcapng.c
> index 16485b27cb46..d2cbcea42885 100644
> --- a/lib/pcapng/rte_pcapng.c
> +++ b/lib/pcapng/rte_pcapng.c
> @@ -716,6 +716,9 @@ rte_pcapng_fdopen(int fd,
> void
> rte_pcapng_close(rte_pcapng_t *self)
> {
> + if (!self)
> + rte_errno = EINVAL;
> +
> close(self->outfd);
> free(self);
> }
Still dereferencing self == NULL.
next prev parent reply other threads:[~2025-02-23 22:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-16 16:08 [PATCH 0/1] pcapng: fix null dereference in rte_pcapng_close Ariel Otilibili
2025-02-16 16:08 ` [PATCH 1/1] " Ariel Otilibili
2025-02-16 16:51 ` Stephen Hemminger
2025-02-23 21:41 ` [PATCH v2 0/1] warn if NULL is passed to rte_pcapng_close Ariel Otilibili
2025-02-23 21:41 ` [PATCH v2 1/1] pcapng: " Ariel Otilibili
2025-02-23 22:04 ` Dmitry Kozlyuk [this message]
2025-02-24 15:42 ` Stephen Hemminger
2025-02-24 16:42 ` Ariel Otilibili
2025-02-25 20:39 ` Patrick Robb
2025-02-26 15:09 ` Ariel Otilibili
2025-03-04 16:56 ` Patrick Robb
2025-02-24 16:40 ` [PATCH v3 0/1] pcapng: fix null dereference in rte_pcapng_close Ariel Otilibili
2025-02-24 16:40 ` [PATCH v3 1/1] " Ariel Otilibili
2025-06-11 11:52 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250224010404.32b9a34a@sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=ariel.otilibili@6wind.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.