From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <kerneljasonxing@gmail.com>
Cc: <andrii@kernel.org>, <ast@kernel.org>, <bpf@vger.kernel.org>,
<daniel@iogearbox.net>, <davem@davemloft.net>,
<dsahern@kernel.org>, <eddyz87@gmail.com>, <edumazet@google.com>,
<haoluo@google.com>, <john.fastabend@gmail.com>,
<jolsa@kernel.org>, <kpsingh@kernel.org>, <kuba@kernel.org>,
<kuniyu@amazon.com>, <martin.lau@linux.dev>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>, <sdf@fomichev.me>,
<shuah@kernel.org>, <song@kernel.org>, <ykolal@fb.com>,
<yonghong.song@linux.dev>
Subject: Re: [PATCH bpf-next v2 2/3] bpf: support TCP_RTO_MAX_MS for bpf_setsockopt
Date: Mon, 17 Feb 2025 13:28:54 -0800 [thread overview]
Message-ID: <20250217212854.62301-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20250217034245.11063-3-kerneljasonxing@gmail.com>
From: Jason Xing <kerneljasonxing@gmail.com>
Date: Mon, 17 Feb 2025 11:42:44 +0800
> Some applications don't want to wait for too long because the
> time of retransmission increases exponentially and can reach more
> than 10 seconds, for example. Eric implements the core logic
> on supporting rto max feature in the stack previously. Based on that,
> we can support it for BPF use.
>
> This patch reuses the same logic of TCP_RTO_MAX_MS in do_tcp_setsockopt()
> and do_tcp_getsockopt(). BPF program can call bpf_{set/get}sockopt()
> to set/get the maximum value of RTO.
>
> It would be good if a BPF program sets max value of RTO before
> transmission as we can see in the later patch (selftests).
>
> Signed-off-by: Jason Xing <kerneljasonxing@gmail.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
next prev parent reply other threads:[~2025-02-17 21:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 3:42 [PATCH bpf-next v2 0/3] bpf: support setting max RTO for bpf_setsockopt Jason Xing
2025-02-17 3:42 ` [PATCH bpf-next v2 1/3] tcp: add TCP_RTO_MAX_MIN_SEC definition Jason Xing
2025-02-18 23:38 ` Martin KaFai Lau
2025-02-18 23:45 ` Jason Xing
2025-02-19 1:47 ` Jakub Kicinski
2025-02-19 2:12 ` Jason Xing
2025-02-17 3:42 ` [PATCH bpf-next v2 2/3] bpf: support TCP_RTO_MAX_MS for bpf_setsockopt Jason Xing
2025-02-17 21:28 ` Kuniyuki Iwashima [this message]
2025-02-17 3:42 ` [PATCH bpf-next v2 3/3] selftests/bpf: add rto max for bpf_setsockopt test Jason Xing
2025-02-19 2:01 ` Martin KaFai Lau
2025-02-19 2:17 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250217212854.62301-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=ykolal@fb.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.