From: Jakub Kicinski <kuba@kernel.org>
To: Jason Xing <kerneljasonxing@gmail.com>
Cc: Martin KaFai Lau <martin.lau@linux.dev>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
dsahern@kernel.org, kuniyu@amazon.com, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com,
song@kernel.org, yonghong.song@linux.dev,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me,
haoluo@google.com, jolsa@kernel.org, shuah@kernel.org,
ykolal@fb.com, bpf@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 1/3] tcp: add TCP_RTO_MAX_MIN_SEC definition
Date: Tue, 18 Feb 2025 17:47:54 -0800 [thread overview]
Message-ID: <20250218174754.150c82c3@kernel.org> (raw)
In-Reply-To: <4dc10429-29dd-47bb-bd5f-6a8654ed2fec@linux.dev>
On Tue, 18 Feb 2025 15:38:17 -0800 Martin KaFai Lau wrote:
> On 2/16/25 7:42 PM, Jason Xing wrote:
> > Add minimum value definition as the lower bound of RTO MAX
> > set by users. No functional changes here.
>
> If it is no-op, why it is needed? The commit message didn't explain it either.
> I also cannot guess how patch 2 depends on patch 1.
FWIW this patch also gave me pause when looking at v1.
I don't think this define makes the code any easier to follow.
next prev parent reply other threads:[~2025-02-19 1:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 3:42 [PATCH bpf-next v2 0/3] bpf: support setting max RTO for bpf_setsockopt Jason Xing
2025-02-17 3:42 ` [PATCH bpf-next v2 1/3] tcp: add TCP_RTO_MAX_MIN_SEC definition Jason Xing
2025-02-18 23:38 ` Martin KaFai Lau
2025-02-18 23:45 ` Jason Xing
2025-02-19 1:47 ` Jakub Kicinski [this message]
2025-02-19 2:12 ` Jason Xing
2025-02-17 3:42 ` [PATCH bpf-next v2 2/3] bpf: support TCP_RTO_MAX_MS for bpf_setsockopt Jason Xing
2025-02-17 21:28 ` Kuniyuki Iwashima
2025-02-17 3:42 ` [PATCH bpf-next v2 3/3] selftests/bpf: add rto max for bpf_setsockopt test Jason Xing
2025-02-19 2:01 ` Martin KaFai Lau
2025-02-19 2:17 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250218174754.150c82c3@kernel.org \
--to=kuba@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=kpsingh@kernel.org \
--cc=kuniyu@amazon.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=ykolal@fb.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.