From: kernel test robot <lkp@intel.com>
To: Alexander Wetzel <Alexander@wetzel-home.de>,
linux-wireless@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev,
Johannes Berg <johannes@sipsolutions.net>,
Alexander Wetzel <alexander@wetzel-home.de>
Subject: Re: [PATCH v2 08/10] wifi: mac80211: Simplify AMPDU handling
Date: Tue, 18 Feb 2025 00:30:00 +0800 [thread overview]
Message-ID: <202502180007.MFwMk2L7-lkp@intel.com> (raw)
In-Reply-To: <20250217081721.45110-9-Alexander@wetzel-home.de>
Hi Alexander,
kernel test robot noticed the following build warnings:
[auto build test WARNING on wireless-next/main]
[also build test WARNING on wireless/main ath/ath-next linus/master v6.14-rc3 next-20250217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Alexander-Wetzel/wifi-mac80211-move-rate-control-setup/20250217-162046
base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link: https://lore.kernel.org/r/20250217081721.45110-9-Alexander%40wetzel-home.de
patch subject: [PATCH v2 08/10] wifi: mac80211: Simplify AMPDU handling
config: i386-buildonly-randconfig-004-20250217 (https://download.01.org/0day-ci/archive/20250218/202502180007.MFwMk2L7-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250218/202502180007.MFwMk2L7-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502180007.MFwMk2L7-lkp@intel.com/
All warnings (new ones prefixed by >>):
net/mac80211/tx.c: In function 'ieee80211_tx_prepare':
>> net/mac80211/tx.c:1140:14: warning: variable 'aggr_check' set but not used [-Wunused-but-set-variable]
1140 | bool aggr_check = false;
| ^~~~~~~~~~
--
net/mac80211/rx.c: In function 'ieee80211_rx_mesh_fast_forward':
>> net/mac80211/rx.c:2778:30: warning: variable 'tid_tx' set but not used [-Wunused-but-set-variable]
2778 | struct tid_ampdu_tx *tid_tx;
| ^~~~~~
vim +/aggr_check +1140 net/mac80211/tx.c
1a7915501ca94a Felix Fietkau 2021-06-29 1126
58d4185e36913d Johannes Berg 2007-09-26 1127 /*
58d4185e36913d Johannes Berg 2007-09-26 1128 * initialises @tx
7c10770f995820 Johannes Berg 2015-03-20 1129 * pass %NULL for the station if unknown, a valid pointer if known
7c10770f995820 Johannes Berg 2015-03-20 1130 * or an ERR_PTR() if the station is known not to exist
58d4185e36913d Johannes Berg 2007-09-26 1131 */
9ae54c8463691b Johannes Berg 2008-01-31 1132 static ieee80211_tx_result
3b8d81e020f77c Johannes Berg 2009-06-17 1133 ieee80211_tx_prepare(struct ieee80211_sub_if_data *sdata,
3b8d81e020f77c Johannes Berg 2009-06-17 1134 struct ieee80211_tx_data *tx,
7c10770f995820 Johannes Berg 2015-03-20 1135 struct sta_info *sta, struct sk_buff *skb)
e2ebc74d7e3d71 Johannes Berg 2007-07-27 1136 {
3b8d81e020f77c Johannes Berg 2009-06-17 1137 struct ieee80211_local *local = sdata->local;
58d4185e36913d Johannes Berg 2007-09-26 1138 struct ieee80211_hdr *hdr;
e039fa4a4195ac Johannes Berg 2008-05-15 1139 struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
1a7915501ca94a Felix Fietkau 2021-06-29 @1140 bool aggr_check = false;
e2ebc74d7e3d71 Johannes Berg 2007-07-27 1141
e2ebc74d7e3d71 Johannes Berg 2007-07-27 1142 memset(tx, 0, sizeof(*tx));
e2ebc74d7e3d71 Johannes Berg 2007-07-27 1143 tx->skb = skb;
e2ebc74d7e3d71 Johannes Berg 2007-07-27 1144 tx->local = local;
3b8d81e020f77c Johannes Berg 2009-06-17 1145 tx->sdata = sdata;
252b86c43225d0 Johannes Berg 2011-11-16 1146 __skb_queue_head_init(&tx->skbs);
e2ebc74d7e3d71 Johannes Berg 2007-07-27 1147
cd8ffc800ce18e Johannes Berg 2009-03-23 1148 /*
cd8ffc800ce18e Johannes Berg 2009-03-23 1149 * If this flag is set to true anywhere, and we get here,
cd8ffc800ce18e Johannes Berg 2009-03-23 1150 * we are doing the needed processing, so remove the flag
cd8ffc800ce18e Johannes Berg 2009-03-23 1151 * now.
cd8ffc800ce18e Johannes Berg 2009-03-23 1152 */
cc20ff2c6b5d3e Felix Fietkau 2020-09-08 1153 info->control.flags &= ~IEEE80211_TX_INTCFL_NEED_TXPROCESSING;
cd8ffc800ce18e Johannes Berg 2009-03-23 1154
58d4185e36913d Johannes Berg 2007-09-26 1155 hdr = (struct ieee80211_hdr *) skb->data;
58d4185e36913d Johannes Berg 2007-09-26 1156
7c10770f995820 Johannes Berg 2015-03-20 1157 if (likely(sta)) {
7c10770f995820 Johannes Berg 2015-03-20 1158 if (!IS_ERR(sta))
7c10770f995820 Johannes Berg 2015-03-20 1159 tx->sta = sta;
7c10770f995820 Johannes Berg 2015-03-20 1160 } else {
3f0e0b220f8007 Felix Fietkau 2010-01-08 1161 if (sdata->vif.type == NL80211_IFTYPE_AP_VLAN) {
f14543ee4d0681 Felix Fietkau 2009-11-10 1162 tx->sta = rcu_dereference(sdata->u.vlan.sta);
7c10770f995820 Johannes Berg 2015-03-20 1163 if (!tx->sta && sdata->wdev.use_4addr)
3f0e0b220f8007 Felix Fietkau 2010-01-08 1164 return TX_DROP;
10cb8e617560fc Markus Theil 2021-02-06 1165 } else if (tx->sdata->control_port_protocol == tx->skb->protocol) {
b4d57adb727ec7 Felix Fietkau 2010-01-31 1166 tx->sta = sta_info_get_bss(sdata, hdr->addr1);
3f0e0b220f8007 Felix Fietkau 2010-01-08 1167 }
1a7915501ca94a Felix Fietkau 2021-06-29 1168 if (!tx->sta && !is_multicast_ether_addr(hdr->addr1)) {
abe60632f311d5 Johannes Berg 2009-11-25 1169 tx->sta = sta_info_get(sdata, hdr->addr1);
1a7915501ca94a Felix Fietkau 2021-06-29 1170 aggr_check = true;
1a7915501ca94a Felix Fietkau 2021-06-29 1171 }
7c10770f995820 Johannes Berg 2015-03-20 1172 }
58d4185e36913d Johannes Berg 2007-09-26 1173
badffb725c86cc Jiri Slaby 2007-08-28 1174 if (is_multicast_ether_addr(hdr->addr1)) {
5cf121c3cdb955 Johannes Berg 2008-02-25 1175 tx->flags &= ~IEEE80211_TX_UNICAST;
e039fa4a4195ac Johannes Berg 2008-05-15 1176 info->flags |= IEEE80211_TX_CTL_NO_ACK;
6fd67e937ece53 Simon Wunderlich 2011-11-18 1177 } else
5cf121c3cdb955 Johannes Berg 2008-02-25 1178 tx->flags |= IEEE80211_TX_UNICAST;
58d4185e36913d Johannes Berg 2007-09-26 1179
a26eb27ab43014 Johannes Berg 2011-10-07 1180 if (!(info->flags & IEEE80211_TX_CTL_DONTFRAG)) {
a26eb27ab43014 Johannes Berg 2011-10-07 1181 if (!(tx->flags & IEEE80211_TX_UNICAST) ||
a26eb27ab43014 Johannes Berg 2011-10-07 1182 skb->len + FCS_LEN <= local->hw.wiphy->frag_threshold ||
a26eb27ab43014 Johannes Berg 2011-10-07 1183 info->flags & IEEE80211_TX_CTL_AMPDU)
a26eb27ab43014 Johannes Berg 2011-10-07 1184 info->flags |= IEEE80211_TX_CTL_DONTFRAG;
58d4185e36913d Johannes Berg 2007-09-26 1185 }
58d4185e36913d Johannes Berg 2007-09-26 1186
e2ebc74d7e3d71 Johannes Berg 2007-07-27 1187 if (!tx->sta)
e039fa4a4195ac Johannes Berg 2008-05-15 1188 info->flags |= IEEE80211_TX_CTL_CLEAR_PS_FILT;
f7418bc10d8402 Felix Fietkau 2015-09-24 1189 else if (test_and_clear_sta_flag(tx->sta, WLAN_STA_CLEAR_PS_FILT)) {
e039fa4a4195ac Johannes Berg 2008-05-15 1190 info->flags |= IEEE80211_TX_CTL_CLEAR_PS_FILT;
f7418bc10d8402 Felix Fietkau 2015-09-24 1191 ieee80211_check_fast_xmit(tx->sta);
f7418bc10d8402 Felix Fietkau 2015-09-24 1192 }
58d4185e36913d Johannes Berg 2007-09-26 1193
e039fa4a4195ac Johannes Berg 2008-05-15 1194 info->flags |= IEEE80211_TX_CTL_FIRST_FRAGMENT;
e2ebc74d7e3d71 Johannes Berg 2007-07-27 1195
9ae54c8463691b Johannes Berg 2008-01-31 1196 return TX_CONTINUE;
e2ebc74d7e3d71 Johannes Berg 2007-07-27 1197 }
e2ebc74d7e3d71 Johannes Berg 2007-07-27 1198
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-02-17 16:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 8:17 [PATCH v2 00/10] Convert mac80211 to TXQs only Alexander Wetzel
2025-02-17 8:17 ` [PATCH v2 01/10] wifi: mac80211: move rate control setup Alexander Wetzel
2025-02-17 8:17 ` [PATCH v2 02/10] wifi: mac80211: Always provide the MMPDU TXQ Alexander Wetzel
2025-02-17 8:17 ` [PATCH v2 03/10] wifi: mac80211: Convert vif->txq to an array Alexander Wetzel
2025-02-17 8:17 ` [PATCH v2 04/10] wifi: mac80211: Add new TX queues to replace legacy TX Alexander Wetzel
2025-02-17 8:17 ` [PATCH v2 05/10] wifi: mac80211: Stop using legacy TX path Alexander Wetzel
2025-02-17 22:33 ` kernel test robot
2025-02-17 8:17 ` [PATCH v2 06/10] wifi: mac80211: Call ieee80211_tx_h_select_key only once Alexander Wetzel
2025-02-17 8:17 ` [PATCH v2 07/10] wifi: mac80211: Rename IEEE80211_TX_INTFL_OFFCHAN_TX_OK Alexander Wetzel
2025-02-17 8:17 ` [PATCH v2 08/10] wifi: mac80211: Simplify AMPDU handling Alexander Wetzel
2025-02-17 16:30 ` kernel test robot [this message]
2025-02-17 8:17 ` [PATCH v2 09/10] wifi: mac80211: Migrate TX to kthread Alexander Wetzel
2025-02-17 8:17 ` [PATCH v2 10/10] wifi: mac80211: Cleanup *ieee80211_wake_txq* naming Alexander Wetzel
2025-02-19 19:19 ` [PATCH v2 00/10] Convert mac80211 to TXQs only James Prestwood
2025-02-19 21:27 ` Alexander Wetzel
2025-02-20 13:56 ` James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202502180007.MFwMk2L7-lkp@intel.com \
--to=lkp@intel.com \
--cc=Alexander@wetzel-home.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.