From: kernel test robot <lkp@intel.com>
To: Alexander Wetzel <Alexander@wetzel-home.de>,
linux-wireless@vger.kernel.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Johannes Berg <johannes@sipsolutions.net>,
Alexander Wetzel <alexander@wetzel-home.de>
Subject: Re: [PATCH v2 05/10] wifi: mac80211: Stop using legacy TX path
Date: Tue, 18 Feb 2025 06:33:59 +0800 [thread overview]
Message-ID: <202502180650.CWCCOFGJ-lkp@intel.com> (raw)
In-Reply-To: <20250217081721.45110-6-Alexander@wetzel-home.de>
Hi Alexander,
kernel test robot noticed the following build warnings:
[auto build test WARNING on wireless-next/main]
[also build test WARNING on wireless/main ath/ath-next linus/master v6.14-rc3 next-20250217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Alexander-Wetzel/wifi-mac80211-move-rate-control-setup/20250217-162046
base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link: https://lore.kernel.org/r/20250217081721.45110-6-Alexander%40wetzel-home.de
patch subject: [PATCH v2 05/10] wifi: mac80211: Stop using legacy TX path
config: x86_64-buildonly-randconfig-003-20250218 (https://download.01.org/0day-ci/archive/20250218/202502180650.CWCCOFGJ-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250218/202502180650.CWCCOFGJ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502180650.CWCCOFGJ-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from net/mac80211/tx.c:15:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:8:
In file included from include/linux/cacheflush.h:5:
In file included from arch/x86/include/asm/cacheflush.h:5:
In file included from include/linux/mm.h:2224:
include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
505 | item];
| ~~~~
include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
512 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
525 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
>> net/mac80211/tx.c:4607:29: warning: variable 'hdr' is uninitialized when used here [-Wuninitialized]
4607 | sta = sta_info_get(sdata, hdr->addr1);
| ^~~
net/mac80211/tx.c:4579:27: note: initialize the variable 'hdr' to silence this warning
4579 | struct ieee80211_hdr *hdr;
| ^
| = NULL
4 warnings generated.
vim +/hdr +4607 net/mac80211/tx.c
e2ebc74d7e3d716 Johannes Berg 2007-07-27 4572
e8f495b5a04f5a6 Alexander Wetzel 2025-02-17 4573 static void ieee80211_tx_pending_skb(struct ieee80211_local *local,
cd8ffc800ce18e5 Johannes Berg 2009-03-23 4574 struct sk_buff *skb)
cd8ffc800ce18e5 Johannes Berg 2009-03-23 4575 {
cd8ffc800ce18e5 Johannes Berg 2009-03-23 4576 struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
cd8ffc800ce18e5 Johannes Berg 2009-03-23 4577 struct ieee80211_sub_if_data *sdata;
cd8ffc800ce18e5 Johannes Berg 2009-03-23 4578 struct sta_info *sta;
cd8ffc800ce18e5 Johannes Berg 2009-03-23 4579 struct ieee80211_hdr *hdr;
55de908ab292c03 Johannes Berg 2012-07-26 4580 struct ieee80211_chanctx_conf *chanctx_conf;
cd8ffc800ce18e5 Johannes Berg 2009-03-23 4581
5061b0c2b9066de Johannes Berg 2009-07-14 4582 sdata = vif_to_sdata(info->control.vif);
cd8ffc800ce18e5 Johannes Berg 2009-03-23 4583
cc20ff2c6b5d3e2 Felix Fietkau 2020-09-08 4584 if (info->control.flags & IEEE80211_TX_INTCFL_NEED_TXPROCESSING) {
eef25a6679adb3c Johannes Berg 2022-06-01 4585 /* update band only for non-MLD */
f1871abd27641c0 Ilan Peer 2023-06-08 4586 if (!ieee80211_vif_is_mld(&sdata->vif)) {
eef25a6679adb3c Johannes Berg 2022-06-01 4587 chanctx_conf =
eef25a6679adb3c Johannes Berg 2022-06-01 4588 rcu_dereference(sdata->vif.bss_conf.chanctx_conf);
55de908ab292c03 Johannes Berg 2012-07-26 4589 if (unlikely(!chanctx_conf)) {
55de908ab292c03 Johannes Berg 2012-07-26 4590 dev_kfree_skb(skb);
e8f495b5a04f5a6 Alexander Wetzel 2025-02-17 4591 return;
55de908ab292c03 Johannes Berg 2012-07-26 4592 }
73c4e195e6396ee Johannes Berg 2014-11-09 4593 info->band = chanctx_conf->def.chan->band;
eef25a6679adb3c Johannes Berg 2022-06-01 4594 }
e8f495b5a04f5a6 Alexander Wetzel 2025-02-17 4595 ieee80211_tx(sdata, NULL, skb);
cc20ff2c6b5d3e2 Felix Fietkau 2020-09-08 4596 } else if (info->flags & IEEE80211_TX_CTL_HW_80211_ENCAP) {
50ff477a8639fa1 John Crispin 2019-11-25 4597 if (ieee80211_lookup_ra_sta(sdata, skb, &sta)) {
50ff477a8639fa1 John Crispin 2019-11-25 4598 dev_kfree_skb(skb);
e8f495b5a04f5a6 Alexander Wetzel 2025-02-17 4599 return;
50ff477a8639fa1 John Crispin 2019-11-25 4600 }
50ff477a8639fa1 John Crispin 2019-11-25 4601
50ff477a8639fa1 John Crispin 2019-11-25 4602 if (IS_ERR(sta) || (sta && !sta->uploaded))
50ff477a8639fa1 John Crispin 2019-11-25 4603 sta = NULL;
50ff477a8639fa1 John Crispin 2019-11-25 4604
e8f495b5a04f5a6 Alexander Wetzel 2025-02-17 4605 ieee80211_queue_skb(local, sdata, sta, skb);
cd8ffc800ce18e5 Johannes Berg 2009-03-23 4606 } else {
abe60632f311d51 Johannes Berg 2009-11-25 @4607 sta = sta_info_get(sdata, hdr->addr1);
e8f495b5a04f5a6 Alexander Wetzel 2025-02-17 4608 ieee80211_tx(sdata, sta, skb);
cd8ffc800ce18e5 Johannes Berg 2009-03-23 4609 }
cd8ffc800ce18e5 Johannes Berg 2009-03-23 4610 }
cd8ffc800ce18e5 Johannes Berg 2009-03-23 4611
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-02-17 22:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 8:17 [PATCH v2 00/10] Convert mac80211 to TXQs only Alexander Wetzel
2025-02-17 8:17 ` [PATCH v2 01/10] wifi: mac80211: move rate control setup Alexander Wetzel
2025-02-17 8:17 ` [PATCH v2 02/10] wifi: mac80211: Always provide the MMPDU TXQ Alexander Wetzel
2025-02-17 8:17 ` [PATCH v2 03/10] wifi: mac80211: Convert vif->txq to an array Alexander Wetzel
2025-02-17 8:17 ` [PATCH v2 04/10] wifi: mac80211: Add new TX queues to replace legacy TX Alexander Wetzel
2025-02-17 8:17 ` [PATCH v2 05/10] wifi: mac80211: Stop using legacy TX path Alexander Wetzel
2025-02-17 22:33 ` kernel test robot [this message]
2025-02-17 8:17 ` [PATCH v2 06/10] wifi: mac80211: Call ieee80211_tx_h_select_key only once Alexander Wetzel
2025-02-17 8:17 ` [PATCH v2 07/10] wifi: mac80211: Rename IEEE80211_TX_INTFL_OFFCHAN_TX_OK Alexander Wetzel
2025-02-17 8:17 ` [PATCH v2 08/10] wifi: mac80211: Simplify AMPDU handling Alexander Wetzel
2025-02-17 16:30 ` kernel test robot
2025-02-17 8:17 ` [PATCH v2 09/10] wifi: mac80211: Migrate TX to kthread Alexander Wetzel
2025-02-17 8:17 ` [PATCH v2 10/10] wifi: mac80211: Cleanup *ieee80211_wake_txq* naming Alexander Wetzel
2025-02-19 19:19 ` [PATCH v2 00/10] Convert mac80211 to TXQs only James Prestwood
2025-02-19 21:27 ` Alexander Wetzel
2025-02-20 13:56 ` James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202502180650.CWCCOFGJ-lkp@intel.com \
--to=lkp@intel.com \
--cc=Alexander@wetzel-home.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.