Re: [RFC][PATCH 03/10] pstore/zone: introduce directly mapped zones

[kernel test robot <lkp@intel.com>]

Hi Eugen,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on kees/for-next/pstore]
[also build test WARNING on kees/for-next/kspp driver-core/driver-core-testing driver-core/driver-core-next driver-core/driver-core-linus herbert-cryptodev-2.6/master herbert-crypto-2.6/master linus/master v6.14-rc3 next-20250217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Eugen-Hristev/pstore-zone-move-pstore_device_info-into-zone-header/20250217-182615
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/pstore
patch link:    https://lore.kernel.org/r/20250217101706.2104498-4-eugen.hristev%40linaro.org
patch subject: [RFC][PATCH 03/10] pstore/zone: introduce directly mapped zones
config: i386-buildonly-randconfig-001-20250218 (https://download.01.org/0day-ci/archive/20250218/202502180829.397JnTMl-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250218/202502180829.397JnTMl-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502180829.397JnTMl-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/pstore/zone.c:141: warning: Function parameter or struct member 'dmszs' not described in 'psz_context'
>> fs/pstore/zone.c:141: warning: Function parameter or struct member 'dmapped_max_cnt' not described in 'psz_context'


vim +141 fs/pstore/zone.c

d26c3321fe18dc7 WeiXiong Liao 2020-03-25   88  
d26c3321fe18dc7 WeiXiong Liao 2020-03-25   89  /**
d26c3321fe18dc7 WeiXiong Liao 2020-03-25   90   * struct psz_context - all about running state of pstore/zone
d26c3321fe18dc7 WeiXiong Liao 2020-03-25   91   *
d26c3321fe18dc7 WeiXiong Liao 2020-03-25   92   * @kpszs: kmsg dump storage zones
0dc068265a1c592 WeiXiong Liao 2020-03-25   93   * @ppsz: pmsg storage zone
cc9c4d1b5597167 WeiXiong Liao 2020-03-25   94   * @cpsz: console storage zone
34327e9fd213414 WeiXiong Liao 2020-03-25   95   * @fpszs: ftrace storage zones
d26c3321fe18dc7 WeiXiong Liao 2020-03-25   96   * @kmsg_max_cnt: max count of @kpszs
d26c3321fe18dc7 WeiXiong Liao 2020-03-25   97   * @kmsg_read_cnt: counter of total read kmsg dumps
d26c3321fe18dc7 WeiXiong Liao 2020-03-25   98   * @kmsg_write_cnt: counter of total kmsg dump writes
0dc068265a1c592 WeiXiong Liao 2020-03-25   99   * @pmsg_read_cnt: counter of total read pmsg zone
cc9c4d1b5597167 WeiXiong Liao 2020-03-25  100   * @console_read_cnt: counter of total read console zone
34327e9fd213414 WeiXiong Liao 2020-03-25  101   * @ftrace_max_cnt: max count of @fpszs
34327e9fd213414 WeiXiong Liao 2020-03-25  102   * @ftrace_read_cnt: counter of max read ftrace zone
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  103   * @oops_counter: counter of oops dumps
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  104   * @panic_counter: counter of panic dumps
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  105   * @recovered: whether finished recovering data from storage
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  106   * @on_panic: whether panic is happening
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  107   * @pstore_zone_info_lock: lock to @pstore_zone_info
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  108   * @pstore_zone_info: information from backend
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  109   * @pstore: structure for pstore
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  110   */
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  111  struct psz_context {
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  112  	struct pstore_zone **kpszs;
0dc068265a1c592 WeiXiong Liao 2020-03-25  113  	struct pstore_zone *ppsz;
cc9c4d1b5597167 WeiXiong Liao 2020-03-25  114  	struct pstore_zone *cpsz;
34327e9fd213414 WeiXiong Liao 2020-03-25  115  	struct pstore_zone **fpszs;
da841d31ac7ea7b Eugen Hristev 2025-02-17  116  	struct pstore_zone **dmszs;
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  117  	unsigned int kmsg_max_cnt;
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  118  	unsigned int kmsg_read_cnt;
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  119  	unsigned int kmsg_write_cnt;
0dc068265a1c592 WeiXiong Liao 2020-03-25  120  	unsigned int pmsg_read_cnt;
cc9c4d1b5597167 WeiXiong Liao 2020-03-25  121  	unsigned int console_read_cnt;
34327e9fd213414 WeiXiong Liao 2020-03-25  122  	unsigned int ftrace_max_cnt;
34327e9fd213414 WeiXiong Liao 2020-03-25  123  	unsigned int ftrace_read_cnt;
da841d31ac7ea7b Eugen Hristev 2025-02-17  124  	unsigned int dmapped_max_cnt;
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  125  	/*
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  126  	 * These counters should be calculated during recovery.
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  127  	 * It records the oops/panic times after crashes rather than boots.
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  128  	 */
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  129  	unsigned int oops_counter;
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  130  	unsigned int panic_counter;
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  131  	atomic_t recovered;
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  132  	atomic_t on_panic;
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  133  
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  134  	/*
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  135  	 * pstore_zone_info_lock protects this entire structure during calls
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  136  	 * to register_pstore_zone()/unregister_pstore_zone().
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  137  	 */
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  138  	struct mutex pstore_zone_info_lock;
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  139  	struct pstore_zone_info *pstore_zone_info;
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  140  	struct pstore_info pstore;
d26c3321fe18dc7 WeiXiong Liao 2020-03-25 @141  };
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  142  static struct psz_context pstore_zone_cxt;
d26c3321fe18dc7 WeiXiong Liao 2020-03-25  143  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki