Re: [RFC][PATCH 05/10] pstore: implement core area registration

[kernel test robot <lkp@intel.com>]

Hi Eugen,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on kees/for-next/pstore]
[also build test WARNING on kees/for-next/kspp driver-core/driver-core-testing driver-core/driver-core-next driver-core/driver-core-linus herbert-cryptodev-2.6/master herbert-crypto-2.6/master linus/master v6.14-rc3 next-20250217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Eugen-Hristev/pstore-zone-move-pstore_device_info-into-zone-header/20250217-182615
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/pstore
patch link:    https://lore.kernel.org/r/20250217101706.2104498-6-eugen.hristev%40linaro.org
patch subject: [RFC][PATCH 05/10] pstore: implement core area registration
config: i386-buildonly-randconfig-001-20250218 (https://download.01.org/0day-ci/archive/20250218/202502181022.PsKoqf9f-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250218/202502181022.PsKoqf9f-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502181022.PsKoqf9f-lkp@intel.com/

All warnings (new ones prefixed by >>):

   fs/pstore/platform.c: In function 'pstore_unregister_core_area':
>> fs/pstore/platform.c:316:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     316 |         int ret;
         |             ^~~
--
>> fs/pstore/zone.c:40: warning: Function parameter or struct member 'data_ptr' not described in 'psz_buffer'
   fs/pstore/zone.c:142: warning: Function parameter or struct member 'dmszs' not described in 'psz_context'
   fs/pstore/zone.c:142: warning: Function parameter or struct member 'dmapped_max_cnt' not described in 'psz_context'


vim +/ret +316 fs/pstore/platform.c

   312	
   313	int pstore_unregister_core_area(const char *handle, void *area, size_t size)
   314	{
   315		struct rec_list_t *rec_element, *tmp;
 > 316		int ret;
   317	
   318		if (!psinfo || !psinfo->unregister_dmr)
   319			return -EAGAIN;
   320	
   321		mutex_lock(&ps_dmr_lock);
   322		list_for_each_entry_safe(rec_element, tmp, &rec_list, list) {
   323			struct pstore_record *record;
   324	
   325			record = &rec_element->rec;
   326	
   327			if (record->buf == area) {
   328				ret = psinfo->unregister_dmr(record);
   329				list_del(&rec_element->list);
   330				mutex_unlock(&ps_dmr_lock);
   331				return 0;
   332			}
   333		}
   334	
   335		mutex_unlock(&ps_dmr_lock);
   336		return 0;
   337	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki