* [PATCH] PCI: endpoint: Improve reference in pci_epc_bar_size_to_rebar_cap() comment
@ 2025-02-19 17:14 Niklas Cassel
2025-02-19 17:25 ` Manivannan Sadhasivam
0 siblings, 1 reply; 2+ messages in thread
From: Niklas Cassel @ 2025-02-19 17:14 UTC (permalink / raw)
To: Manivannan Sadhasivam, Krzysztof Wilczyński,
Kishon Vijay Abraham I, Bjorn Helgaas
Cc: Niklas Cassel, Bjorn Helgaas, linux-pci
Improve the reference pci_epc_bar_size_to_rebar_cap() comment to include
a specific PCIe spec version, and a specific section in that PCIe spec.
Suggested-by: Bjorn Helgaas <helgaas@kernel.org>
Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
Feel free to squash with original commit.
drivers/pci/endpoint/pci-epc-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/endpoint/pci-epc-core.c b/drivers/pci/endpoint/pci-epc-core.c
index 5d6aef956b13..88cb426d3aec 100644
--- a/drivers/pci/endpoint/pci-epc-core.c
+++ b/drivers/pci/endpoint/pci-epc-core.c
@@ -649,7 +649,7 @@ EXPORT_SYMBOL_GPL(pci_epc_set_bar);
int pci_epc_bar_size_to_rebar_cap(size_t size, u32 *cap)
{
/*
- * According to PCIe base spec, min size for a resizable BAR is 1 MB,
+ * As per PCIe r6.0, sec 7.8.6.2, min size for a resizable BAR is 1 MB,
* thus disallow a requested BAR size smaller than 1 MB.
* Disallow a requested BAR size larger than 128 TB.
*/
--
2.48.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] PCI: endpoint: Improve reference in pci_epc_bar_size_to_rebar_cap() comment
2025-02-19 17:14 [PATCH] PCI: endpoint: Improve reference in pci_epc_bar_size_to_rebar_cap() comment Niklas Cassel
@ 2025-02-19 17:25 ` Manivannan Sadhasivam
0 siblings, 0 replies; 2+ messages in thread
From: Manivannan Sadhasivam @ 2025-02-19 17:25 UTC (permalink / raw)
To: Niklas Cassel
Cc: Krzysztof Wilczyński, Kishon Vijay Abraham I, Bjorn Helgaas,
Bjorn Helgaas, linux-pci
On Wed, Feb 19, 2025 at 06:14:55PM +0100, Niklas Cassel wrote:
> Improve the reference pci_epc_bar_size_to_rebar_cap() comment to include
> a specific PCIe spec version, and a specific section in that PCIe spec.
>
> Suggested-by: Bjorn Helgaas <helgaas@kernel.org>
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
> ---
> Feel free to squash with original commit.
Done, thanks!
- Mani
>
> drivers/pci/endpoint/pci-epc-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/endpoint/pci-epc-core.c b/drivers/pci/endpoint/pci-epc-core.c
> index 5d6aef956b13..88cb426d3aec 100644
> --- a/drivers/pci/endpoint/pci-epc-core.c
> +++ b/drivers/pci/endpoint/pci-epc-core.c
> @@ -649,7 +649,7 @@ EXPORT_SYMBOL_GPL(pci_epc_set_bar);
> int pci_epc_bar_size_to_rebar_cap(size_t size, u32 *cap)
> {
> /*
> - * According to PCIe base spec, min size for a resizable BAR is 1 MB,
> + * As per PCIe r6.0, sec 7.8.6.2, min size for a resizable BAR is 1 MB,
> * thus disallow a requested BAR size smaller than 1 MB.
> * Disallow a requested BAR size larger than 128 TB.
> */
> --
> 2.48.1
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-19 17:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-19 17:14 [PATCH] PCI: endpoint: Improve reference in pci_epc_bar_size_to_rebar_cap() comment Niklas Cassel
2025-02-19 17:25 ` Manivannan Sadhasivam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.