From: Rob Herring <robh@kernel.org>
To: Claudiu Beznea <claudiu.beznea@tuxon.dev>
Cc: Ryan.Wanner@microchip.com, krzk+dt@kernel.org,
conor+dt@kernel.org, nicolas.ferre@microchip.com,
alexandre.belloni@bootlin.com, vkoul@kernel.org,
wim@linux-watchdog.org, linux@roeck-us.net,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 2/8] dt-bindings: watchdog: sama5d4-wdt: Add sama7d65-wdt
Date: Wed, 19 Feb 2025 16:59:56 -0600 [thread overview]
Message-ID: <20250219225956.GA3127467-robh@kernel.org> (raw)
In-Reply-To: <a1ebb518-ff69-4dff-a8b4-7c3b716450a5@tuxon.dev>
On Tue, Feb 18, 2025 at 10:42:36AM +0200, Claudiu Beznea wrote:
>
>
> On 14.02.2025 20:08, Ryan.Wanner@microchip.com wrote:
> > From: Ryan Wanner <Ryan.Wanner@microchip.com>
> >
> > Add microchip,sama7d65-wdt compatible string to the dt-binding documentation.
> >
> > Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
> > ---
> > .../devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> > index cdf87db361837..e9c026194d403 100644
> > --- a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> > @@ -23,6 +23,9 @@ properties:
> > - const: microchip,sam9x7-wdt
> > - const: microchip,sam9x60-wdt
> >
>
> You could have keep this new line after the items section that you've added.
>
> > + - items:
> > + - const: microchip,sama7d65-wdt
> > + - const: microchip,sama7g5-wdt
>
> here.
Please do.
>
> > reg:
> > maxItems: 1
> >
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Claudiu Beznea <claudiu.beznea@tuxon.dev>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org,
Ryan.Wanner@microchip.com, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org, alexandre.belloni@bootlin.com,
vkoul@kernel.org, linux-arm-kernel@lists.infradead.org,
dmaengine@vger.kernel.org, krzk+dt@kernel.org,
wim@linux-watchdog.org, linux@roeck-us.net
Subject: Re: [PATCH 2/8] dt-bindings: watchdog: sama5d4-wdt: Add sama7d65-wdt
Date: Wed, 19 Feb 2025 16:59:56 -0600 [thread overview]
Message-ID: <20250219225956.GA3127467-robh@kernel.org> (raw)
In-Reply-To: <a1ebb518-ff69-4dff-a8b4-7c3b716450a5@tuxon.dev>
On Tue, Feb 18, 2025 at 10:42:36AM +0200, Claudiu Beznea wrote:
>
>
> On 14.02.2025 20:08, Ryan.Wanner@microchip.com wrote:
> > From: Ryan Wanner <Ryan.Wanner@microchip.com>
> >
> > Add microchip,sama7d65-wdt compatible string to the dt-binding documentation.
> >
> > Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
> > ---
> > .../devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> > index cdf87db361837..e9c026194d403 100644
> > --- a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> > @@ -23,6 +23,9 @@ properties:
> > - const: microchip,sam9x7-wdt
> > - const: microchip,sam9x60-wdt
> >
>
> You could have keep this new line after the items section that you've added.
>
> > + - items:
> > + - const: microchip,sama7d65-wdt
> > + - const: microchip,sama7g5-wdt
>
> here.
Please do.
>
> > reg:
> > maxItems: 1
> >
>
next prev parent reply other threads:[~2025-02-19 22:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 18:08 [PATCH 0/8] Add System Components for Microchip SAMA7D65 SoC Ryan.Wanner
2025-02-14 18:08 ` [PATCH 1/8] dt-bindings: atmel-sysreg: Add SAMA7D65 Chip ID Ryan.Wanner
2025-02-19 22:59 ` Rob Herring
2025-02-19 22:59 ` Rob Herring
2025-02-14 18:08 ` [PATCH 2/8] dt-bindings: watchdog: sama5d4-wdt: Add sama7d65-wdt Ryan.Wanner
2025-02-18 8:42 ` Claudiu Beznea
2025-02-19 22:59 ` Rob Herring [this message]
2025-02-19 22:59 ` Rob Herring
2025-02-14 18:08 ` [PATCH 3/8] dt-bindings: dma: atmel: add microchip,sama7d65-dma Ryan.Wanner
2025-02-19 23:00 ` Rob Herring (Arm)
2025-02-19 23:00 ` Rob Herring (Arm)
2025-02-14 18:08 ` [PATCH 4/8] ARM: at91: Add Support in SoC driver for SAMA7D65 Ryan.Wanner
2025-02-14 18:08 ` [PATCH 5/8] ARM: dts: microchip: sama7d65: Add chipID for sama7d65 Ryan.Wanner
2025-02-14 18:08 ` [PATCH 6/8] ARM: dts: microchip: sama7d65: Add watchdog " Ryan.Wanner
2025-02-24 11:43 ` Claudiu Beznea
2025-02-14 18:08 ` [PATCH 7/8] ARM: dts: microchip: sama7d65: Add DMAs to sama7d65 SoC Ryan.Wanner
2025-02-18 8:41 ` Claudiu Beznea
2025-02-14 18:08 ` [PATCH 8/8] ARM: dts: microchip: sama7d65: Enable DMAs Ryan.Wanner
2025-02-18 8:45 ` [PATCH 0/8] Add System Components for Microchip SAMA7D65 SoC Claudiu Beznea
2025-02-19 0:42 ` Rob Herring (Arm)
2025-02-19 0:42 ` Rob Herring (Arm)
2025-02-25 16:33 ` Claudiu Beznea
2025-02-27 12:07 ` (subset) " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250219225956.GA3127467-robh@kernel.org \
--to=robh@kernel.org \
--cc=Ryan.Wanner@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nicolas.ferre@microchip.com \
--cc=vkoul@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.