From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Srikanth Yalavarthi <syalavarthi@marvell.com>
Subject: [PATCH v2 12/14] mldev: remove unnecessary deref of function pointers
Date: Wed, 19 Feb 2025 18:32:16 -0800 [thread overview]
Message-ID: <20250220023509.630569-13-stephen@networkplumber.org> (raw)
In-Reply-To: <20250220023509.630569-1-stephen@networkplumber.org>
The expression *dev->dev_ops->dev_info_get and
dev->dev_ops->dev_info_get are equivalent in C.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/mldev/rte_mldev.c | 88 +++++++++++++++++++++----------------------
1 file changed, 44 insertions(+), 44 deletions(-)
diff --git a/lib/mldev/rte_mldev.c b/lib/mldev/rte_mldev.c
index 37d71aebc9..e0e5b8d9e8 100644
--- a/lib/mldev/rte_mldev.c
+++ b/lib/mldev/rte_mldev.c
@@ -237,7 +237,7 @@ rte_ml_dev_info_get(int16_t dev_id, struct rte_ml_dev_info *dev_info)
}
dev = rte_ml_dev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->dev_info_get == NULL)
+ if (dev->dev_ops->dev_info_get == NULL)
return -ENOTSUP;
if (dev_info == NULL) {
@@ -246,7 +246,7 @@ rte_ml_dev_info_get(int16_t dev_id, struct rte_ml_dev_info *dev_info)
}
memset(dev_info, 0, sizeof(struct rte_ml_dev_info));
- return (*dev->dev_ops->dev_info_get)(dev, dev_info);
+ return dev->dev_ops->dev_info_get(dev, dev_info);
}
int
@@ -262,7 +262,7 @@ rte_ml_dev_configure(int16_t dev_id, const struct rte_ml_dev_config *config)
}
dev = rte_ml_dev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->dev_configure == NULL)
+ if (dev->dev_ops->dev_configure == NULL)
return -ENOTSUP;
if (dev->data->dev_started) {
@@ -285,7 +285,7 @@ rte_ml_dev_configure(int16_t dev_id, const struct rte_ml_dev_config *config)
return -EINVAL;
}
- return (*dev->dev_ops->dev_configure)(dev, config);
+ return dev->dev_ops->dev_configure(dev, config);
}
int
@@ -299,7 +299,7 @@ rte_ml_dev_close(int16_t dev_id)
}
dev = rte_ml_dev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->dev_close == NULL)
+ if (dev->dev_ops->dev_close == NULL)
return -ENOTSUP;
/* Device must be stopped before it can be closed */
@@ -308,7 +308,7 @@ rte_ml_dev_close(int16_t dev_id)
return -EBUSY;
}
- return (*dev->dev_ops->dev_close)(dev);
+ return dev->dev_ops->dev_close(dev);
}
int
@@ -323,7 +323,7 @@ rte_ml_dev_start(int16_t dev_id)
}
dev = rte_ml_dev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->dev_start == NULL)
+ if (dev->dev_ops->dev_start == NULL)
return -ENOTSUP;
if (dev->data->dev_started != 0) {
@@ -331,7 +331,7 @@ rte_ml_dev_start(int16_t dev_id)
return -EBUSY;
}
- ret = (*dev->dev_ops->dev_start)(dev);
+ ret = dev->dev_ops->dev_start(dev);
if (ret == 0)
dev->data->dev_started = 1;
@@ -350,7 +350,7 @@ rte_ml_dev_stop(int16_t dev_id)
}
dev = rte_ml_dev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->dev_stop == NULL)
+ if (dev->dev_ops->dev_stop == NULL)
return -ENOTSUP;
if (dev->data->dev_started == 0) {
@@ -358,7 +358,7 @@ rte_ml_dev_stop(int16_t dev_id)
return -EBUSY;
}
- ret = (*dev->dev_ops->dev_stop)(dev);
+ ret = dev->dev_ops->dev_stop(dev);
if (ret == 0)
dev->data->dev_started = 0;
@@ -392,7 +392,7 @@ rte_ml_dev_queue_pair_setup(int16_t dev_id, uint16_t queue_pair_id,
}
dev = rte_ml_dev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->dev_queue_pair_setup == NULL)
+ if (dev->dev_ops->dev_queue_pair_setup == NULL)
return -ENOTSUP;
if (queue_pair_id >= dev->data->nb_queue_pairs) {
@@ -410,7 +410,7 @@ rte_ml_dev_queue_pair_setup(int16_t dev_id, uint16_t queue_pair_id,
return -EBUSY;
}
- return (*dev->dev_ops->dev_queue_pair_setup)(dev, queue_pair_id, qp_conf, socket_id);
+ return dev->dev_ops->dev_queue_pair_setup(dev, queue_pair_id, qp_conf, socket_id);
}
int
@@ -424,7 +424,7 @@ rte_ml_dev_stats_get(int16_t dev_id, struct rte_ml_dev_stats *stats)
}
dev = rte_ml_dev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->dev_stats_get == NULL)
+ if (dev->dev_ops->dev_stats_get == NULL)
return -ENOTSUP;
if (stats == NULL) {
@@ -433,7 +433,7 @@ rte_ml_dev_stats_get(int16_t dev_id, struct rte_ml_dev_stats *stats)
}
memset(stats, 0, sizeof(struct rte_ml_dev_stats));
- return (*dev->dev_ops->dev_stats_get)(dev, stats);
+ return dev->dev_ops->dev_stats_get(dev, stats);
}
void
@@ -447,10 +447,10 @@ rte_ml_dev_stats_reset(int16_t dev_id)
}
dev = rte_ml_dev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->dev_stats_reset == NULL)
+ if (dev->dev_ops->dev_stats_reset == NULL)
return;
- (*dev->dev_ops->dev_stats_reset)(dev);
+ dev->dev_ops->dev_stats_reset(dev);
}
int
@@ -465,10 +465,10 @@ rte_ml_dev_xstats_names_get(int16_t dev_id, enum rte_ml_dev_xstats_mode mode, in
}
dev = rte_ml_dev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->dev_xstats_names_get == NULL)
+ if (dev->dev_ops->dev_xstats_names_get == NULL)
return -ENOTSUP;
- return (*dev->dev_ops->dev_xstats_names_get)(dev, mode, model_id, xstats_map, size);
+ return dev->dev_ops->dev_xstats_names_get(dev, mode, model_id, xstats_map, size);
}
int
@@ -482,7 +482,7 @@ rte_ml_dev_xstats_by_name_get(int16_t dev_id, const char *name, uint16_t *stat_i
}
dev = rte_ml_dev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->dev_xstats_by_name_get == NULL)
+ if (dev->dev_ops->dev_xstats_by_name_get == NULL)
return -ENOTSUP;
if (name == NULL) {
@@ -495,7 +495,7 @@ rte_ml_dev_xstats_by_name_get(int16_t dev_id, const char *name, uint16_t *stat_i
return -EINVAL;
}
- return (*dev->dev_ops->dev_xstats_by_name_get)(dev, name, stat_id, value);
+ return dev->dev_ops->dev_xstats_by_name_get(dev, name, stat_id, value);
}
int
@@ -510,7 +510,7 @@ rte_ml_dev_xstats_get(int16_t dev_id, enum rte_ml_dev_xstats_mode mode, int32_t
}
dev = rte_ml_dev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->dev_xstats_get == NULL)
+ if (dev->dev_ops->dev_xstats_get == NULL)
return -ENOTSUP;
if (stat_ids == NULL) {
@@ -523,7 +523,7 @@ rte_ml_dev_xstats_get(int16_t dev_id, enum rte_ml_dev_xstats_mode mode, int32_t
return -EINVAL;
}
- return (*dev->dev_ops->dev_xstats_get)(dev, mode, model_id, stat_ids, values, nb_ids);
+ return dev->dev_ops->dev_xstats_get(dev, mode, model_id, stat_ids, values, nb_ids);
}
int
@@ -538,10 +538,10 @@ rte_ml_dev_xstats_reset(int16_t dev_id, enum rte_ml_dev_xstats_mode mode, int32_
}
dev = rte_ml_dev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->dev_xstats_reset == NULL)
+ if (dev->dev_ops->dev_xstats_reset == NULL)
return -ENOTSUP;
- return (*dev->dev_ops->dev_xstats_reset)(dev, mode, model_id, stat_ids, nb_ids);
+ return dev->dev_ops->dev_xstats_reset(dev, mode, model_id, stat_ids, nb_ids);
}
int
@@ -555,7 +555,7 @@ rte_ml_dev_dump(int16_t dev_id, FILE *fd)
}
dev = rte_ml_dev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->dev_dump == NULL)
+ if (dev->dev_ops->dev_dump == NULL)
return -ENOTSUP;
if (fd == NULL) {
@@ -563,7 +563,7 @@ rte_ml_dev_dump(int16_t dev_id, FILE *fd)
return -EINVAL;
}
- return (*dev->dev_ops->dev_dump)(dev, fd);
+ return dev->dev_ops->dev_dump(dev, fd);
}
int
@@ -577,10 +577,10 @@ rte_ml_dev_selftest(int16_t dev_id)
}
dev = rte_ml_dev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->dev_selftest == NULL)
+ if (dev->dev_ops->dev_selftest == NULL)
return -ENOTSUP;
- return (*dev->dev_ops->dev_selftest)(dev);
+ return dev->dev_ops->dev_selftest(dev);
}
int
@@ -594,7 +594,7 @@ rte_ml_model_load(int16_t dev_id, struct rte_ml_model_params *params, uint16_t *
}
dev = rte_ml_dev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->model_load == NULL)
+ if (dev->dev_ops->model_load == NULL)
return -ENOTSUP;
if (params == NULL) {
@@ -607,7 +607,7 @@ rte_ml_model_load(int16_t dev_id, struct rte_ml_model_params *params, uint16_t *
return -EINVAL;
}
- return (*dev->dev_ops->model_load)(dev, params, model_id);
+ return dev->dev_ops->model_load(dev, params, model_id);
}
int
@@ -621,10 +621,10 @@ rte_ml_model_unload(int16_t dev_id, uint16_t model_id)
}
dev = rte_ml_dev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->model_unload == NULL)
+ if (dev->dev_ops->model_unload == NULL)
return -ENOTSUP;
- return (*dev->dev_ops->model_unload)(dev, model_id);
+ return dev->dev_ops->model_unload(dev, model_id);
}
int
@@ -638,10 +638,10 @@ rte_ml_model_start(int16_t dev_id, uint16_t model_id)
}
dev = rte_ml_dev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->model_start == NULL)
+ if (dev->dev_ops->model_start == NULL)
return -ENOTSUP;
- return (*dev->dev_ops->model_start)(dev, model_id);
+ return dev->dev_ops->model_start(dev, model_id);
}
int
@@ -655,10 +655,10 @@ rte_ml_model_stop(int16_t dev_id, uint16_t model_id)
}
dev = rte_ml_dev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->model_stop == NULL)
+ if (dev->dev_ops->model_stop == NULL)
return -ENOTSUP;
- return (*dev->dev_ops->model_stop)(dev, model_id);
+ return dev->dev_ops->model_stop(dev, model_id);
}
int
@@ -672,7 +672,7 @@ rte_ml_model_info_get(int16_t dev_id, uint16_t model_id, struct rte_ml_model_inf
}
dev = rte_ml_dev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->model_info_get == NULL)
+ if (dev->dev_ops->model_info_get == NULL)
return -ENOTSUP;
if (model_info == NULL) {
@@ -681,7 +681,7 @@ rte_ml_model_info_get(int16_t dev_id, uint16_t model_id, struct rte_ml_model_inf
return -EINVAL;
}
- return (*dev->dev_ops->model_info_get)(dev, model_id, model_info);
+ return dev->dev_ops->model_info_get(dev, model_id, model_info);
}
int
@@ -695,7 +695,7 @@ rte_ml_model_params_update(int16_t dev_id, uint16_t model_id, void *buffer)
}
dev = rte_ml_dev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->model_params_update == NULL)
+ if (dev->dev_ops->model_params_update == NULL)
return -ENOTSUP;
if (buffer == NULL) {
@@ -703,7 +703,7 @@ rte_ml_model_params_update(int16_t dev_id, uint16_t model_id, void *buffer)
return -EINVAL;
}
- return (*dev->dev_ops->model_params_update)(dev, model_id, buffer);
+ return dev->dev_ops->model_params_update(dev, model_id, buffer);
}
int
@@ -718,7 +718,7 @@ rte_ml_io_quantize(int16_t dev_id, uint16_t model_id, struct rte_ml_buff_seg **d
}
dev = rte_ml_dev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->io_quantize == NULL)
+ if (dev->dev_ops->io_quantize == NULL)
return -ENOTSUP;
if (dbuffer == NULL) {
@@ -731,7 +731,7 @@ rte_ml_io_quantize(int16_t dev_id, uint16_t model_id, struct rte_ml_buff_seg **d
return -EINVAL;
}
- return (*dev->dev_ops->io_quantize)(dev, model_id, dbuffer, qbuffer);
+ return dev->dev_ops->io_quantize(dev, model_id, dbuffer, qbuffer);
}
int
@@ -746,7 +746,7 @@ rte_ml_io_dequantize(int16_t dev_id, uint16_t model_id, struct rte_ml_buff_seg *
}
dev = rte_ml_dev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->io_dequantize == NULL)
+ if (dev->dev_ops->io_dequantize == NULL)
return -ENOTSUP;
if (qbuffer == NULL) {
@@ -759,7 +759,7 @@ rte_ml_io_dequantize(int16_t dev_id, uint16_t model_id, struct rte_ml_buff_seg *
return -EINVAL;
}
- return (*dev->dev_ops->io_dequantize)(dev, model_id, qbuffer, dbuffer);
+ return dev->dev_ops->io_dequantize(dev, model_id, qbuffer, dbuffer);
}
/** Initialise rte_ml_op mempool element */
--
2.47.2
next prev parent reply other threads:[~2025-02-20 2:36 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 18:53 [RFC 00/11] Fix dev_ops dereferences Stephen Hemminger
2025-02-17 18:54 ` [RFC 01/11] ethdev: remove unnecessary deref on function pointers Stephen Hemminger
2025-02-17 18:54 ` [RFC 02/11] eventdev: remover " Stephen Hemminger
2025-02-17 18:54 ` [RFC 03/11] net/ixgbe: remove unnecessary dereference Stephen Hemminger
2025-02-17 18:54 ` [RFC 04/11] net/memif: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-17 18:54 ` [RFC 05/11] cryptodev: " Stephen Hemminger
2025-02-17 18:54 ` [RFC 06/11] crypto/scheduler: remove unnecessary dereference Stephen Hemminger
2025-02-17 18:54 ` [RFC 07/11] compressdev: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-17 18:54 ` [RFC 08/11] dmadev: " Stephen Hemminger
2025-02-17 18:54 ` [RFC 09/11] rawdev: " Stephen Hemminger
2025-02-17 18:54 ` [RFC 10/11] mldev: " Stephen Hemminger
2025-02-17 18:54 ` [RFC 11/11] regexdev: " Stephen Hemminger
2025-02-17 20:24 ` [RFC 00/11] Fix dev_ops dereferences Morten Brørup
2025-02-18 3:01 ` Stephen Hemminger
2025-02-18 8:47 ` Bruce Richardson
2025-02-20 2:32 ` [PATCH v2 00/14] Remove unnecessary function pointer deref Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 01/14] ethdev: remove unnecessary deref on function pointers Stephen Hemminger
2025-02-20 7:09 ` Andrew Rybchenko
2025-02-20 16:09 ` Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 02/14] eventdev: remover " Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 03/14] net/bonding: remove unnecessary deref of " Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 04/14] net/ixgbe: remove unnecessary dereference Stephen Hemminger
2025-02-20 9:17 ` Bruce Richardson
2025-02-20 2:32 ` [PATCH v2 05/14] net/ipn3ke: " Stephen Hemminger
2025-02-26 8:52 ` Xu, Rosen
2025-02-20 2:32 ` [PATCH v2 06/14] net/memif: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 07/14] cryptodev: " Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 08/14] crypto/scheduler: remove unnecessary dereference Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 09/14] compressdev: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 10/14] dmadev: " Stephen Hemminger
2025-02-20 3:00 ` fengchengwen
2025-02-20 2:32 ` [PATCH v2 11/14] rawdev: " Stephen Hemminger
2025-02-20 2:32 ` Stephen Hemminger [this message]
2025-02-20 2:32 ` [PATCH v2 13/14] regexdev: " Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 14/14] security: remove unnecessary dereference Stephen Hemminger
2025-02-20 8:05 ` [PATCH v2 00/14] Remove unnecessary function pointer deref Morten Brørup
2025-02-20 9:17 ` Bruce Richardson
2025-02-20 16:55 ` [PATCH v3 " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 01/14] ethdev: remove unnecessary deref on function pointers Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 02/14] eventdev: remover " Stephen Hemminger
2025-02-25 13:02 ` Gujjar, Abhinandan S
2025-02-25 13:18 ` Pavan Nikhilesh Bhagavatula
2025-02-25 13:27 ` Amit Prakash Shukla
2025-02-20 16:55 ` [PATCH v3 03/14] net/bonding: remove unnecessary deref of " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 04/14] net/ixgbe: remove unnecessary dereference Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 05/14] net/ipn3ke: " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 06/14] net/memif: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 07/14] cryptodev: " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 08/14] crypto/scheduler: remove unnecessary dereference Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 09/14] compressdev: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 10/14] dmadev: " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 11/14] rawdev: " Stephen Hemminger
2025-02-21 9:12 ` Hemant Agrawal
2025-02-20 16:55 ` [PATCH v3 12/14] mldev: " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 13/14] regexdev: " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 14/14] security: remove unnecessary dereference Stephen Hemminger
2025-03-05 16:52 ` [PATCH v3 00/14] Remove unnecessary function pointer deref David Marchand
2025-03-10 22:26 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220023509.630569-13-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=syalavarthi@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.