From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: "Stephen Hemminger" <stephen@networkplumber.org>,
"Morten Brørup" <mb@smartsharesystems.com>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"Akhil Goyal" <gakhil@marvell.com>,
"Fan Zhang" <fanzhang.oss@gmail.com>
Subject: [PATCH v3 07/14] cryptodev: remove unnecessary deref of function pointers
Date: Thu, 20 Feb 2025 08:55:21 -0800 [thread overview]
Message-ID: <20250220165644.16421-8-stephen@networkplumber.org> (raw)
In-Reply-To: <20250220165644.16421-1-stephen@networkplumber.org>
The expression *dev->dev_ops->dev_info_gets and
dev->dev_ops->dev_info_gets are equivalent.
Cleanup and remove unnecessary parenthesis as well.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
lib/cryptodev/rte_cryptodev.c | 72 +++++++++++++++++------------------
1 file changed, 35 insertions(+), 37 deletions(-)
diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c
index a49b0662f3..8df36ea057 100644
--- a/lib/cryptodev/rte_cryptodev.c
+++ b/lib/cryptodev/rte_cryptodev.c
@@ -1194,9 +1194,9 @@ rte_cryptodev_queue_pairs_config(struct rte_cryptodev *dev, uint16_t nb_qpairs,
memset(&dev_info, 0, sizeof(struct rte_cryptodev_info));
- if (*dev->dev_ops->dev_infos_get == NULL)
+ if (dev->dev_ops->dev_infos_get == NULL)
return -ENOTSUP;
- (*dev->dev_ops->dev_infos_get)(dev, &dev_info);
+ dev->dev_ops->dev_infos_get(dev, &dev_info);
if (nb_qpairs > (dev_info.max_nb_queue_pairs)) {
CDEV_LOG_ERR("Invalid num queue_pairs (%u) for dev %u",
@@ -1224,11 +1224,11 @@ rte_cryptodev_queue_pairs_config(struct rte_cryptodev *dev, uint16_t nb_qpairs,
qp = dev->data->queue_pairs;
- if (*dev->dev_ops->queue_pair_release == NULL)
+ if (dev->dev_ops->queue_pair_release == NULL)
return -ENOTSUP;
for (i = nb_qpairs; i < old_nb_queues; i++) {
- ret = (*dev->dev_ops->queue_pair_release)(dev, i);
+ ret = dev->dev_ops->queue_pair_release(dev, i);
if (ret < 0)
return ret;
qp[i] = NULL;
@@ -1256,11 +1256,11 @@ rte_cryptodev_queue_pair_reset(uint8_t dev_id, uint16_t queue_pair_id,
return -EINVAL;
}
- if (*dev->dev_ops->queue_pair_reset == NULL)
+ if (dev->dev_ops->queue_pair_reset == NULL)
return -ENOTSUP;
rte_cryptodev_trace_queue_pair_reset(dev_id, queue_pair_id, qp_conf, socket_id);
- return (*dev->dev_ops->queue_pair_reset)(dev, queue_pair_id, qp_conf, socket_id);
+ return dev->dev_ops->queue_pair_reset(dev, queue_pair_id, qp_conf, socket_id);
}
int
@@ -1282,7 +1282,7 @@ rte_cryptodev_configure(uint8_t dev_id, struct rte_cryptodev_config *config)
return -EBUSY;
}
- if (*dev->dev_ops->dev_configure == NULL)
+ if (dev->dev_ops->dev_configure == NULL)
return -ENOTSUP;
rte_spinlock_lock(&rte_cryptodev_callback_lock);
@@ -1307,7 +1307,7 @@ rte_cryptodev_configure(uint8_t dev_id, struct rte_cryptodev_config *config)
}
rte_cryptodev_trace_configure(dev_id, config);
- return (*dev->dev_ops->dev_configure)(dev, config);
+ return dev->dev_ops->dev_configure(dev, config);
}
int
@@ -1325,7 +1325,7 @@ rte_cryptodev_start(uint8_t dev_id)
dev = &rte_crypto_devices[dev_id];
- if (*dev->dev_ops->dev_start == NULL)
+ if (dev->dev_ops->dev_start == NULL)
return -ENOTSUP;
if (dev->data->dev_started != 0) {
@@ -1334,7 +1334,7 @@ rte_cryptodev_start(uint8_t dev_id)
return 0;
}
- diag = (*dev->dev_ops->dev_start)(dev);
+ diag = dev->dev_ops->dev_start(dev);
/* expose selection of PMD fast-path functions */
cryptodev_fp_ops_set(rte_crypto_fp_ops + dev_id, dev);
@@ -1359,7 +1359,7 @@ rte_cryptodev_stop(uint8_t dev_id)
dev = &rte_crypto_devices[dev_id];
- if (*dev->dev_ops->dev_stop == NULL)
+ if (dev->dev_ops->dev_stop == NULL)
return;
if (dev->data->dev_started == 0) {
@@ -1371,7 +1371,7 @@ rte_cryptodev_stop(uint8_t dev_id)
/* point fast-path functions to dummy ones */
cryptodev_fp_ops_reset(rte_crypto_fp_ops + dev_id);
- (*dev->dev_ops->dev_stop)(dev);
+ dev->dev_ops->dev_stop(dev);
rte_cryptodev_trace_stop(dev_id);
dev->data->dev_started = 0;
}
@@ -1407,9 +1407,9 @@ rte_cryptodev_close(uint8_t dev_id)
}
}
- if (*dev->dev_ops->dev_close == NULL)
+ if (dev->dev_ops->dev_close == NULL)
return -ENOTSUP;
- retval = (*dev->dev_ops->dev_close)(dev);
+ retval = dev->dev_ops->dev_close(dev);
rte_cryptodev_trace_close(dev_id, retval);
if (retval < 0)
@@ -1518,12 +1518,11 @@ rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id,
return -EBUSY;
}
- if (*dev->dev_ops->queue_pair_setup == NULL)
+ if (dev->dev_ops->queue_pair_setup == NULL)
return -ENOTSUP;
rte_cryptodev_trace_queue_pair_setup(dev_id, queue_pair_id, qp_conf);
- return (*dev->dev_ops->queue_pair_setup)(dev, queue_pair_id, qp_conf,
- socket_id);
+ return dev->dev_ops->queue_pair_setup(dev, queue_pair_id, qp_conf, socket_id);
}
struct rte_cryptodev_cb *
@@ -1837,9 +1836,9 @@ rte_cryptodev_stats_get(uint8_t dev_id, struct rte_cryptodev_stats *stats)
dev = &rte_crypto_devices[dev_id];
memset(stats, 0, sizeof(*stats));
- if (*dev->dev_ops->stats_get == NULL)
+ if (dev->dev_ops->stats_get == NULL)
return -ENOTSUP;
- (*dev->dev_ops->stats_get)(dev, stats);
+ dev->dev_ops->stats_get(dev, stats);
rte_cryptodev_trace_stats_get(dev_id, stats);
return 0;
@@ -1859,9 +1858,9 @@ rte_cryptodev_stats_reset(uint8_t dev_id)
dev = &rte_crypto_devices[dev_id];
- if (*dev->dev_ops->stats_reset == NULL)
+ if (dev->dev_ops->stats_reset == NULL)
return;
- (*dev->dev_ops->stats_reset)(dev);
+ dev->dev_ops->stats_reset(dev);
}
void
@@ -1878,9 +1877,9 @@ rte_cryptodev_info_get(uint8_t dev_id, struct rte_cryptodev_info *dev_info)
memset(dev_info, 0, sizeof(struct rte_cryptodev_info));
- if (*dev->dev_ops->dev_infos_get == NULL)
+ if (dev->dev_ops->dev_infos_get == NULL)
return;
- (*dev->dev_ops->dev_infos_get)(dev, dev_info);
+ dev->dev_ops->dev_infos_get(dev, dev_info);
dev_info->driver_name = dev->device->driver->name;
dev_info->device = dev->device;
@@ -2017,7 +2016,7 @@ rte_cryptodev_queue_pair_event_error_query(uint8_t dev_id, uint16_t qp_id)
if (qp_id >= dev->data->nb_queue_pairs)
return -EINVAL;
- if (*dev->dev_ops->queue_pair_event_error_query == NULL)
+ if (dev->dev_ops->queue_pair_event_error_query == NULL)
return -ENOTSUP;
return dev->dev_ops->queue_pair_event_error_query(dev, qp_id);
@@ -2237,7 +2236,7 @@ rte_cryptodev_asym_session_create(uint8_t dev_id,
/* Clear device session pointer.*/
memset(sess->sess_private_data, 0, session_priv_data_sz + sess->user_data_sz);
- if (*dev->dev_ops->asym_session_configure == NULL)
+ if (dev->dev_ops->asym_session_configure == NULL)
return -ENOTSUP;
if (sess->sess_private_data[0] == 0) {
@@ -2286,7 +2285,7 @@ rte_cryptodev_sym_session_free(uint8_t dev_id, void *_sess)
return -EINVAL;
}
- if (*dev->dev_ops->sym_session_clear == NULL)
+ if (dev->dev_ops->sym_session_clear == NULL)
return -ENOTSUP;
dev->dev_ops->sym_session_clear(dev, sess);
@@ -2316,7 +2315,7 @@ rte_cryptodev_asym_session_free(uint8_t dev_id, void *sess)
if (dev == NULL || sess == NULL)
return -EINVAL;
- if (*dev->dev_ops->asym_session_clear == NULL)
+ if (dev->dev_ops->asym_session_clear == NULL)
return -ENOTSUP;
dev->dev_ops->asym_session_clear(dev, sess);
@@ -2348,10 +2347,10 @@ rte_cryptodev_sym_get_private_session_size(uint8_t dev_id)
dev = rte_cryptodev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->sym_session_get_size == NULL)
+ if (dev->dev_ops->sym_session_get_size == NULL)
return 0;
- priv_sess_size = (*dev->dev_ops->sym_session_get_size)(dev);
+ priv_sess_size = dev->dev_ops->sym_session_get_size(dev);
rte_cryptodev_trace_sym_get_private_session_size(dev_id,
priv_sess_size);
@@ -2370,10 +2369,10 @@ rte_cryptodev_asym_get_private_session_size(uint8_t dev_id)
dev = rte_cryptodev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->asym_session_get_size == NULL)
+ if (dev->dev_ops->asym_session_get_size == NULL)
return 0;
- priv_sess_size = (*dev->dev_ops->asym_session_get_size)(dev);
+ priv_sess_size = dev->dev_ops->asym_session_get_size(dev);
rte_cryptodev_trace_asym_get_private_session_size(dev_id,
priv_sess_size);
@@ -2474,7 +2473,7 @@ rte_cryptodev_sym_cpu_crypto_process(uint8_t dev_id,
dev = rte_cryptodev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->sym_cpu_process == NULL ||
+ if (dev->dev_ops->sym_cpu_process == NULL ||
!(dev->feature_flags & RTE_CRYPTODEV_FF_SYM_CPU_CRYPTO)) {
sym_crypto_fill_status(vec, ENOTSUP);
return 0;
@@ -2497,12 +2496,12 @@ rte_cryptodev_get_raw_dp_ctx_size(uint8_t dev_id)
dev = rte_cryptodev_pmd_get_dev(dev_id);
- if (*dev->dev_ops->sym_get_raw_dp_ctx_size == NULL ||
+ if (dev->dev_ops->sym_get_raw_dp_ctx_size == NULL ||
!(dev->feature_flags & RTE_CRYPTODEV_FF_SYM_RAW_DP)) {
return -ENOTSUP;
}
- priv_size = (*dev->dev_ops->sym_get_raw_dp_ctx_size)(dev);
+ priv_size = dev->dev_ops->sym_get_raw_dp_ctx_size(dev);
if (priv_size < 0)
return -ENOTSUP;
@@ -2530,7 +2529,7 @@ rte_cryptodev_configure_raw_dp_ctx(uint8_t dev_id, uint16_t qp_id,
rte_cryptodev_trace_configure_raw_dp_ctx(dev_id, qp_id, sess_type);
- return (*dev->dev_ops->sym_configure_raw_dp_ctx)(dev, qp_id, ctx,
+ return dev->dev_ops->sym_configure_raw_dp_ctx(dev, qp_id, ctx,
sess_type, session_ctx, is_update);
}
@@ -2556,8 +2555,7 @@ rte_cryptodev_session_event_mdata_set(uint8_t dev_id, void *sess,
rte_cryptodev_trace_session_event_mdata_set(dev_id, sess, op_type,
sess_type, ev_mdata, size);
- return (*dev->dev_ops->session_ev_mdata_set)(dev, sess, op_type,
- sess_type, ev_mdata);
+ return dev->dev_ops->session_ev_mdata_set(dev, sess, op_type, sess_type, ev_mdata);
skip_pmd_op:
if (op_type == RTE_CRYPTO_OP_TYPE_SYMMETRIC)
--
2.47.2
next prev parent reply other threads:[~2025-02-20 16:57 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 18:53 [RFC 00/11] Fix dev_ops dereferences Stephen Hemminger
2025-02-17 18:54 ` [RFC 01/11] ethdev: remove unnecessary deref on function pointers Stephen Hemminger
2025-02-17 18:54 ` [RFC 02/11] eventdev: remover " Stephen Hemminger
2025-02-17 18:54 ` [RFC 03/11] net/ixgbe: remove unnecessary dereference Stephen Hemminger
2025-02-17 18:54 ` [RFC 04/11] net/memif: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-17 18:54 ` [RFC 05/11] cryptodev: " Stephen Hemminger
2025-02-17 18:54 ` [RFC 06/11] crypto/scheduler: remove unnecessary dereference Stephen Hemminger
2025-02-17 18:54 ` [RFC 07/11] compressdev: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-17 18:54 ` [RFC 08/11] dmadev: " Stephen Hemminger
2025-02-17 18:54 ` [RFC 09/11] rawdev: " Stephen Hemminger
2025-02-17 18:54 ` [RFC 10/11] mldev: " Stephen Hemminger
2025-02-17 18:54 ` [RFC 11/11] regexdev: " Stephen Hemminger
2025-02-17 20:24 ` [RFC 00/11] Fix dev_ops dereferences Morten Brørup
2025-02-18 3:01 ` Stephen Hemminger
2025-02-18 8:47 ` Bruce Richardson
2025-02-20 2:32 ` [PATCH v2 00/14] Remove unnecessary function pointer deref Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 01/14] ethdev: remove unnecessary deref on function pointers Stephen Hemminger
2025-02-20 7:09 ` Andrew Rybchenko
2025-02-20 16:09 ` Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 02/14] eventdev: remover " Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 03/14] net/bonding: remove unnecessary deref of " Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 04/14] net/ixgbe: remove unnecessary dereference Stephen Hemminger
2025-02-20 9:17 ` Bruce Richardson
2025-02-20 2:32 ` [PATCH v2 05/14] net/ipn3ke: " Stephen Hemminger
2025-02-26 8:52 ` Xu, Rosen
2025-02-20 2:32 ` [PATCH v2 06/14] net/memif: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 07/14] cryptodev: " Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 08/14] crypto/scheduler: remove unnecessary dereference Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 09/14] compressdev: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 10/14] dmadev: " Stephen Hemminger
2025-02-20 3:00 ` fengchengwen
2025-02-20 2:32 ` [PATCH v2 11/14] rawdev: " Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 12/14] mldev: " Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 13/14] regexdev: " Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 14/14] security: remove unnecessary dereference Stephen Hemminger
2025-02-20 8:05 ` [PATCH v2 00/14] Remove unnecessary function pointer deref Morten Brørup
2025-02-20 9:17 ` Bruce Richardson
2025-02-20 16:55 ` [PATCH v3 " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 01/14] ethdev: remove unnecessary deref on function pointers Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 02/14] eventdev: remover " Stephen Hemminger
2025-02-25 13:02 ` Gujjar, Abhinandan S
2025-02-25 13:18 ` Pavan Nikhilesh Bhagavatula
2025-02-25 13:27 ` Amit Prakash Shukla
2025-02-20 16:55 ` [PATCH v3 03/14] net/bonding: remove unnecessary deref of " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 04/14] net/ixgbe: remove unnecessary dereference Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 05/14] net/ipn3ke: " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 06/14] net/memif: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-20 16:55 ` Stephen Hemminger [this message]
2025-02-20 16:55 ` [PATCH v3 08/14] crypto/scheduler: remove unnecessary dereference Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 09/14] compressdev: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 10/14] dmadev: " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 11/14] rawdev: " Stephen Hemminger
2025-02-21 9:12 ` Hemant Agrawal
2025-02-20 16:55 ` [PATCH v3 12/14] mldev: " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 13/14] regexdev: " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 14/14] security: remove unnecessary dereference Stephen Hemminger
2025-03-05 16:52 ` [PATCH v3 00/14] Remove unnecessary function pointer deref David Marchand
2025-03-10 22:26 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220165644.16421-8-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=gakhil@marvell.com \
--cc=mb@smartsharesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.