From: David Sterba <dsterba@suse.cz>
To: Zorro Lang <zlang@kernel.org>
Cc: David Sterba <dsterba@suse.com>, fstests@vger.kernel.org
Subject: Re: [PATCH] fstests: remove reiserfs support
Date: Thu, 20 Feb 2025 21:37:51 +0100 [thread overview]
Message-ID: <20250220203751.GH5777@suse.cz> (raw)
In-Reply-To: <20250220202238.6axqgejzk47aay3j@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
On Fri, Feb 21, 2025 at 04:22:38AM +0800, Zorro Lang wrote:
> On Wed, Feb 19, 2025 at 11:17:43PM +0100, David Sterba wrote:
> > The linux kernel removed Reiserfs support in 6.13 so remove it from the
> > tests as well.
> >
> > Signed-off-by: David Sterba <dsterba@suse.com>
> > ---
> >
> > Arguably reiser4 support could be removed as well as there's no recent
> > upstream activity.
>
> Thanks for doing this :) But even with this patch, I still can find more
> "reiser*" related things as below. How about removing them all?
>
> zorro@zlang-laptop:~/git/upstream/xfs/xfstests-dev$ grep -rsni reiser .
> ./common/config:330:export MKFS_REISER4_PROG=$(type -P mkfs.reiser4)
> ./common/config:390: reiser4)
> ./common/config:391: # acls & xattrs aren't supported by reiser4
> ./common/config:392: echo $REISER4_MOUNT_OPTIONS
> ./common/config:443: reiser4)
> ./common/config:444: export MKFS_OPTIONS=$REISER4_MKFS_OPTIONS
> ./common/config:472: reiser*)
> ./common/config:540: reiser4)
> ./common/config:541: [ "$MKFS_REISER4_PROG" = "" ] && _fatal "mkfs.reiser4 not found"
> ./common/rc:1227: ext2|ext3|ext4|reiser4|ocfs2)
> ./common/rc:1331: reiser4)
> ./common/rc:1333: $MKFS_REISER4_PROG $MKFS_OPTIONS -y -b $blocksize "$@" $SCRATCH_DEV \
This is reiser4, the reasoning would be different as it's an out-of-tree
module but still somehow developed so there's a chance somebody is using
it.
next prev parent reply other threads:[~2025-02-20 20:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 22:17 [PATCH] fstests: remove reiserfs support David Sterba
2025-02-19 22:39 ` Darrick J. Wong
2025-02-20 20:22 ` Zorro Lang
2025-02-20 20:37 ` David Sterba [this message]
2025-02-21 5:19 ` Zorro Lang
2025-02-21 10:59 ` David Sterba
2025-02-21 15:45 ` Zorro Lang
2025-02-26 14:41 ` David Sterba
2025-02-27 7:35 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220203751.GH5777@suse.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=fstests@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.