All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Zorro Lang <zlang@redhat.com>
Cc: Zorro Lang <zlang@kernel.org>, David Sterba <dsterba@suse.com>,
	fstests@vger.kernel.org
Subject: Re: [PATCH] fstests: remove reiserfs support
Date: Wed, 26 Feb 2025 15:41:07 +0100	[thread overview]
Message-ID: <20250226144107.GU5777@suse.cz> (raw)
In-Reply-To: <20250221154531.ttch34qic7zsxyzv@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>

On Fri, Feb 21, 2025 at 11:45:31PM +0800, Zorro Lang wrote:
> > This may bring the question what is the policy for filesystem support.
> > I've seen "case $FSTYP" with widely inconsistent cases of filesystems,
> > probably the longest list is in common/rc:_require_scratch_nocheck with
> > 9p, virtiofs, afs, pvfs2 or ubifs.  It would be good to document that in
> > README, I haven't found anything in that regard.
> 
> Good idea, maybe we should have a list about that.
> 
> There's not a limitation about what filesystems are supported or not.
> Especially the generic test cases, some "not in list" filesystems might
> run generic tests too. So we don't exclude any filesystem which wants
> to try fstests.
> 
> Generally when someone wants to help fstests to support a new filesystem,
> there're 3 phases:
> 1) Check if fstests can mkfs, mount, unmount and fsck on this fs natively.
>    If it can't, add the fs to the "case...esac" list, to do special treatment.
> 2) Run generic test case on the new fs, fix some test failures which are
>    not suitable for this fs.
> 3) Add more test cases for this fs, might need a new tests/$FSTYP directory
>    and more common helpers.
> 
> Actually some of filesystems which are "supported" by xfstests, just satisfy
> the phase#1, or a few phase#2. That depends on how deeply that fs list
> would like to use xfstests.
> 
> But everything is still changing. For example, we don't support nfs much,
> just in phase#1. But as more and more nfs folks start to use xfstests,
> it's good to run on nfs now, even reach to part of phase#3. In contrast,
> although cifs is in the list, and xfstests can be run on it, but too
> many test failures, no one from cifs would like to care about that.
> 
> So about the "support list", what's the standard to count in a fs :)

Thanks, this is useful, can you please add this text to the README?

  reply	other threads:[~2025-02-26 14:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-19 22:17 [PATCH] fstests: remove reiserfs support David Sterba
2025-02-19 22:39 ` Darrick J. Wong
2025-02-20 20:22 ` Zorro Lang
2025-02-20 20:37   ` David Sterba
2025-02-21  5:19     ` Zorro Lang
2025-02-21 10:59       ` David Sterba
2025-02-21 15:45         ` Zorro Lang
2025-02-26 14:41           ` David Sterba [this message]
2025-02-27  7:35             ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250226144107.GU5777@suse.cz \
    --to=dsterba@suse.cz \
    --cc=dsterba@suse.com \
    --cc=fstests@vger.kernel.org \
    --cc=zlang@kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.