[PATCH] driver core: device.h: fix incorrect type in return expression

[PATCH] driver core: device.h: fix incorrect type in return expression

[xiaopeitux]

From: Pei Xiao <xiaopei01@kylinos.cn>

sparse warnings:
	sparse: incorrect type in return expression, expected void
[noderef] __iomem *, got void *

Fix sparse warnings by use IOMEM_ERR_PTR

Fixes: da7c07b10838 ("driver core: Provide stubs for !IOMEM builds")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501221439.YoPUrrqD-lkp@intel.com/
Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
---
 include/linux/device.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/device.h b/include/linux/device.h
index 667cb6db9019..d76c31b9f9b9 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -378,14 +378,14 @@ static inline
 void __iomem *devm_ioremap_resource(struct device *dev,
 				    const struct resource *res)
 {
-	return ERR_PTR(-EINVAL);
+	return IOMEM_ERR_PTR(-EINVAL);
 }
 
 static inline
 void __iomem *devm_ioremap_resource_wc(struct device *dev,
 				       const struct resource *res)
 {
-	return ERR_PTR(-EINVAL);
+	return IOMEM_ERR_PTR(-EINVAL);
 }
 
 static inline
@@ -393,7 +393,7 @@ void __iomem *devm_of_iomap(struct device *dev,
 			    struct device_node *node, int index,
 			    resource_size_t *size)
 {
-	return ERR_PTR(-EINVAL);
+	return IOMEM_ERR_PTR(-EINVAL);
 }
 
 #endif
-- 
2.25.1

Re: [PATCH] driver core: device.h: fix incorrect type in return expression

[Greg KH]

On Wed, Jan 22, 2025 at 03:35:03PM +0800, xiaopeitux@foxmail.com wrote:
> From: Pei Xiao <xiaopei01@kylinos.cn>
> 
> sparse warnings:
> 	sparse: incorrect type in return expression, expected void
> [noderef] __iomem *, got void *
> 
> Fix sparse warnings by use IOMEM_ERR_PTR
> 
> Fixes: da7c07b10838 ("driver core: Provide stubs for !IOMEM builds")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202501221439.YoPUrrqD-lkp@intel.com/
> Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
> ---
>  include/linux/device.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/device.h b/include/linux/device.h
> index 667cb6db9019..d76c31b9f9b9 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -378,14 +378,14 @@ static inline
>  void __iomem *devm_ioremap_resource(struct device *dev,
>  				    const struct resource *res)
>  {
> -	return ERR_PTR(-EINVAL);
> +	return IOMEM_ERR_PTR(-EINVAL);
>  }
>  
>  static inline
>  void __iomem *devm_ioremap_resource_wc(struct device *dev,
>  				       const struct resource *res)
>  {
> -	return ERR_PTR(-EINVAL);
> +	return IOMEM_ERR_PTR(-EINVAL);
>  }
>  
>  static inline
> @@ -393,7 +393,7 @@ void __iomem *devm_of_iomap(struct device *dev,
>  			    struct device_node *node, int index,
>  			    resource_size_t *size)
>  {
> -	return ERR_PTR(-EINVAL);
> +	return IOMEM_ERR_PTR(-EINVAL);
>  }
>  
>  #endif
> -- 
> 2.25.1

As the 0-day bot points out, this breaks the build all over the place,
so I'm going to drop it from my trees.  Please test-build your code with
the targets that it reported having problems with before submitting it
again.

thanks,

greg k-h