* [PATCH v4 2/2] iio: adc: add support for Nuvoton NCT7201
@ 2025-02-21 9:09 ` Eason Yang
0 siblings, 0 replies; 26+ messages in thread
From: Eason Yang @ 2025-02-21 9:09 UTC (permalink / raw)
To: avifishman70, tmaimon77, tali.perry1, venture, yuenn,
benjaminfair, jic23, lars, robh, krzk+dt, conor+dt, nuno.sa,
dlechner, javier.carrasco.cruz, andriy.shevchenko, gstols,
olivier.moysan, mitrutzceclan, tgamblin, matteomartelli3,
marcelo.schmitt, alisadariana, joao.goncalves, thomas.bonnefille,
ramona.nechita, herve.codina, chanh, KWLIU, yhyang2
Cc: linux-iio, devicetree, openbmc, linux-kernel, Eason Yang
Add Nuvoton NCT7201/NCT7202 system voltage monitor 12-bit ADC driver
NCT7201/NCT7202 supports up to 12 analog voltage monitor inputs and up to
4 SMBus addresses by ADDR pin. Meanwhile, ALERT# hardware event pins for
independent alarm signals, and the all threshold values could be set for
system protection without any timing delay. It also supports reset input
RSTIN# to recover system from a fault condition.
Currently, only single-edge mode conversion and threshold events support.
Signed-off-by: Eason Yang <j2anfernee@gmail.com>
---
MAINTAINERS | 1 +
drivers/iio/adc/Kconfig | 11 +
drivers/iio/adc/Makefile | 1 +
drivers/iio/adc/nct7201.c | 487 ++++++++++++++++++++++++++++++++++++++
4 files changed, 500 insertions(+)
create mode 100644 drivers/iio/adc/nct7201.c
diff --git a/MAINTAINERS b/MAINTAINERS
index fdc4aa5c7eff..389cbbdae1a7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2838,6 +2838,7 @@ F: arch/arm/mach-npcm/
F: arch/arm64/boot/dts/nuvoton/
F: drivers/*/*/*npcm*
F: drivers/*/*npcm*
+F: drivers/iio/adc/nct7201.c
F: drivers/rtc/rtc-nct3018y.c
F: include/dt-bindings/clock/nuvoton,npcm7xx-clock.h
F: include/dt-bindings/clock/nuvoton,npcm845-clk.h
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 849c90203071..d97eccb1c685 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -1048,6 +1048,17 @@ config NAU7802
To compile this driver as a module, choose M here: the
module will be called nau7802.
+config NCT7201
+ tristate "Nuvoton NCT7201 and NCT7202 Power Monitor"
+ depends on I2C
+ select REGMAP_I2C
+ help
+ Say yes here to build support for Nuvoton NCT7201 and NCT7202
+ Voltage Monitor.
+
+ This driver can also be built as a module. If so, the module
+ will be called nct7201.
+
config NPCM_ADC
tristate "Nuvoton NPCM ADC driver"
depends on ARCH_NPCM || COMPILE_TEST
diff --git a/drivers/iio/adc/Makefile b/drivers/iio/adc/Makefile
index ee19afba62b7..0108472e141c 100644
--- a/drivers/iio/adc/Makefile
+++ b/drivers/iio/adc/Makefile
@@ -94,6 +94,7 @@ obj-$(CONFIG_MESON_SARADC) += meson_saradc.o
obj-$(CONFIG_MP2629_ADC) += mp2629_adc.o
obj-$(CONFIG_MXS_LRADC_ADC) += mxs-lradc-adc.o
obj-$(CONFIG_NAU7802) += nau7802.o
+obj-$(CONFIG_NCT7201) += nct7201.o
obj-$(CONFIG_NPCM_ADC) += npcm_adc.o
obj-$(CONFIG_PAC1921) += pac1921.o
obj-$(CONFIG_PAC1934) += pac1934.o
diff --git a/drivers/iio/adc/nct7201.c b/drivers/iio/adc/nct7201.c
new file mode 100644
index 000000000000..c5d1540bcc00
--- /dev/null
+++ b/drivers/iio/adc/nct7201.c
@@ -0,0 +1,487 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Driver for Nuvoton nct7201 and nct7202 power monitor chips.
+ *
+ * Copyright (c) 2024-2025 Nuvoton Technology corporation.
+ */
+
+#include <linux/array_size.h>
+#include <linux/bits.h>
+#include <linux/cleanup.h>
+#include <linux/delay.h>
+#include <linux/device.h>
+#include <linux/err.h>
+#include <linux/i2c.h>
+#include <linux/init.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/regmap.h>
+#include <linux/types.h>
+#include <linux/unaligned.h>
+
+#include <linux/iio/events.h>
+#include <linux/iio/iio.h>
+
+#define NCT7201_VIN_MAX 12
+#define NCT7201_IN_SCALING 4995
+#define NCT7201_IN_SCALING_FACTOR 10000
+
+#define NCT7201_REG_INTERRUPT_STATUS_1 0x0C
+#define NCT7201_REG_INTERRUPT_STATUS_2 0x0D
+#define NCT7201_REG_VOLT_LOW_BYTE 0x0F
+#define NCT7201_REG_CONFIGURATION 0x10
+#define NCT7201_BIT_CONFIGURATION_START BIT(0)
+#define NCT7201_BIT_CONFIGURATION_ALERT_MSK BIT(1)
+#define NCT7201_BIT_CONFIGURATION_CONV_RATE BIT(2)
+#define NCT7201_BIT_CONFIGURATION_RESET BIT(7)
+
+#define NCT7201_REG_ADVANCED_CONFIGURATION 0x11
+#define NCT7201_BIT_ADVANCED_CONF_MOD_ALERT BIT(0)
+#define NCT7201_BIT_ADVANCED_CONF_MOD_STS BIT(1)
+#define NCT7201_BIT_ADVANCED_CONF_FAULT_QUEUE BIT(2)
+#define NCT7201_BIT_ADVANCED_CONF_EN_DEEP_SHUTDOWN BIT(4)
+#define NCT7201_BIT_ADVANCED_CONF_EN_SMB_TIMEOUT BIT(5)
+#define NCT7201_BIT_ADVANCED_CONF_MOD_RSTIN BIT(7)
+
+#define NCT7201_REG_CHANNEL_INPUT_MODE 0x12
+#define NCT7201_REG_CHANNEL_ENABLE_1 0x13
+#define NCT7201_REG_CHANNEL_ENABLE_1_MASK GENMASK(7, 0)
+#define NCT7201_REG_CHANNEL_ENABLE_2 0x14
+#define NCT7201_REG_CHANNEL_ENABLE_2_MASK GENMASK(3, 0)
+#define NCT7201_REG_INTERRUPT_MASK_1 0x15
+#define NCT7201_REG_INTERRUPT_MASK_2 0x16
+#define NCT7201_REG_BUSY_STATUS 0x1E
+#define NCT7201_BIT_BUSY BIT(0)
+#define NCT7201_BIT_PWR_UP BIT(1)
+#define NCT7201_REG_ONE_SHOT 0x1F
+#define NCT7201_REG_SMUS_ADDRESS 0xFC
+#define NCT7201_REG_VIN_MASK GENMASK(15, 3)
+
+#define NCT7201_REG_VIN(i) (i)
+#define NCT7201_REG_VIN_HIGH_LIMIT(i) (0x20 + (i) * 2)
+#define NCT7201_REG_VIN_LOW_LIMIT(i) (0x21 + (i) * 2)
+
+static const struct regmap_range nct7201_read_reg_range[] = {
+ regmap_reg_range(NCT7201_REG_INTERRUPT_STATUS_1, NCT7201_REG_BUSY_STATUS),
+ regmap_reg_range(NCT7201_REG_SMUS_ADDRESS, NCT7201_REG_SMUS_ADDRESS),
+};
+
+static const struct regmap_access_table nct7201_readable_regs_tbl = {
+ .yes_ranges = nct7201_read_reg_range,
+ .n_yes_ranges = ARRAY_SIZE(nct7201_read_reg_range),
+};
+
+static const struct regmap_range nct7201_write_reg_range[] = {
+ regmap_reg_range(NCT7201_REG_CONFIGURATION, NCT7201_REG_INTERRUPT_MASK_2),
+ regmap_reg_range(NCT7201_REG_ONE_SHOT, NCT7201_REG_ONE_SHOT),
+};
+
+static const struct regmap_access_table nct7201_writeable_regs_tbl = {
+ .yes_ranges = nct7201_write_reg_range,
+ .n_yes_ranges = ARRAY_SIZE(nct7201_write_reg_range),
+};
+
+static const struct regmap_range nct7201_read_vin_reg_range[] = {
+ regmap_reg_range(NCT7201_REG_VIN(0), NCT7201_REG_VIN(NCT7201_VIN_MAX - 1)),
+ regmap_reg_range(NCT7201_REG_VIN_HIGH_LIMIT(0),
+ NCT7201_REG_VIN_LOW_LIMIT(NCT7201_VIN_MAX - 1)),
+};
+
+static const struct regmap_access_table nct7201_readable_vin_regs_tbl = {
+ .yes_ranges = nct7201_read_vin_reg_range,
+ .n_yes_ranges = ARRAY_SIZE(nct7201_read_vin_reg_range),
+};
+
+static const struct regmap_range nct7201_write_vin_reg_range[] = {
+ regmap_reg_range(NCT7201_REG_VIN_HIGH_LIMIT(0),
+ NCT7201_REG_VIN_LOW_LIMIT(NCT7201_VIN_MAX - 1)),
+};
+
+static const struct regmap_access_table nct7201_writeable_vin_regs_tbl = {
+ .yes_ranges = nct7201_write_vin_reg_range,
+ .n_yes_ranges = ARRAY_SIZE(nct7201_write_vin_reg_range),
+};
+
+static const struct regmap_config nct7201_regmap8_config = {
+ .name = "vin-data-read-byte",
+ .reg_bits = 8,
+ .val_bits = 8,
+ .use_single_write = true,
+ .max_register = 0xff,
+ .rd_table = &nct7201_readable_regs_tbl,
+ .wr_table = &nct7201_writeable_regs_tbl,
+};
+
+static const struct regmap_config nct7201_regmap16_config = {
+ .name = "vin-data-read-word",
+ .reg_bits = 8,
+ .val_bits = 16,
+ .max_register = 0xff,
+ .rd_table = &nct7201_readable_vin_regs_tbl,
+ .wr_table = &nct7201_writeable_vin_regs_tbl,
+};
+
+struct nct7201_chip_info {
+ struct i2c_client *client;
+ struct mutex access_lock;
+ struct regmap *regmap;
+ struct regmap *regmap16;
+ int num_vin_channels;
+ u16 vin_mask;
+};
+
+struct nct7201_adc_model_data {
+ const char *model_name;
+ const struct iio_chan_spec *channels;
+ const int num_channels;
+ int num_vin_channels;
+};
+
+static const struct iio_event_spec nct7201_events[] = {
+ {
+ .type = IIO_EV_TYPE_THRESH,
+ .dir = IIO_EV_DIR_RISING,
+ .mask_separate = BIT(IIO_EV_INFO_VALUE) |
+ BIT(IIO_EV_INFO_ENABLE),
+ }, {
+ .type = IIO_EV_TYPE_THRESH,
+ .dir = IIO_EV_DIR_FALLING,
+ .mask_separate = BIT(IIO_EV_INFO_VALUE) |
+ BIT(IIO_EV_INFO_ENABLE),
+ },
+};
+
+#define NCT7201_VOLTAGE_CHANNEL(chan, addr) \
+ { \
+ .type = IIO_VOLTAGE, \
+ .indexed = 1, \
+ .channel = chan, \
+ .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \
+ .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), \
+ .address = addr, \
+ .event_spec = nct7201_events, \
+ .num_event_specs = ARRAY_SIZE(nct7201_events), \
+ }
+
+static const struct iio_chan_spec nct7201_channels[] = {
+ NCT7201_VOLTAGE_CHANNEL(1, 0),
+ NCT7201_VOLTAGE_CHANNEL(2, 1),
+ NCT7201_VOLTAGE_CHANNEL(3, 2),
+ NCT7201_VOLTAGE_CHANNEL(4, 3),
+ NCT7201_VOLTAGE_CHANNEL(5, 4),
+ NCT7201_VOLTAGE_CHANNEL(6, 5),
+ NCT7201_VOLTAGE_CHANNEL(7, 6),
+ NCT7201_VOLTAGE_CHANNEL(8, 7),
+};
+
+static const struct iio_chan_spec nct7202_channels[] = {
+ NCT7201_VOLTAGE_CHANNEL(1, 0),
+ NCT7201_VOLTAGE_CHANNEL(2, 1),
+ NCT7201_VOLTAGE_CHANNEL(3, 2),
+ NCT7201_VOLTAGE_CHANNEL(4, 3),
+ NCT7201_VOLTAGE_CHANNEL(5, 4),
+ NCT7201_VOLTAGE_CHANNEL(6, 5),
+ NCT7201_VOLTAGE_CHANNEL(7, 6),
+ NCT7201_VOLTAGE_CHANNEL(8, 7),
+ NCT7201_VOLTAGE_CHANNEL(9, 8),
+ NCT7201_VOLTAGE_CHANNEL(10, 9),
+ NCT7201_VOLTAGE_CHANNEL(11, 10),
+ NCT7201_VOLTAGE_CHANNEL(12, 11),
+};
+
+static int nct7201_read_raw(struct iio_dev *indio_dev,
+ struct iio_chan_spec const *chan,
+ int *val, int *val2, long mask)
+{
+ u16 volt;
+ unsigned int value;
+ int err;
+ struct nct7201_chip_info *chip = iio_priv(indio_dev);
+
+ if (chan->type != IIO_VOLTAGE)
+ return -EOPNOTSUPP;
+
+ guard(mutex)(&chip->access_lock);
+ switch (mask) {
+ case IIO_CHAN_INFO_RAW:
+ err = regmap_read(chip->regmap16, NCT7201_REG_VIN(chan->address), &value);
+ if (err < 0)
+ return err;
+ volt = value;
+ *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
+ return IIO_VAL_INT;
+ case IIO_CHAN_INFO_SCALE:
+ /* From the datasheet, we have to multiply by 0.0004995 */
+ *val = 0;
+ *val2 = 499500;
+ return IIO_VAL_INT_PLUS_NANO;
+ default:
+ return -EINVAL;
+ }
+}
+
+static int nct7201_read_event_value(struct iio_dev *indio_dev,
+ const struct iio_chan_spec *chan,
+ enum iio_event_type type,
+ enum iio_event_direction dir,
+ enum iio_event_info info,
+ int *val, int *val2)
+{
+ struct nct7201_chip_info *chip = iio_priv(indio_dev);
+ u16 volt;
+ unsigned int value;
+ int err;
+
+ if (chan->type != IIO_VOLTAGE)
+ return -EOPNOTSUPP;
+
+ if (info != IIO_EV_INFO_VALUE)
+ return -EINVAL;
+
+ if (dir == IIO_EV_DIR_FALLING) {
+ err = regmap_read(chip->regmap16, NCT7201_REG_VIN_LOW_LIMIT(chan->address),
+ &value);
+ if (err < 0)
+ return err;
+ volt = value;
+ } else {
+ err = regmap_read(chip->regmap16, NCT7201_REG_VIN_HIGH_LIMIT(chan->address),
+ &value);
+ if (err < 0)
+ return err;
+ volt = value;
+ }
+
+ *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
+
+ return IIO_VAL_INT;
+}
+
+static int nct7201_write_event_value(struct iio_dev *indio_dev,
+ const struct iio_chan_spec *chan,
+ enum iio_event_type type,
+ enum iio_event_direction dir,
+ enum iio_event_info info,
+ int val, int val2)
+{
+ struct nct7201_chip_info *chip = iio_priv(indio_dev);
+
+ if (chan->type != IIO_VOLTAGE)
+ return -EOPNOTSUPP;
+
+ if (info != IIO_EV_INFO_VALUE)
+ return -EOPNOTSUPP;
+
+ if (dir == IIO_EV_DIR_FALLING)
+ regmap_write(chip->regmap16, NCT7201_REG_VIN_LOW_LIMIT(chan->address),
+ FIELD_PREP(NCT7201_REG_VIN_MASK, val));
+ else
+ regmap_write(chip->regmap16, NCT7201_REG_VIN_HIGH_LIMIT(chan->address),
+ FIELD_PREP(NCT7201_REG_VIN_MASK, val));
+
+ return 0;
+}
+
+static int nct7201_read_event_config(struct iio_dev *indio_dev,
+ const struct iio_chan_spec *chan,
+ enum iio_event_type type,
+ enum iio_event_direction dir)
+{
+ struct nct7201_chip_info *chip = iio_priv(indio_dev);
+
+ if (chan->type != IIO_VOLTAGE)
+ return -EOPNOTSUPP;
+
+ return !!(chip->vin_mask & BIT(chan->address));
+}
+
+static int nct7201_write_event_config(struct iio_dev *indio_dev,
+ const struct iio_chan_spec *chan,
+ enum iio_event_type type,
+ enum iio_event_direction dir,
+ bool state)
+{
+ struct nct7201_chip_info *chip = iio_priv(indio_dev);
+ unsigned int mask;
+
+ if (chan->type != IIO_VOLTAGE)
+ return -EOPNOTSUPP;
+
+ mask = BIT(chan->address);
+
+ if (!state && (chip->vin_mask & mask))
+ chip->vin_mask &= ~mask;
+ else if (state && !(chip->vin_mask & mask))
+ chip->vin_mask |= mask;
+
+ if (chip->num_vin_channels <= 8)
+ regmap_write(chip->regmap, NCT7201_REG_CHANNEL_ENABLE_1, chip->vin_mask);
+ else
+ regmap_bulk_write(chip->regmap, NCT7201_REG_CHANNEL_ENABLE_1,
+ &chip->vin_mask, sizeof(chip->vin_mask));
+
+ return 0;
+}
+
+static const struct iio_info nct7201_info = {
+ .read_raw = nct7201_read_raw,
+ .read_event_config = nct7201_read_event_config,
+ .write_event_config = nct7201_write_event_config,
+ .read_event_value = nct7201_read_event_value,
+ .write_event_value = nct7201_write_event_value,
+};
+
+static const struct iio_info nct7201_info_no_irq = {
+ .read_raw = nct7201_read_raw,
+};
+
+static const struct nct7201_adc_model_data nct7201_model_data = {
+ .model_name = "nct7201",
+ .channels = nct7201_channels,
+ .num_channels = ARRAY_SIZE(nct7201_channels),
+ .num_vin_channels = 8,
+};
+
+static const struct nct7201_adc_model_data nct7202_model_data = {
+ .model_name = "nct7202",
+ .channels = nct7202_channels,
+ .num_channels = ARRAY_SIZE(nct7202_channels),
+ .num_vin_channels = 12,
+};
+
+static int nct7201_init_chip(struct nct7201_chip_info *chip)
+{
+ u8 data[2];
+ unsigned int value;
+ int err;
+
+ regmap_write(chip->regmap, NCT7201_REG_CONFIGURATION,
+ NCT7201_BIT_CONFIGURATION_RESET);
+
+ /*
+ * After about 25 msecs, the device should be ready and then
+ * the Power Up bit will be set to 1. If not, wait for it.
+ */
+ mdelay(25);
+ err = regmap_read(chip->regmap, NCT7201_REG_BUSY_STATUS, &value);
+ if (err < 0)
+ return err;
+ if (!(value & NCT7201_BIT_PWR_UP))
+ return dev_err_probe(&chip->client->dev, -EIO,
+ "Failed to power up after reset\n");
+
+ /* Enable Channel */
+ if (chip->num_vin_channels <= 8) {
+ data[0] = NCT7201_REG_CHANNEL_ENABLE_1_MASK;
+ err = regmap_write(chip->regmap, NCT7201_REG_CHANNEL_ENABLE_1, data[0]);
+ if (err < 0)
+ return dev_err_probe(&chip->client->dev, -EIO,
+ "Failed to write NCT7201_REG_CHANNEL_ENABLE_1\n");
+ } else {
+ data[0] = NCT7201_REG_CHANNEL_ENABLE_1_MASK;
+ data[1] = NCT7201_REG_CHANNEL_ENABLE_2_MASK;
+ err = regmap_bulk_write(chip->regmap, NCT7201_REG_CHANNEL_ENABLE_1,
+ data, ARRAY_SIZE(data));
+ if (err < 0)
+ return dev_err_probe(&chip->client->dev, -EIO,
+ "Failed to write NCT7201_REG_CHANNEL_ENABLE_1 and NCT7201_REG_CHANNEL_ENABLE_2\n");
+ }
+
+ value = get_unaligned_le16(data);
+ chip->vin_mask = value;
+
+ /* Start monitoring if needed */
+ err = regmap_read(chip->regmap, NCT7201_REG_CONFIGURATION, &value);
+ if (err < 0)
+ return dev_err_probe(&chip->client->dev, -EIO,
+ "Failed to read NCT7201_REG_CONFIGURATION\n");
+
+ regmap_set_bits(chip->regmap, NCT7201_REG_CONFIGURATION, NCT7201_BIT_CONFIGURATION_START);
+
+ return 0;
+}
+
+static int nct7201_probe(struct i2c_client *client)
+{
+ const struct nct7201_adc_model_data *model_data;
+ struct nct7201_chip_info *chip;
+ struct iio_dev *indio_dev;
+ int ret;
+
+ model_data = i2c_get_match_data(client);
+ if (!model_data)
+ return -EINVAL;
+
+ indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*chip));
+ if (!indio_dev)
+ return -ENOMEM;
+ chip = iio_priv(indio_dev);
+
+ chip->regmap = devm_regmap_init_i2c(client, &nct7201_regmap8_config);
+ if (IS_ERR(chip->regmap))
+ return dev_err_probe(&client->dev, PTR_ERR(chip->regmap),
+ "Failed to init regmap\n");
+
+ chip->regmap16 = devm_regmap_init_i2c(client, &nct7201_regmap16_config);
+ if (IS_ERR(chip->regmap16))
+ return dev_err_probe(&client->dev, PTR_ERR(chip->regmap16),
+ "Failed to init regmap16\n");
+
+ chip->num_vin_channels = model_data->num_vin_channels;
+
+ ret = devm_mutex_init(&client->dev, &chip->access_lock);
+ if (ret)
+ return ret;
+
+ chip->client = client;
+
+ ret = nct7201_init_chip(chip);
+ if (ret < 0)
+ return ret;
+
+ indio_dev->name = model_data->model_name;
+ indio_dev->channels = model_data->channels;
+ indio_dev->num_channels = model_data->num_channels;
+ if (client->irq)
+ indio_dev->info = &nct7201_info;
+ else
+ indio_dev->info = &nct7201_info_no_irq;
+ indio_dev->modes = INDIO_DIRECT_MODE;
+
+ return devm_iio_device_register(&client->dev, indio_dev);
+}
+
+static const struct i2c_device_id nct7201_id[] = {
+ { .name = "nct7201", .driver_data = (kernel_ulong_t)&nct7201_model_data },
+ { .name = "nct7202", .driver_data = (kernel_ulong_t)&nct7202_model_data },
+ { }
+};
+MODULE_DEVICE_TABLE(i2c, nct7201_id);
+
+static const struct of_device_id nct7201_of_match[] = {
+ {
+ .compatible = "nuvoton,nct7201",
+ .data = &nct7201_model_data,
+ },
+ {
+ .compatible = "nuvoton,nct7202",
+ .data = &nct7202_model_data,
+ },
+ { }
+};
+MODULE_DEVICE_TABLE(of, nct7201_of_match);
+
+static struct i2c_driver nct7201_driver = {
+ .driver = {
+ .name = "nct7201",
+ .of_match_table = nct7201_of_match,
+ },
+ .probe = nct7201_probe,
+ .id_table = nct7201_id,
+};
+module_i2c_driver(nct7201_driver);
+
+MODULE_AUTHOR("Eason Yang <j2anfernee@gmail.com>");
+MODULE_DESCRIPTION("Nuvoton NCT7201 voltage monitor driver");
+MODULE_LICENSE("GPL");
--
2.34.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* Re: [PATCH v4 2/2] iio: adc: add support for Nuvoton NCT7201
2025-02-21 9:09 ` Eason Yang
@ 2025-02-21 16:30 ` David Lechner
-1 siblings, 0 replies; 26+ messages in thread
From: David Lechner @ 2025-02-21 16:30 UTC (permalink / raw)
To: Eason Yang, avifishman70, tmaimon77, tali.perry1, venture, yuenn,
benjaminfair, jic23, lars, robh, krzk+dt, conor+dt, nuno.sa,
javier.carrasco.cruz, andriy.shevchenko, gstols, olivier.moysan,
mitrutzceclan, tgamblin, matteomartelli3, marcelo.schmitt,
alisadariana, joao.goncalves, thomas.bonnefille, ramona.nechita,
herve.codina, chanh, KWLIU, yhyang2
Cc: openbmc, linux-iio, devicetree, linux-kernel
On 2/21/25 3:09 AM, Eason Yang wrote:
> Add Nuvoton NCT7201/NCT7202 system voltage monitor 12-bit ADC driver
>
> NCT7201/NCT7202 supports up to 12 analog voltage monitor inputs and up to
> 4 SMBus addresses by ADDR pin. Meanwhile, ALERT# hardware event pins for
> independent alarm signals, and the all threshold values could be set for
> system protection without any timing delay. It also supports reset input
> RSTIN# to recover system from a fault condition.
>
> Currently, only single-edge mode conversion and threshold events support.
>
> Signed-off-by: Eason Yang <j2anfernee@gmail.com>
> ---
> MAINTAINERS | 1 +
> drivers/iio/adc/Kconfig | 11 +
> drivers/iio/adc/Makefile | 1 +
> drivers/iio/adc/nct7201.c | 487 ++++++++++++++++++++++++++++++++++++++
> 4 files changed, 500 insertions(+)
> create mode 100644 drivers/iio/adc/nct7201.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fdc4aa5c7eff..389cbbdae1a7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2838,6 +2838,7 @@ F: arch/arm/mach-npcm/
> F: arch/arm64/boot/dts/nuvoton/
> F: drivers/*/*/*npcm*
> F: drivers/*/*npcm*
> +F: drivers/iio/adc/nct7201.c
Same comment as DT bindings, this is ARM/NUVOTON NPCM ARCHITECTURE.
We need a new section for this chip since it is stand-alone.
> F: drivers/rtc/rtc-nct3018y.c
> F: include/dt-bindings/clock/nuvoton,npcm7xx-clock.h
> F: include/dt-bindings/clock/nuvoton,npcm845-clk.h
...
> diff --git a/drivers/iio/adc/nct7201.c b/drivers/iio/adc/nct7201.c
> new file mode 100644
> index 000000000000..c5d1540bcc00
> --- /dev/null
> +++ b/drivers/iio/adc/nct7201.c
> @@ -0,0 +1,487 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Driver for Nuvoton nct7201 and nct7202 power monitor chips.
> + *
> + * Copyright (c) 2024-2025 Nuvoton Technology corporation.
> + */
> +
> +#include <linux/array_size.h>
> +#include <linux/bits.h>
> +#include <linux/cleanup.h>
> +#include <linux/delay.h>
> +#include <linux/device.h>
> +#include <linux/err.h>
> +#include <linux/i2c.h>
> +#include <linux/init.h>
Are we really using something from the init header?
> +#include <linux/mod_devicetable.h>
> +#include <linux/module.h>
> +#include <linux/mutex.h>
> +#include <linux/regmap.h>
> +#include <linux/types.h>
> +#include <linux/unaligned.h>
> +
> +#include <linux/iio/events.h>
> +#include <linux/iio/iio.h>
> +
...
> +static int nct7201_read_raw(struct iio_dev *indio_dev,
> + struct iio_chan_spec const *chan,
> + int *val, int *val2, long mask)
> +{
> + u16 volt;
> + unsigned int value;
> + int err;
> + struct nct7201_chip_info *chip = iio_priv(indio_dev);
> +
> + if (chan->type != IIO_VOLTAGE)
> + return -EOPNOTSUPP;
> +
> + guard(mutex)(&chip->access_lock);
The regmap should already have an intneral lock, so this mutex seems
reduandnt in it's current usage.
> + switch (mask) {
> + case IIO_CHAN_INFO_RAW:
> + err = regmap_read(chip->regmap16, NCT7201_REG_VIN(chan->address), &value);
> + if (err < 0)
> + return err;
> + volt = value;
> + *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
> + return IIO_VAL_INT;
> + case IIO_CHAN_INFO_SCALE:
> + /* From the datasheet, we have to multiply by 0.0004995 */
> + *val = 0;
> + *val2 = 499500;
> + return IIO_VAL_INT_PLUS_NANO;
> + default:
> + return -EINVAL;
> + }
> +}
> +
> +static int nct7201_read_event_value(struct iio_dev *indio_dev,
> + const struct iio_chan_spec *chan,
> + enum iio_event_type type,
> + enum iio_event_direction dir,
> + enum iio_event_info info,
> + int *val, int *val2)
> +{
> + struct nct7201_chip_info *chip = iio_priv(indio_dev);
> + u16 volt;
> + unsigned int value;
> + int err;
> +
> + if (chan->type != IIO_VOLTAGE)
> + return -EOPNOTSUPP;
> +
> + if (info != IIO_EV_INFO_VALUE)
> + return -EINVAL;
> +
> + if (dir == IIO_EV_DIR_FALLING) {
> + err = regmap_read(chip->regmap16, NCT7201_REG_VIN_LOW_LIMIT(chan->address),
> + &value);
> + if (err < 0)
> + return err;
> + volt = value;
Assigning to volt seems reduant. We can just pass value to
FIELD_GET() below.
> + } else {
> + err = regmap_read(chip->regmap16, NCT7201_REG_VIN_HIGH_LIMIT(chan->address),
> + &value);
> + if (err < 0)
> + return err;
> + volt = value;
> + }
> +
> + *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
> +
> + return IIO_VAL_INT;
> +}
> +
> +static int nct7201_write_event_value(struct iio_dev *indio_dev,
> + const struct iio_chan_spec *chan,
> + enum iio_event_type type,
> + enum iio_event_direction dir,
> + enum iio_event_info info,
> + int val, int val2)
> +{
> + struct nct7201_chip_info *chip = iio_priv(indio_dev);
> +
> + if (chan->type != IIO_VOLTAGE)
> + return -EOPNOTSUPP;
> +
> + if (info != IIO_EV_INFO_VALUE)
> + return -EOPNOTSUPP;
> +
> + if (dir == IIO_EV_DIR_FALLING)
> + regmap_write(chip->regmap16, NCT7201_REG_VIN_LOW_LIMIT(chan->address),
> + FIELD_PREP(NCT7201_REG_VIN_MASK, val));
No error checking? Could just return here directly.
> + else
> + regmap_write(chip->regmap16, NCT7201_REG_VIN_HIGH_LIMIT(chan->address),
> + FIELD_PREP(NCT7201_REG_VIN_MASK, val));
> +
> + return 0;
> +}
> +
...
> +static int nct7201_write_event_config(struct iio_dev *indio_dev,
> + const struct iio_chan_spec *chan,
> + enum iio_event_type type,
> + enum iio_event_direction dir,
> + bool state)
> +{
> + struct nct7201_chip_info *chip = iio_priv(indio_dev);
> + unsigned int mask;
> +
> + if (chan->type != IIO_VOLTAGE)
> + return -EOPNOTSUPP;
> +
> + mask = BIT(chan->address);
> +
> + if (!state && (chip->vin_mask & mask))
> + chip->vin_mask &= ~mask;
> + else if (state && !(chip->vin_mask & mask))
> + chip->vin_mask |= mask;
This would be easier to read as:
if (state)
chip->vin_mask |= mask;
else
chip->vin_mask &= ~mask;
> +
> + if (chip->num_vin_channels <= 8)
> + regmap_write(chip->regmap, NCT7201_REG_CHANNEL_ENABLE_1, chip->vin_mask);
No error checking?
> + else
> + regmap_bulk_write(chip->regmap, NCT7201_REG_CHANNEL_ENABLE_1,
> + &chip->vin_mask, sizeof(chip->vin_mask));
> +
> + return 0;
> +}
> +
...
> +static int nct7201_init_chip(struct nct7201_chip_info *chip)
> +{
> + u8 data[2];
> + unsigned int value;
> + int err;
> +
> + regmap_write(chip->regmap, NCT7201_REG_CONFIGURATION,
> + NCT7201_BIT_CONFIGURATION_RESET);
Check error return?
> +
> + /*
> + * After about 25 msecs, the device should be ready and then
> + * the Power Up bit will be set to 1. If not, wait for it.
> + */
> + mdelay(25);
> + err = regmap_read(chip->regmap, NCT7201_REG_BUSY_STATUS, &value);
> + if (err < 0)
> + return err;
> + if (!(value & NCT7201_BIT_PWR_UP))
> + return dev_err_probe(&chip->client->dev, -EIO,
> + "Failed to power up after reset\n");
> +
> + /* Enable Channel */
> + if (chip->num_vin_channels <= 8) {
> + data[0] = NCT7201_REG_CHANNEL_ENABLE_1_MASK;
> + err = regmap_write(chip->regmap, NCT7201_REG_CHANNEL_ENABLE_1, data[0]);
> + if (err < 0)
> + return dev_err_probe(&chip->client->dev, -EIO,
> + "Failed to write NCT7201_REG_CHANNEL_ENABLE_1\n");
> + } else {
> + data[0] = NCT7201_REG_CHANNEL_ENABLE_1_MASK;
> + data[1] = NCT7201_REG_CHANNEL_ENABLE_2_MASK;
> + err = regmap_bulk_write(chip->regmap, NCT7201_REG_CHANNEL_ENABLE_1,
> + data, ARRAY_SIZE(data));
> + if (err < 0)
> + return dev_err_probe(&chip->client->dev, -EIO,
> + "Failed to write NCT7201_REG_CHANNEL_ENABLE_1 and NCT7201_REG_CHANNEL_ENABLE_2\n");
> + }
> +
> + value = get_unaligned_le16(data);
Does it matter that data[1] may be uninitialized and contain random value here?
> + chip->vin_mask = value;
Don't really need the intermediate value assignment here.
> +
> + /* Start monitoring if needed */
> + err = regmap_read(chip->regmap, NCT7201_REG_CONFIGURATION, &value);
> + if (err < 0)
> + return dev_err_probe(&chip->client->dev, -EIO,
> + "Failed to read NCT7201_REG_CONFIGURATION\n");
> +
> + regmap_set_bits(chip->regmap, NCT7201_REG_CONFIGURATION, NCT7201_BIT_CONFIGURATION_START);
> +
> + return 0;
> +}
> +
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PATCH v4 2/2] iio: adc: add support for Nuvoton NCT7201
@ 2025-02-21 16:30 ` David Lechner
0 siblings, 0 replies; 26+ messages in thread
From: David Lechner @ 2025-02-21 16:30 UTC (permalink / raw)
To: Eason Yang, avifishman70, tmaimon77, tali.perry1, venture, yuenn,
benjaminfair, jic23, lars, robh, krzk+dt, conor+dt, nuno.sa,
javier.carrasco.cruz, andriy.shevchenko, gstols, olivier.moysan,
mitrutzceclan, tgamblin, matteomartelli3, marcelo.schmitt,
alisadariana, joao.goncalves, thomas.bonnefille, ramona.nechita,
herve.codina, chanh, KWLIU, yhyang2
Cc: linux-iio, devicetree, openbmc, linux-kernel
On 2/21/25 3:09 AM, Eason Yang wrote:
> Add Nuvoton NCT7201/NCT7202 system voltage monitor 12-bit ADC driver
>
> NCT7201/NCT7202 supports up to 12 analog voltage monitor inputs and up to
> 4 SMBus addresses by ADDR pin. Meanwhile, ALERT# hardware event pins for
> independent alarm signals, and the all threshold values could be set for
> system protection without any timing delay. It also supports reset input
> RSTIN# to recover system from a fault condition.
>
> Currently, only single-edge mode conversion and threshold events support.
>
> Signed-off-by: Eason Yang <j2anfernee@gmail.com>
> ---
> MAINTAINERS | 1 +
> drivers/iio/adc/Kconfig | 11 +
> drivers/iio/adc/Makefile | 1 +
> drivers/iio/adc/nct7201.c | 487 ++++++++++++++++++++++++++++++++++++++
> 4 files changed, 500 insertions(+)
> create mode 100644 drivers/iio/adc/nct7201.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fdc4aa5c7eff..389cbbdae1a7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2838,6 +2838,7 @@ F: arch/arm/mach-npcm/
> F: arch/arm64/boot/dts/nuvoton/
> F: drivers/*/*/*npcm*
> F: drivers/*/*npcm*
> +F: drivers/iio/adc/nct7201.c
Same comment as DT bindings, this is ARM/NUVOTON NPCM ARCHITECTURE.
We need a new section for this chip since it is stand-alone.
> F: drivers/rtc/rtc-nct3018y.c
> F: include/dt-bindings/clock/nuvoton,npcm7xx-clock.h
> F: include/dt-bindings/clock/nuvoton,npcm845-clk.h
...
> diff --git a/drivers/iio/adc/nct7201.c b/drivers/iio/adc/nct7201.c
> new file mode 100644
> index 000000000000..c5d1540bcc00
> --- /dev/null
> +++ b/drivers/iio/adc/nct7201.c
> @@ -0,0 +1,487 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Driver for Nuvoton nct7201 and nct7202 power monitor chips.
> + *
> + * Copyright (c) 2024-2025 Nuvoton Technology corporation.
> + */
> +
> +#include <linux/array_size.h>
> +#include <linux/bits.h>
> +#include <linux/cleanup.h>
> +#include <linux/delay.h>
> +#include <linux/device.h>
> +#include <linux/err.h>
> +#include <linux/i2c.h>
> +#include <linux/init.h>
Are we really using something from the init header?
> +#include <linux/mod_devicetable.h>
> +#include <linux/module.h>
> +#include <linux/mutex.h>
> +#include <linux/regmap.h>
> +#include <linux/types.h>
> +#include <linux/unaligned.h>
> +
> +#include <linux/iio/events.h>
> +#include <linux/iio/iio.h>
> +
...
> +static int nct7201_read_raw(struct iio_dev *indio_dev,
> + struct iio_chan_spec const *chan,
> + int *val, int *val2, long mask)
> +{
> + u16 volt;
> + unsigned int value;
> + int err;
> + struct nct7201_chip_info *chip = iio_priv(indio_dev);
> +
> + if (chan->type != IIO_VOLTAGE)
> + return -EOPNOTSUPP;
> +
> + guard(mutex)(&chip->access_lock);
The regmap should already have an intneral lock, so this mutex seems
reduandnt in it's current usage.
> + switch (mask) {
> + case IIO_CHAN_INFO_RAW:
> + err = regmap_read(chip->regmap16, NCT7201_REG_VIN(chan->address), &value);
> + if (err < 0)
> + return err;
> + volt = value;
> + *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
> + return IIO_VAL_INT;
> + case IIO_CHAN_INFO_SCALE:
> + /* From the datasheet, we have to multiply by 0.0004995 */
> + *val = 0;
> + *val2 = 499500;
> + return IIO_VAL_INT_PLUS_NANO;
> + default:
> + return -EINVAL;
> + }
> +}
> +
> +static int nct7201_read_event_value(struct iio_dev *indio_dev,
> + const struct iio_chan_spec *chan,
> + enum iio_event_type type,
> + enum iio_event_direction dir,
> + enum iio_event_info info,
> + int *val, int *val2)
> +{
> + struct nct7201_chip_info *chip = iio_priv(indio_dev);
> + u16 volt;
> + unsigned int value;
> + int err;
> +
> + if (chan->type != IIO_VOLTAGE)
> + return -EOPNOTSUPP;
> +
> + if (info != IIO_EV_INFO_VALUE)
> + return -EINVAL;
> +
> + if (dir == IIO_EV_DIR_FALLING) {
> + err = regmap_read(chip->regmap16, NCT7201_REG_VIN_LOW_LIMIT(chan->address),
> + &value);
> + if (err < 0)
> + return err;
> + volt = value;
Assigning to volt seems reduant. We can just pass value to
FIELD_GET() below.
> + } else {
> + err = regmap_read(chip->regmap16, NCT7201_REG_VIN_HIGH_LIMIT(chan->address),
> + &value);
> + if (err < 0)
> + return err;
> + volt = value;
> + }
> +
> + *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
> +
> + return IIO_VAL_INT;
> +}
> +
> +static int nct7201_write_event_value(struct iio_dev *indio_dev,
> + const struct iio_chan_spec *chan,
> + enum iio_event_type type,
> + enum iio_event_direction dir,
> + enum iio_event_info info,
> + int val, int val2)
> +{
> + struct nct7201_chip_info *chip = iio_priv(indio_dev);
> +
> + if (chan->type != IIO_VOLTAGE)
> + return -EOPNOTSUPP;
> +
> + if (info != IIO_EV_INFO_VALUE)
> + return -EOPNOTSUPP;
> +
> + if (dir == IIO_EV_DIR_FALLING)
> + regmap_write(chip->regmap16, NCT7201_REG_VIN_LOW_LIMIT(chan->address),
> + FIELD_PREP(NCT7201_REG_VIN_MASK, val));
No error checking? Could just return here directly.
> + else
> + regmap_write(chip->regmap16, NCT7201_REG_VIN_HIGH_LIMIT(chan->address),
> + FIELD_PREP(NCT7201_REG_VIN_MASK, val));
> +
> + return 0;
> +}
> +
...
> +static int nct7201_write_event_config(struct iio_dev *indio_dev,
> + const struct iio_chan_spec *chan,
> + enum iio_event_type type,
> + enum iio_event_direction dir,
> + bool state)
> +{
> + struct nct7201_chip_info *chip = iio_priv(indio_dev);
> + unsigned int mask;
> +
> + if (chan->type != IIO_VOLTAGE)
> + return -EOPNOTSUPP;
> +
> + mask = BIT(chan->address);
> +
> + if (!state && (chip->vin_mask & mask))
> + chip->vin_mask &= ~mask;
> + else if (state && !(chip->vin_mask & mask))
> + chip->vin_mask |= mask;
This would be easier to read as:
if (state)
chip->vin_mask |= mask;
else
chip->vin_mask &= ~mask;
> +
> + if (chip->num_vin_channels <= 8)
> + regmap_write(chip->regmap, NCT7201_REG_CHANNEL_ENABLE_1, chip->vin_mask);
No error checking?
> + else
> + regmap_bulk_write(chip->regmap, NCT7201_REG_CHANNEL_ENABLE_1,
> + &chip->vin_mask, sizeof(chip->vin_mask));
> +
> + return 0;
> +}
> +
...
> +static int nct7201_init_chip(struct nct7201_chip_info *chip)
> +{
> + u8 data[2];
> + unsigned int value;
> + int err;
> +
> + regmap_write(chip->regmap, NCT7201_REG_CONFIGURATION,
> + NCT7201_BIT_CONFIGURATION_RESET);
Check error return?
> +
> + /*
> + * After about 25 msecs, the device should be ready and then
> + * the Power Up bit will be set to 1. If not, wait for it.
> + */
> + mdelay(25);
> + err = regmap_read(chip->regmap, NCT7201_REG_BUSY_STATUS, &value);
> + if (err < 0)
> + return err;
> + if (!(value & NCT7201_BIT_PWR_UP))
> + return dev_err_probe(&chip->client->dev, -EIO,
> + "Failed to power up after reset\n");
> +
> + /* Enable Channel */
> + if (chip->num_vin_channels <= 8) {
> + data[0] = NCT7201_REG_CHANNEL_ENABLE_1_MASK;
> + err = regmap_write(chip->regmap, NCT7201_REG_CHANNEL_ENABLE_1, data[0]);
> + if (err < 0)
> + return dev_err_probe(&chip->client->dev, -EIO,
> + "Failed to write NCT7201_REG_CHANNEL_ENABLE_1\n");
> + } else {
> + data[0] = NCT7201_REG_CHANNEL_ENABLE_1_MASK;
> + data[1] = NCT7201_REG_CHANNEL_ENABLE_2_MASK;
> + err = regmap_bulk_write(chip->regmap, NCT7201_REG_CHANNEL_ENABLE_1,
> + data, ARRAY_SIZE(data));
> + if (err < 0)
> + return dev_err_probe(&chip->client->dev, -EIO,
> + "Failed to write NCT7201_REG_CHANNEL_ENABLE_1 and NCT7201_REG_CHANNEL_ENABLE_2\n");
> + }
> +
> + value = get_unaligned_le16(data);
Does it matter that data[1] may be uninitialized and contain random value here?
> + chip->vin_mask = value;
Don't really need the intermediate value assignment here.
> +
> + /* Start monitoring if needed */
> + err = regmap_read(chip->regmap, NCT7201_REG_CONFIGURATION, &value);
> + if (err < 0)
> + return dev_err_probe(&chip->client->dev, -EIO,
> + "Failed to read NCT7201_REG_CONFIGURATION\n");
> +
> + regmap_set_bits(chip->regmap, NCT7201_REG_CONFIGURATION, NCT7201_BIT_CONFIGURATION_START);
> +
> + return 0;
> +}
> +
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v4 2/2] iio: adc: add support for Nuvoton NCT7201
2025-02-21 9:09 ` Eason Yang
@ 2025-02-22 12:48 ` kernel test robot
-1 siblings, 0 replies; 26+ messages in thread
From: kernel test robot @ 2025-02-22 12:48 UTC (permalink / raw)
To: Eason Yang, avifishman70, tmaimon77, tali.perry1, venture, yuenn,
benjaminfair, jic23, lars, robh, krzk+dt, conor+dt, nuno.sa,
dlechner, javier.carrasco.cruz, andriy.shevchenko, gstols,
olivier.moysan, mitrutzceclan, tgamblin, matteomartelli3,
marcelo.schmitt, alisadariana, joao.goncalves, thomas.bonnefille,
ramona.nechita, herve.codina, chanh, KWLIU, yhyang2
Cc: oe-kbuild-all, openbmc
Hi Eason,
kernel test robot noticed the following build errors:
[auto build test ERROR on jic23-iio/togreg]
[also build test ERROR on linus/master v6.14-rc3 next-20250221]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Eason-Yang/dt-bindings-iio-adc-add-NCT7201-ADCs/20250221-171244
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link: https://lore.kernel.org/r/20250221090918.1487689-3-j2anfernee%40gmail.com
patch subject: [PATCH v4 2/2] iio: adc: add support for Nuvoton NCT7201
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20250222/202502222047.beX8h1H7-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250222/202502222047.beX8h1H7-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502222047.beX8h1H7-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/iio/adc/nct7201.c: In function 'nct7201_read_raw':
>> drivers/iio/adc/nct7201.c:212:24: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]
212 | *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
| ^~~~~~~~~
drivers/iio/adc/nct7201.c: In function 'nct7201_write_event_value':
>> drivers/iio/adc/nct7201.c:278:30: error: implicit declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration]
278 | FIELD_PREP(NCT7201_REG_VIN_MASK, val));
| ^~~~~~~~~~
vim +/FIELD_GET +212 drivers/iio/adc/nct7201.c
192
193 static int nct7201_read_raw(struct iio_dev *indio_dev,
194 struct iio_chan_spec const *chan,
195 int *val, int *val2, long mask)
196 {
197 u16 volt;
198 unsigned int value;
199 int err;
200 struct nct7201_chip_info *chip = iio_priv(indio_dev);
201
202 if (chan->type != IIO_VOLTAGE)
203 return -EOPNOTSUPP;
204
205 guard(mutex)(&chip->access_lock);
206 switch (mask) {
207 case IIO_CHAN_INFO_RAW:
208 err = regmap_read(chip->regmap16, NCT7201_REG_VIN(chan->address), &value);
209 if (err < 0)
210 return err;
211 volt = value;
> 212 *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
213 return IIO_VAL_INT;
214 case IIO_CHAN_INFO_SCALE:
215 /* From the datasheet, we have to multiply by 0.0004995 */
216 *val = 0;
217 *val2 = 499500;
218 return IIO_VAL_INT_PLUS_NANO;
219 default:
220 return -EINVAL;
221 }
222 }
223
224 static int nct7201_read_event_value(struct iio_dev *indio_dev,
225 const struct iio_chan_spec *chan,
226 enum iio_event_type type,
227 enum iio_event_direction dir,
228 enum iio_event_info info,
229 int *val, int *val2)
230 {
231 struct nct7201_chip_info *chip = iio_priv(indio_dev);
232 u16 volt;
233 unsigned int value;
234 int err;
235
236 if (chan->type != IIO_VOLTAGE)
237 return -EOPNOTSUPP;
238
239 if (info != IIO_EV_INFO_VALUE)
240 return -EINVAL;
241
242 if (dir == IIO_EV_DIR_FALLING) {
243 err = regmap_read(chip->regmap16, NCT7201_REG_VIN_LOW_LIMIT(chan->address),
244 &value);
245 if (err < 0)
246 return err;
247 volt = value;
248 } else {
249 err = regmap_read(chip->regmap16, NCT7201_REG_VIN_HIGH_LIMIT(chan->address),
250 &value);
251 if (err < 0)
252 return err;
253 volt = value;
254 }
255
256 *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
257
258 return IIO_VAL_INT;
259 }
260
261 static int nct7201_write_event_value(struct iio_dev *indio_dev,
262 const struct iio_chan_spec *chan,
263 enum iio_event_type type,
264 enum iio_event_direction dir,
265 enum iio_event_info info,
266 int val, int val2)
267 {
268 struct nct7201_chip_info *chip = iio_priv(indio_dev);
269
270 if (chan->type != IIO_VOLTAGE)
271 return -EOPNOTSUPP;
272
273 if (info != IIO_EV_INFO_VALUE)
274 return -EOPNOTSUPP;
275
276 if (dir == IIO_EV_DIR_FALLING)
277 regmap_write(chip->regmap16, NCT7201_REG_VIN_LOW_LIMIT(chan->address),
> 278 FIELD_PREP(NCT7201_REG_VIN_MASK, val));
279 else
280 regmap_write(chip->regmap16, NCT7201_REG_VIN_HIGH_LIMIT(chan->address),
281 FIELD_PREP(NCT7201_REG_VIN_MASK, val));
282
283 return 0;
284 }
285
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PATCH v4 2/2] iio: adc: add support for Nuvoton NCT7201
@ 2025-02-22 12:48 ` kernel test robot
0 siblings, 0 replies; 26+ messages in thread
From: kernel test robot @ 2025-02-22 12:48 UTC (permalink / raw)
To: Eason Yang, avifishman70, tmaimon77, tali.perry1, venture, yuenn,
benjaminfair, jic23, lars, robh, krzk+dt, conor+dt, nuno.sa,
dlechner, javier.carrasco.cruz, andriy.shevchenko, gstols,
olivier.moysan, mitrutzceclan, tgamblin, matteomartelli3,
marcelo.schmitt, alisadariana, joao.goncalves, thomas.bonnefille,
ramona.nechita, herve.codina, chanh, KWLIU, yhyang2
Cc: openbmc, oe-kbuild-all
Hi Eason,
kernel test robot noticed the following build errors:
[auto build test ERROR on jic23-iio/togreg]
[also build test ERROR on linus/master v6.14-rc3 next-20250221]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Eason-Yang/dt-bindings-iio-adc-add-NCT7201-ADCs/20250221-171244
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link: https://lore.kernel.org/r/20250221090918.1487689-3-j2anfernee%40gmail.com
patch subject: [PATCH v4 2/2] iio: adc: add support for Nuvoton NCT7201
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20250222/202502222047.beX8h1H7-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250222/202502222047.beX8h1H7-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502222047.beX8h1H7-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/iio/adc/nct7201.c: In function 'nct7201_read_raw':
>> drivers/iio/adc/nct7201.c:212:24: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]
212 | *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
| ^~~~~~~~~
drivers/iio/adc/nct7201.c: In function 'nct7201_write_event_value':
>> drivers/iio/adc/nct7201.c:278:30: error: implicit declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration]
278 | FIELD_PREP(NCT7201_REG_VIN_MASK, val));
| ^~~~~~~~~~
vim +/FIELD_GET +212 drivers/iio/adc/nct7201.c
192
193 static int nct7201_read_raw(struct iio_dev *indio_dev,
194 struct iio_chan_spec const *chan,
195 int *val, int *val2, long mask)
196 {
197 u16 volt;
198 unsigned int value;
199 int err;
200 struct nct7201_chip_info *chip = iio_priv(indio_dev);
201
202 if (chan->type != IIO_VOLTAGE)
203 return -EOPNOTSUPP;
204
205 guard(mutex)(&chip->access_lock);
206 switch (mask) {
207 case IIO_CHAN_INFO_RAW:
208 err = regmap_read(chip->regmap16, NCT7201_REG_VIN(chan->address), &value);
209 if (err < 0)
210 return err;
211 volt = value;
> 212 *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
213 return IIO_VAL_INT;
214 case IIO_CHAN_INFO_SCALE:
215 /* From the datasheet, we have to multiply by 0.0004995 */
216 *val = 0;
217 *val2 = 499500;
218 return IIO_VAL_INT_PLUS_NANO;
219 default:
220 return -EINVAL;
221 }
222 }
223
224 static int nct7201_read_event_value(struct iio_dev *indio_dev,
225 const struct iio_chan_spec *chan,
226 enum iio_event_type type,
227 enum iio_event_direction dir,
228 enum iio_event_info info,
229 int *val, int *val2)
230 {
231 struct nct7201_chip_info *chip = iio_priv(indio_dev);
232 u16 volt;
233 unsigned int value;
234 int err;
235
236 if (chan->type != IIO_VOLTAGE)
237 return -EOPNOTSUPP;
238
239 if (info != IIO_EV_INFO_VALUE)
240 return -EINVAL;
241
242 if (dir == IIO_EV_DIR_FALLING) {
243 err = regmap_read(chip->regmap16, NCT7201_REG_VIN_LOW_LIMIT(chan->address),
244 &value);
245 if (err < 0)
246 return err;
247 volt = value;
248 } else {
249 err = regmap_read(chip->regmap16, NCT7201_REG_VIN_HIGH_LIMIT(chan->address),
250 &value);
251 if (err < 0)
252 return err;
253 volt = value;
254 }
255
256 *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
257
258 return IIO_VAL_INT;
259 }
260
261 static int nct7201_write_event_value(struct iio_dev *indio_dev,
262 const struct iio_chan_spec *chan,
263 enum iio_event_type type,
264 enum iio_event_direction dir,
265 enum iio_event_info info,
266 int val, int val2)
267 {
268 struct nct7201_chip_info *chip = iio_priv(indio_dev);
269
270 if (chan->type != IIO_VOLTAGE)
271 return -EOPNOTSUPP;
272
273 if (info != IIO_EV_INFO_VALUE)
274 return -EOPNOTSUPP;
275
276 if (dir == IIO_EV_DIR_FALLING)
277 regmap_write(chip->regmap16, NCT7201_REG_VIN_LOW_LIMIT(chan->address),
> 278 FIELD_PREP(NCT7201_REG_VIN_MASK, val));
279 else
280 regmap_write(chip->regmap16, NCT7201_REG_VIN_HIGH_LIMIT(chan->address),
281 FIELD_PREP(NCT7201_REG_VIN_MASK, val));
282
283 return 0;
284 }
285
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v4 2/2] iio: adc: add support for Nuvoton NCT7201
2025-02-21 9:09 ` Eason Yang
@ 2025-02-22 15:56 ` Jonathan Cameron
-1 siblings, 0 replies; 26+ messages in thread
From: Jonathan Cameron @ 2025-02-22 15:56 UTC (permalink / raw)
To: Eason Yang
Cc: avifishman70, tmaimon77, tali.perry1, venture, yuenn,
benjaminfair, lars, robh, krzk+dt, conor+dt, nuno.sa, dlechner,
javier.carrasco.cruz, andriy.shevchenko, gstols, olivier.moysan,
mitrutzceclan, tgamblin, matteomartelli3, marcelo.schmitt,
alisadariana, joao.goncalves, thomas.bonnefille, ramona.nechita,
herve.codina, chanh, KWLIU, yhyang2, openbmc, linux-iio,
devicetree, linux-kernel
On Fri, 21 Feb 2025 17:09:18 +0800
Eason Yang <j2anfernee@gmail.com> wrote:
> Add Nuvoton NCT7201/NCT7202 system voltage monitor 12-bit ADC driver
>
> NCT7201/NCT7202 supports up to 12 analog voltage monitor inputs and up to
> 4 SMBus addresses by ADDR pin. Meanwhile, ALERT# hardware event pins for
> independent alarm signals, and the all threshold values could be set for
> system protection without any timing delay. It also supports reset input
> RSTIN# to recover system from a fault condition.
>
> Currently, only single-edge mode conversion and threshold events support.
>
> Signed-off-by: Eason Yang <j2anfernee@gmail.com>
Hi Eason
A few comments from me. May well overlap in some places with other feedback.
Jonathan
> diff --git a/drivers/iio/adc/nct7201.c b/drivers/iio/adc/nct7201.c
> new file mode 100644
> index 000000000000..c5d1540bcc00
> --- /dev/null
> +++ b/drivers/iio/adc/nct7201.c
> @@ -0,0 +1,487 @@
> +
> +#define NCT7201_VOLTAGE_CHANNEL(chan, addr) \
> + { \
> + .type = IIO_VOLTAGE, \
> + .indexed = 1, \
> + .channel = chan, \
> + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \
> + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), \
> + .address = addr, \
> + .event_spec = nct7201_events, \
> + .num_event_specs = ARRAY_SIZE(nct7201_events), \
> + }
> +
> +static const struct iio_chan_spec nct7201_channels[] = {
> + NCT7201_VOLTAGE_CHANNEL(1, 0),
> + NCT7201_VOLTAGE_CHANNEL(2, 1),
> + NCT7201_VOLTAGE_CHANNEL(3, 2),
> + NCT7201_VOLTAGE_CHANNEL(4, 3),
> + NCT7201_VOLTAGE_CHANNEL(5, 4),
> + NCT7201_VOLTAGE_CHANNEL(6, 5),
> + NCT7201_VOLTAGE_CHANNEL(7, 6),
> + NCT7201_VOLTAGE_CHANNEL(8, 7),
> +};
> +
> +static const struct iio_chan_spec nct7202_channels[] = {
> + NCT7201_VOLTAGE_CHANNEL(1, 0),
> + NCT7201_VOLTAGE_CHANNEL(2, 1),
> + NCT7201_VOLTAGE_CHANNEL(3, 2),
> + NCT7201_VOLTAGE_CHANNEL(4, 3),
> + NCT7201_VOLTAGE_CHANNEL(5, 4),
> + NCT7201_VOLTAGE_CHANNEL(6, 5),
> + NCT7201_VOLTAGE_CHANNEL(7, 6),
> + NCT7201_VOLTAGE_CHANNEL(8, 7),
> + NCT7201_VOLTAGE_CHANNEL(9, 8),
> + NCT7201_VOLTAGE_CHANNEL(10, 9),
> + NCT7201_VOLTAGE_CHANNEL(11, 10),
> + NCT7201_VOLTAGE_CHANNEL(12, 11),
We normally number channels from 0 which would simplify this but I don't really
mind if you want to keep the offset of 1. Maybe just have one macro
parameter though and do the +1 in the macro.
> +};
> +static int nct7201_read_event_value(struct iio_dev *indio_dev,
> + const struct iio_chan_spec *chan,
> + enum iio_event_type type,
> + enum iio_event_direction dir,
> + enum iio_event_info info,
> + int *val, int *val2)
> +{
> + struct nct7201_chip_info *chip = iio_priv(indio_dev);
> + u16 volt;
> + unsigned int value;
> + int err;
> +
> + if (chan->type != IIO_VOLTAGE)
> + return -EOPNOTSUPP;
> +
> + if (info != IIO_EV_INFO_VALUE)
> + return -EINVAL;
> +
> + if (dir == IIO_EV_DIR_FALLING) {
> + err = regmap_read(chip->regmap16, NCT7201_REG_VIN_LOW_LIMIT(chan->address),
> + &value);
> + if (err < 0)
> + return err;
> + volt = value;
> + } else {
> + err = regmap_read(chip->regmap16, NCT7201_REG_VIN_HIGH_LIMIT(chan->address),
> + &value);
> + if (err < 0)
> + return err;
> + volt = value;
No real point in assigning to volt here,
> + }
> +
> + *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
> +
> + return IIO_VAL_INT;
> +}
> +
> +static int nct7201_write_event_value(struct iio_dev *indio_dev,
> + const struct iio_chan_spec *chan,
> + enum iio_event_type type,
> + enum iio_event_direction dir,
> + enum iio_event_info info,
> + int val, int val2)
> +{
> + struct nct7201_chip_info *chip = iio_priv(indio_dev);
> +
> + if (chan->type != IIO_VOLTAGE)
> + return -EOPNOTSUPP;
> +
> + if (info != IIO_EV_INFO_VALUE)
> + return -EOPNOTSUPP;
> +
> + if (dir == IIO_EV_DIR_FALLING)
> + regmap_write(chip->regmap16, NCT7201_REG_VIN_LOW_LIMIT(chan->address),
> + FIELD_PREP(NCT7201_REG_VIN_MASK, val));
> + else
> + regmap_write(chip->regmap16, NCT7201_REG_VIN_HIGH_LIMIT(chan->address),
> + FIELD_PREP(NCT7201_REG_VIN_MASK, val));
Check for error returns.
> +
> + return 0;
> +}
> +
> +static int nct7201_read_event_config(struct iio_dev *indio_dev,
> + const struct iio_chan_spec *chan,
> + enum iio_event_type type,
> + enum iio_event_direction dir)
> +{
> + struct nct7201_chip_info *chip = iio_priv(indio_dev);
> +
> + if (chan->type != IIO_VOLTAGE)
> + return -EOPNOTSUPP;
> +
> + return !!(chip->vin_mask & BIT(chan->address));
> +}
> +
> +static int nct7201_write_event_config(struct iio_dev *indio_dev,
> + const struct iio_chan_spec *chan,
> + enum iio_event_type type,
> + enum iio_event_direction dir,
> + bool state)
> +{
> + struct nct7201_chip_info *chip = iio_priv(indio_dev);
> + unsigned int mask;
> +
> + if (chan->type != IIO_VOLTAGE)
> + return -EOPNOTSUPP;
> +
> + mask = BIT(chan->address);
> +
> + if (!state && (chip->vin_mask & mask))
> + chip->vin_mask &= ~mask;
> + else if (state && !(chip->vin_mask & mask))
> + chip->vin_mask |= mask;
> +
> + if (chip->num_vin_channels <= 8)
> + regmap_write(chip->regmap, NCT7201_REG_CHANNEL_ENABLE_1, chip->vin_mask);
> + else
> + regmap_bulk_write(chip->regmap, NCT7201_REG_CHANNEL_ENABLE_1,
> + &chip->vin_mask, sizeof(chip->vin_mask));
Check errors on these writes.
> +
> + return 0;
> +}
> +static int nct7201_init_chip(struct nct7201_chip_info *chip)
> +{
> + u8 data[2];
> + unsigned int value;
> + int err;
> +
> + regmap_write(chip->regmap, NCT7201_REG_CONFIGURATION,
> + NCT7201_BIT_CONFIGURATION_RESET);
Check for errors on all accesses to the device. It can get
fiddly in paths where you are already handling an error but
that's not the case here.
> +
> + /*
> + * After about 25 msecs, the device should be ready and then
> + * the Power Up bit will be set to 1. If not, wait for it.
Wrap to 80 chars.
> + */
> + mdelay(25);
> + err = regmap_read(chip->regmap, NCT7201_REG_BUSY_STATUS, &value);
> + if (err < 0)
> + return err;
> + if (!(value & NCT7201_BIT_PWR_UP))
> + return dev_err_probe(&chip->client->dev, -EIO,
> + "Failed to power up after reset\n");
> +
> + /* Enable Channel */
> + if (chip->num_vin_channels <= 8) {
> + data[0] = NCT7201_REG_CHANNEL_ENABLE_1_MASK;
> + err = regmap_write(chip->regmap, NCT7201_REG_CHANNEL_ENABLE_1, data[0]);
> + if (err < 0)
> + return dev_err_probe(&chip->client->dev, -EIO,
> + "Failed to write NCT7201_REG_CHANNEL_ENABLE_1\n");
> + } else {
> + data[0] = NCT7201_REG_CHANNEL_ENABLE_1_MASK;
> + data[1] = NCT7201_REG_CHANNEL_ENABLE_2_MASK;
> + err = regmap_bulk_write(chip->regmap, NCT7201_REG_CHANNEL_ENABLE_1,
> + data, ARRAY_SIZE(data));
> + if (err < 0)
> + return dev_err_probe(&chip->client->dev, -EIO,
> + "Failed to write NCT7201_REG_CHANNEL_ENABLE_1 and NCT7201_REG_CHANNEL_ENABLE_2\n");
> + }
> +
> + value = get_unaligned_le16(data);
> + chip->vin_mask = value;
Local variable doesn't seem to add any benefits so just assign vin_mask directly.
> +
> + /* Start monitoring if needed */
> + err = regmap_read(chip->regmap, NCT7201_REG_CONFIGURATION, &value);
> + if (err < 0)
> + return dev_err_probe(&chip->client->dev, -EIO,
> + "Failed to read NCT7201_REG_CONFIGURATION\n");
> +
> + regmap_set_bits(chip->regmap, NCT7201_REG_CONFIGURATION, NCT7201_BIT_CONFIGURATION_START);
> +
> + return 0;
> +}
> +
> +static int nct7201_probe(struct i2c_client *client)
> +{
> + const struct nct7201_adc_model_data *model_data;
> + struct nct7201_chip_info *chip;
> + struct iio_dev *indio_dev;
> + int ret;
> +
> + model_data = i2c_get_match_data(client);
> + if (!model_data)
> + return -EINVAL;
> +
> + indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*chip));
> + if (!indio_dev)
> + return -ENOMEM;
> + chip = iio_priv(indio_dev);
> +
> + chip->regmap = devm_regmap_init_i2c(client, &nct7201_regmap8_config);
> + if (IS_ERR(chip->regmap))
> + return dev_err_probe(&client->dev, PTR_ERR(chip->regmap),
> + "Failed to init regmap\n");
Where it doesn't lead to really long lines, align all parameters to just
after the opening bracket.
> +
> + chip->regmap16 = devm_regmap_init_i2c(client, &nct7201_regmap16_config);
> + if (IS_ERR(chip->regmap16))
> + return dev_err_probe(&client->dev, PTR_ERR(chip->regmap16),
> + "Failed to init regmap16\n");
> +
> + chip->num_vin_channels = model_data->num_vin_channels;
> +
> + ret = devm_mutex_init(&client->dev, &chip->access_lock);
> + if (ret)
> + return ret;
> +
> + chip->client = client;
> +
> + ret = nct7201_init_chip(chip);
> + if (ret < 0)
> + return ret;
> +
> + indio_dev->name = model_data->model_name;
> + indio_dev->channels = model_data->channels;
> + indio_dev->num_channels = model_data->num_channels;
> + if (client->irq)
> + indio_dev->info = &nct7201_info;
> + else
> + indio_dev->info = &nct7201_info_no_irq;
> + indio_dev->modes = INDIO_DIRECT_MODE;
> +
> + return devm_iio_device_register(&client->dev, indio_dev);
> +}
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PATCH v4 2/2] iio: adc: add support for Nuvoton NCT7201
@ 2025-02-22 15:56 ` Jonathan Cameron
0 siblings, 0 replies; 26+ messages in thread
From: Jonathan Cameron @ 2025-02-22 15:56 UTC (permalink / raw)
To: Eason Yang
Cc: tgamblin, herve.codina, tmaimon77, devicetree, linux-iio,
tali.perry1, yhyang2, marcelo.schmitt, robh, lars, benjaminfair,
javier.carrasco.cruz, openbmc, ramona.nechita, matteomartelli3,
olivier.moysan, thomas.bonnefille, dlechner, KWLIU, conor+dt,
alisadariana, joao.goncalves, andriy.shevchenko, gstols, chanh,
avifishman70, venture, mitrutzceclan, linux-kernel, nuno.sa,
krzk+dt
On Fri, 21 Feb 2025 17:09:18 +0800
Eason Yang <j2anfernee@gmail.com> wrote:
> Add Nuvoton NCT7201/NCT7202 system voltage monitor 12-bit ADC driver
>
> NCT7201/NCT7202 supports up to 12 analog voltage monitor inputs and up to
> 4 SMBus addresses by ADDR pin. Meanwhile, ALERT# hardware event pins for
> independent alarm signals, and the all threshold values could be set for
> system protection without any timing delay. It also supports reset input
> RSTIN# to recover system from a fault condition.
>
> Currently, only single-edge mode conversion and threshold events support.
>
> Signed-off-by: Eason Yang <j2anfernee@gmail.com>
Hi Eason
A few comments from me. May well overlap in some places with other feedback.
Jonathan
> diff --git a/drivers/iio/adc/nct7201.c b/drivers/iio/adc/nct7201.c
> new file mode 100644
> index 000000000000..c5d1540bcc00
> --- /dev/null
> +++ b/drivers/iio/adc/nct7201.c
> @@ -0,0 +1,487 @@
> +
> +#define NCT7201_VOLTAGE_CHANNEL(chan, addr) \
> + { \
> + .type = IIO_VOLTAGE, \
> + .indexed = 1, \
> + .channel = chan, \
> + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \
> + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), \
> + .address = addr, \
> + .event_spec = nct7201_events, \
> + .num_event_specs = ARRAY_SIZE(nct7201_events), \
> + }
> +
> +static const struct iio_chan_spec nct7201_channels[] = {
> + NCT7201_VOLTAGE_CHANNEL(1, 0),
> + NCT7201_VOLTAGE_CHANNEL(2, 1),
> + NCT7201_VOLTAGE_CHANNEL(3, 2),
> + NCT7201_VOLTAGE_CHANNEL(4, 3),
> + NCT7201_VOLTAGE_CHANNEL(5, 4),
> + NCT7201_VOLTAGE_CHANNEL(6, 5),
> + NCT7201_VOLTAGE_CHANNEL(7, 6),
> + NCT7201_VOLTAGE_CHANNEL(8, 7),
> +};
> +
> +static const struct iio_chan_spec nct7202_channels[] = {
> + NCT7201_VOLTAGE_CHANNEL(1, 0),
> + NCT7201_VOLTAGE_CHANNEL(2, 1),
> + NCT7201_VOLTAGE_CHANNEL(3, 2),
> + NCT7201_VOLTAGE_CHANNEL(4, 3),
> + NCT7201_VOLTAGE_CHANNEL(5, 4),
> + NCT7201_VOLTAGE_CHANNEL(6, 5),
> + NCT7201_VOLTAGE_CHANNEL(7, 6),
> + NCT7201_VOLTAGE_CHANNEL(8, 7),
> + NCT7201_VOLTAGE_CHANNEL(9, 8),
> + NCT7201_VOLTAGE_CHANNEL(10, 9),
> + NCT7201_VOLTAGE_CHANNEL(11, 10),
> + NCT7201_VOLTAGE_CHANNEL(12, 11),
We normally number channels from 0 which would simplify this but I don't really
mind if you want to keep the offset of 1. Maybe just have one macro
parameter though and do the +1 in the macro.
> +};
> +static int nct7201_read_event_value(struct iio_dev *indio_dev,
> + const struct iio_chan_spec *chan,
> + enum iio_event_type type,
> + enum iio_event_direction dir,
> + enum iio_event_info info,
> + int *val, int *val2)
> +{
> + struct nct7201_chip_info *chip = iio_priv(indio_dev);
> + u16 volt;
> + unsigned int value;
> + int err;
> +
> + if (chan->type != IIO_VOLTAGE)
> + return -EOPNOTSUPP;
> +
> + if (info != IIO_EV_INFO_VALUE)
> + return -EINVAL;
> +
> + if (dir == IIO_EV_DIR_FALLING) {
> + err = regmap_read(chip->regmap16, NCT7201_REG_VIN_LOW_LIMIT(chan->address),
> + &value);
> + if (err < 0)
> + return err;
> + volt = value;
> + } else {
> + err = regmap_read(chip->regmap16, NCT7201_REG_VIN_HIGH_LIMIT(chan->address),
> + &value);
> + if (err < 0)
> + return err;
> + volt = value;
No real point in assigning to volt here,
> + }
> +
> + *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
> +
> + return IIO_VAL_INT;
> +}
> +
> +static int nct7201_write_event_value(struct iio_dev *indio_dev,
> + const struct iio_chan_spec *chan,
> + enum iio_event_type type,
> + enum iio_event_direction dir,
> + enum iio_event_info info,
> + int val, int val2)
> +{
> + struct nct7201_chip_info *chip = iio_priv(indio_dev);
> +
> + if (chan->type != IIO_VOLTAGE)
> + return -EOPNOTSUPP;
> +
> + if (info != IIO_EV_INFO_VALUE)
> + return -EOPNOTSUPP;
> +
> + if (dir == IIO_EV_DIR_FALLING)
> + regmap_write(chip->regmap16, NCT7201_REG_VIN_LOW_LIMIT(chan->address),
> + FIELD_PREP(NCT7201_REG_VIN_MASK, val));
> + else
> + regmap_write(chip->regmap16, NCT7201_REG_VIN_HIGH_LIMIT(chan->address),
> + FIELD_PREP(NCT7201_REG_VIN_MASK, val));
Check for error returns.
> +
> + return 0;
> +}
> +
> +static int nct7201_read_event_config(struct iio_dev *indio_dev,
> + const struct iio_chan_spec *chan,
> + enum iio_event_type type,
> + enum iio_event_direction dir)
> +{
> + struct nct7201_chip_info *chip = iio_priv(indio_dev);
> +
> + if (chan->type != IIO_VOLTAGE)
> + return -EOPNOTSUPP;
> +
> + return !!(chip->vin_mask & BIT(chan->address));
> +}
> +
> +static int nct7201_write_event_config(struct iio_dev *indio_dev,
> + const struct iio_chan_spec *chan,
> + enum iio_event_type type,
> + enum iio_event_direction dir,
> + bool state)
> +{
> + struct nct7201_chip_info *chip = iio_priv(indio_dev);
> + unsigned int mask;
> +
> + if (chan->type != IIO_VOLTAGE)
> + return -EOPNOTSUPP;
> +
> + mask = BIT(chan->address);
> +
> + if (!state && (chip->vin_mask & mask))
> + chip->vin_mask &= ~mask;
> + else if (state && !(chip->vin_mask & mask))
> + chip->vin_mask |= mask;
> +
> + if (chip->num_vin_channels <= 8)
> + regmap_write(chip->regmap, NCT7201_REG_CHANNEL_ENABLE_1, chip->vin_mask);
> + else
> + regmap_bulk_write(chip->regmap, NCT7201_REG_CHANNEL_ENABLE_1,
> + &chip->vin_mask, sizeof(chip->vin_mask));
Check errors on these writes.
> +
> + return 0;
> +}
> +static int nct7201_init_chip(struct nct7201_chip_info *chip)
> +{
> + u8 data[2];
> + unsigned int value;
> + int err;
> +
> + regmap_write(chip->regmap, NCT7201_REG_CONFIGURATION,
> + NCT7201_BIT_CONFIGURATION_RESET);
Check for errors on all accesses to the device. It can get
fiddly in paths where you are already handling an error but
that's not the case here.
> +
> + /*
> + * After about 25 msecs, the device should be ready and then
> + * the Power Up bit will be set to 1. If not, wait for it.
Wrap to 80 chars.
> + */
> + mdelay(25);
> + err = regmap_read(chip->regmap, NCT7201_REG_BUSY_STATUS, &value);
> + if (err < 0)
> + return err;
> + if (!(value & NCT7201_BIT_PWR_UP))
> + return dev_err_probe(&chip->client->dev, -EIO,
> + "Failed to power up after reset\n");
> +
> + /* Enable Channel */
> + if (chip->num_vin_channels <= 8) {
> + data[0] = NCT7201_REG_CHANNEL_ENABLE_1_MASK;
> + err = regmap_write(chip->regmap, NCT7201_REG_CHANNEL_ENABLE_1, data[0]);
> + if (err < 0)
> + return dev_err_probe(&chip->client->dev, -EIO,
> + "Failed to write NCT7201_REG_CHANNEL_ENABLE_1\n");
> + } else {
> + data[0] = NCT7201_REG_CHANNEL_ENABLE_1_MASK;
> + data[1] = NCT7201_REG_CHANNEL_ENABLE_2_MASK;
> + err = regmap_bulk_write(chip->regmap, NCT7201_REG_CHANNEL_ENABLE_1,
> + data, ARRAY_SIZE(data));
> + if (err < 0)
> + return dev_err_probe(&chip->client->dev, -EIO,
> + "Failed to write NCT7201_REG_CHANNEL_ENABLE_1 and NCT7201_REG_CHANNEL_ENABLE_2\n");
> + }
> +
> + value = get_unaligned_le16(data);
> + chip->vin_mask = value;
Local variable doesn't seem to add any benefits so just assign vin_mask directly.
> +
> + /* Start monitoring if needed */
> + err = regmap_read(chip->regmap, NCT7201_REG_CONFIGURATION, &value);
> + if (err < 0)
> + return dev_err_probe(&chip->client->dev, -EIO,
> + "Failed to read NCT7201_REG_CONFIGURATION\n");
> +
> + regmap_set_bits(chip->regmap, NCT7201_REG_CONFIGURATION, NCT7201_BIT_CONFIGURATION_START);
> +
> + return 0;
> +}
> +
> +static int nct7201_probe(struct i2c_client *client)
> +{
> + const struct nct7201_adc_model_data *model_data;
> + struct nct7201_chip_info *chip;
> + struct iio_dev *indio_dev;
> + int ret;
> +
> + model_data = i2c_get_match_data(client);
> + if (!model_data)
> + return -EINVAL;
> +
> + indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*chip));
> + if (!indio_dev)
> + return -ENOMEM;
> + chip = iio_priv(indio_dev);
> +
> + chip->regmap = devm_regmap_init_i2c(client, &nct7201_regmap8_config);
> + if (IS_ERR(chip->regmap))
> + return dev_err_probe(&client->dev, PTR_ERR(chip->regmap),
> + "Failed to init regmap\n");
Where it doesn't lead to really long lines, align all parameters to just
after the opening bracket.
> +
> + chip->regmap16 = devm_regmap_init_i2c(client, &nct7201_regmap16_config);
> + if (IS_ERR(chip->regmap16))
> + return dev_err_probe(&client->dev, PTR_ERR(chip->regmap16),
> + "Failed to init regmap16\n");
> +
> + chip->num_vin_channels = model_data->num_vin_channels;
> +
> + ret = devm_mutex_init(&client->dev, &chip->access_lock);
> + if (ret)
> + return ret;
> +
> + chip->client = client;
> +
> + ret = nct7201_init_chip(chip);
> + if (ret < 0)
> + return ret;
> +
> + indio_dev->name = model_data->model_name;
> + indio_dev->channels = model_data->channels;
> + indio_dev->num_channels = model_data->num_channels;
> + if (client->irq)
> + indio_dev->info = &nct7201_info;
> + else
> + indio_dev->info = &nct7201_info_no_irq;
> + indio_dev->modes = INDIO_DIRECT_MODE;
> +
> + return devm_iio_device_register(&client->dev, indio_dev);
> +}
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v4 2/2] iio: adc: add support for Nuvoton NCT7201
2025-02-21 9:09 ` Eason Yang
@ 2025-02-25 21:11 ` Paul Menzel
-1 siblings, 0 replies; 26+ messages in thread
From: Paul Menzel @ 2025-02-25 21:11 UTC (permalink / raw)
To: Eason Yang
Cc: avifishman70, tmaimon77, tali.perry1, venture, yuenn,
benjaminfair, jic23, lars, robh, krzk+dt, conor+dt, nuno.sa,
dlechner, javier.carrasco.cruz, andriy.shevchenko, gstols,
olivier.moysan, mitrutzceclan, tgamblin, matteomartelli3,
marcelo.schmitt, alisadariana, joao.goncalves, thomas.bonnefille,
ramona.nechita, herve.codina, chanh, kwliu, yhyang2, linux-iio,
devicetree, openbmc, linux-kernel
Dear Eason,
Thank you for your patch.
Am 21.02.25 um 10:09 schrieb Eason Yang:
> Add Nuvoton NCT7201/NCT7202 system voltage monitor 12-bit ADC driver
>
> NCT7201/NCT7202 supports up to 12 analog voltage monitor inputs and up to
> 4 SMBus addresses by ADDR pin. Meanwhile, ALERT# hardware event pins for
> independent alarm signals, and the all threshold values could be set for
… and all the threshold values …
> system protection without any timing delay. It also supports reset input
> RSTIN# to recover system from a fault condition.
>
> Currently, only single-edge mode conversion and threshold events support.
… are supported.
It’d be great if you added a datasheet name and revision, and, if
publicly available, a URL.
> Signed-off-by: Eason Yang <j2anfernee@gmail.com>
> ---
> MAINTAINERS | 1 +
> drivers/iio/adc/Kconfig | 11 +
> drivers/iio/adc/Makefile | 1 +
> drivers/iio/adc/nct7201.c | 487 ++++++++++++++++++++++++++++++++++++++
> 4 files changed, 500 insertions(+)
> create mode 100644 drivers/iio/adc/nct7201.c
[…]
Kind regards,
Paul
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v4 2/2] iio: adc: add support for Nuvoton NCT7201
@ 2025-02-25 21:11 ` Paul Menzel
0 siblings, 0 replies; 26+ messages in thread
From: Paul Menzel @ 2025-02-25 21:11 UTC (permalink / raw)
To: Eason Yang
Cc: tgamblin, herve.codina, tmaimon77, devicetree, linux-iio,
tali.perry1, yhyang2, marcelo.schmitt, robh, lars, benjaminfair,
javier.carrasco.cruz, openbmc, ramona.nechita, olivier.moysan,
thomas.bonnefille, dlechner, kwliu, conor+dt, alisadariana,
gstols, joao.goncalves, andriy.shevchenko, matteomartelli3, chanh,
avifishman70, venture, mitrutzceclan, linux-kernel, nuno.sa,
krzk+dt, jic23
Dear Eason,
Thank you for your patch.
Am 21.02.25 um 10:09 schrieb Eason Yang:
> Add Nuvoton NCT7201/NCT7202 system voltage monitor 12-bit ADC driver
>
> NCT7201/NCT7202 supports up to 12 analog voltage monitor inputs and up to
> 4 SMBus addresses by ADDR pin. Meanwhile, ALERT# hardware event pins for
> independent alarm signals, and the all threshold values could be set for
… and all the threshold values …
> system protection without any timing delay. It also supports reset input
> RSTIN# to recover system from a fault condition.
>
> Currently, only single-edge mode conversion and threshold events support.
… are supported.
It’d be great if you added a datasheet name and revision, and, if
publicly available, a URL.
> Signed-off-by: Eason Yang <j2anfernee@gmail.com>
> ---
> MAINTAINERS | 1 +
> drivers/iio/adc/Kconfig | 11 +
> drivers/iio/adc/Makefile | 1 +
> drivers/iio/adc/nct7201.c | 487 ++++++++++++++++++++++++++++++++++++++
> 4 files changed, 500 insertions(+)
> create mode 100644 drivers/iio/adc/nct7201.c
[…]
Kind regards,
Paul
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH v4 2/2] iio: adc: add support for Nuvoton NCT7201
2025-02-21 9:09 ` Eason Yang
@ 2025-03-03 17:41 ` kernel test robot
-1 siblings, 0 replies; 26+ messages in thread
From: kernel test robot @ 2025-03-03 17:41 UTC (permalink / raw)
To: Eason Yang, avifishman70, tmaimon77, tali.perry1, venture, yuenn,
benjaminfair, jic23, lars, robh, krzk+dt, conor+dt, nuno.sa,
dlechner, javier.carrasco.cruz, andriy.shevchenko, gstols,
olivier.moysan, mitrutzceclan, tgamblin, matteomartelli3,
marcelo.schmitt, alisadariana, joao.goncalves, thomas.bonnefille,
ramona.nechita, herve.codina, chanh, KWLIU, yhyang2
Cc: llvm, oe-kbuild-all, openbmc
Hi Eason,
kernel test robot noticed the following build errors:
[auto build test ERROR on jic23-iio/togreg]
[also build test ERROR on linus/master v6.14-rc5 next-20250303]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Eason-Yang/dt-bindings-iio-adc-add-NCT7201-ADCs/20250221-171244
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link: https://lore.kernel.org/r/20250221090918.1487689-3-j2anfernee%40gmail.com
patch subject: [PATCH v4 2/2] iio: adc: add support for Nuvoton NCT7201
config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20250304/202503040154.I5tA9gE9-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250304/202503040154.I5tA9gE9-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503040154.I5tA9gE9-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/iio/adc/nct7201.c:212:10: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
212 | *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
| ^
drivers/iio/adc/nct7201.c:256:9: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
256 | *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
| ^
>> drivers/iio/adc/nct7201.c:278:9: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
278 | FIELD_PREP(NCT7201_REG_VIN_MASK, val));
| ^
3 errors generated.
vim +/FIELD_GET +212 drivers/iio/adc/nct7201.c
192
193 static int nct7201_read_raw(struct iio_dev *indio_dev,
194 struct iio_chan_spec const *chan,
195 int *val, int *val2, long mask)
196 {
197 u16 volt;
198 unsigned int value;
199 int err;
200 struct nct7201_chip_info *chip = iio_priv(indio_dev);
201
202 if (chan->type != IIO_VOLTAGE)
203 return -EOPNOTSUPP;
204
205 guard(mutex)(&chip->access_lock);
206 switch (mask) {
207 case IIO_CHAN_INFO_RAW:
208 err = regmap_read(chip->regmap16, NCT7201_REG_VIN(chan->address), &value);
209 if (err < 0)
210 return err;
211 volt = value;
> 212 *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
213 return IIO_VAL_INT;
214 case IIO_CHAN_INFO_SCALE:
215 /* From the datasheet, we have to multiply by 0.0004995 */
216 *val = 0;
217 *val2 = 499500;
218 return IIO_VAL_INT_PLUS_NANO;
219 default:
220 return -EINVAL;
221 }
222 }
223
224 static int nct7201_read_event_value(struct iio_dev *indio_dev,
225 const struct iio_chan_spec *chan,
226 enum iio_event_type type,
227 enum iio_event_direction dir,
228 enum iio_event_info info,
229 int *val, int *val2)
230 {
231 struct nct7201_chip_info *chip = iio_priv(indio_dev);
232 u16 volt;
233 unsigned int value;
234 int err;
235
236 if (chan->type != IIO_VOLTAGE)
237 return -EOPNOTSUPP;
238
239 if (info != IIO_EV_INFO_VALUE)
240 return -EINVAL;
241
242 if (dir == IIO_EV_DIR_FALLING) {
243 err = regmap_read(chip->regmap16, NCT7201_REG_VIN_LOW_LIMIT(chan->address),
244 &value);
245 if (err < 0)
246 return err;
247 volt = value;
248 } else {
249 err = regmap_read(chip->regmap16, NCT7201_REG_VIN_HIGH_LIMIT(chan->address),
250 &value);
251 if (err < 0)
252 return err;
253 volt = value;
254 }
255
256 *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
257
258 return IIO_VAL_INT;
259 }
260
261 static int nct7201_write_event_value(struct iio_dev *indio_dev,
262 const struct iio_chan_spec *chan,
263 enum iio_event_type type,
264 enum iio_event_direction dir,
265 enum iio_event_info info,
266 int val, int val2)
267 {
268 struct nct7201_chip_info *chip = iio_priv(indio_dev);
269
270 if (chan->type != IIO_VOLTAGE)
271 return -EOPNOTSUPP;
272
273 if (info != IIO_EV_INFO_VALUE)
274 return -EOPNOTSUPP;
275
276 if (dir == IIO_EV_DIR_FALLING)
277 regmap_write(chip->regmap16, NCT7201_REG_VIN_LOW_LIMIT(chan->address),
> 278 FIELD_PREP(NCT7201_REG_VIN_MASK, val));
279 else
280 regmap_write(chip->regmap16, NCT7201_REG_VIN_HIGH_LIMIT(chan->address),
281 FIELD_PREP(NCT7201_REG_VIN_MASK, val));
282
283 return 0;
284 }
285
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [PATCH v4 2/2] iio: adc: add support for Nuvoton NCT7201
@ 2025-03-03 17:41 ` kernel test robot
0 siblings, 0 replies; 26+ messages in thread
From: kernel test robot @ 2025-03-03 17:41 UTC (permalink / raw)
To: Eason Yang, avifishman70, tmaimon77, tali.perry1, venture, yuenn,
benjaminfair, jic23, lars, robh, krzk+dt, conor+dt, nuno.sa,
dlechner, javier.carrasco.cruz, andriy.shevchenko, gstols,
olivier.moysan, mitrutzceclan, tgamblin, matteomartelli3,
marcelo.schmitt, alisadariana, joao.goncalves, thomas.bonnefille,
ramona.nechita, herve.codina, chanh, KWLIU, yhyang2
Cc: openbmc, llvm, oe-kbuild-all
Hi Eason,
kernel test robot noticed the following build errors:
[auto build test ERROR on jic23-iio/togreg]
[also build test ERROR on linus/master v6.14-rc5 next-20250303]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Eason-Yang/dt-bindings-iio-adc-add-NCT7201-ADCs/20250221-171244
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link: https://lore.kernel.org/r/20250221090918.1487689-3-j2anfernee%40gmail.com
patch subject: [PATCH v4 2/2] iio: adc: add support for Nuvoton NCT7201
config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20250304/202503040154.I5tA9gE9-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250304/202503040154.I5tA9gE9-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503040154.I5tA9gE9-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/iio/adc/nct7201.c:212:10: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
212 | *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
| ^
drivers/iio/adc/nct7201.c:256:9: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
256 | *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
| ^
>> drivers/iio/adc/nct7201.c:278:9: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
278 | FIELD_PREP(NCT7201_REG_VIN_MASK, val));
| ^
3 errors generated.
vim +/FIELD_GET +212 drivers/iio/adc/nct7201.c
192
193 static int nct7201_read_raw(struct iio_dev *indio_dev,
194 struct iio_chan_spec const *chan,
195 int *val, int *val2, long mask)
196 {
197 u16 volt;
198 unsigned int value;
199 int err;
200 struct nct7201_chip_info *chip = iio_priv(indio_dev);
201
202 if (chan->type != IIO_VOLTAGE)
203 return -EOPNOTSUPP;
204
205 guard(mutex)(&chip->access_lock);
206 switch (mask) {
207 case IIO_CHAN_INFO_RAW:
208 err = regmap_read(chip->regmap16, NCT7201_REG_VIN(chan->address), &value);
209 if (err < 0)
210 return err;
211 volt = value;
> 212 *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
213 return IIO_VAL_INT;
214 case IIO_CHAN_INFO_SCALE:
215 /* From the datasheet, we have to multiply by 0.0004995 */
216 *val = 0;
217 *val2 = 499500;
218 return IIO_VAL_INT_PLUS_NANO;
219 default:
220 return -EINVAL;
221 }
222 }
223
224 static int nct7201_read_event_value(struct iio_dev *indio_dev,
225 const struct iio_chan_spec *chan,
226 enum iio_event_type type,
227 enum iio_event_direction dir,
228 enum iio_event_info info,
229 int *val, int *val2)
230 {
231 struct nct7201_chip_info *chip = iio_priv(indio_dev);
232 u16 volt;
233 unsigned int value;
234 int err;
235
236 if (chan->type != IIO_VOLTAGE)
237 return -EOPNOTSUPP;
238
239 if (info != IIO_EV_INFO_VALUE)
240 return -EINVAL;
241
242 if (dir == IIO_EV_DIR_FALLING) {
243 err = regmap_read(chip->regmap16, NCT7201_REG_VIN_LOW_LIMIT(chan->address),
244 &value);
245 if (err < 0)
246 return err;
247 volt = value;
248 } else {
249 err = regmap_read(chip->regmap16, NCT7201_REG_VIN_HIGH_LIMIT(chan->address),
250 &value);
251 if (err < 0)
252 return err;
253 volt = value;
254 }
255
256 *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
257
258 return IIO_VAL_INT;
259 }
260
261 static int nct7201_write_event_value(struct iio_dev *indio_dev,
262 const struct iio_chan_spec *chan,
263 enum iio_event_type type,
264 enum iio_event_direction dir,
265 enum iio_event_info info,
266 int val, int val2)
267 {
268 struct nct7201_chip_info *chip = iio_priv(indio_dev);
269
270 if (chan->type != IIO_VOLTAGE)
271 return -EOPNOTSUPP;
272
273 if (info != IIO_EV_INFO_VALUE)
274 return -EOPNOTSUPP;
275
276 if (dir == IIO_EV_DIR_FALLING)
277 regmap_write(chip->regmap16, NCT7201_REG_VIN_LOW_LIMIT(chan->address),
> 278 FIELD_PREP(NCT7201_REG_VIN_MASK, val));
279 else
280 regmap_write(chip->regmap16, NCT7201_REG_VIN_HIGH_LIMIT(chan->address),
281 FIELD_PREP(NCT7201_REG_VIN_MASK, val));
282
283 return 0;
284 }
285
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 26+ messages in thread