All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Erdfelt <johannes@erdfelt.com>
To: Jimmy Hon <honyuenkwun@gmail.com>
Cc: Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v6 3/5] arm64: dts: rockchip: Add Orange Pi 5 Ultra board
Date: Sat, 22 Feb 2025 11:02:20 -0800	[thread overview]
Message-ID: <20250222190220.GX16911@sventech.com> (raw)
In-Reply-To: <20250222172752.6254-4-honyuenkwun@gmail.com>

On Sat, Feb 22, 2025, Jimmy Hon <honyuenkwun@gmail.com> wrote:
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-ultra.dts b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-ultra.dts
> new file mode 100644
> index 000000000000..fa975c5db0ae
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-ultra.dts
> @@ -0,0 +1,33 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/pinctrl/rockchip.h>
> +#include "rk3588-orangepi-5-compact.dtsi"
> +
> +/ {
> +	model = "Xunlong Orange Pi 5 Ultra";
> +	compatible = "xunlong,orangepi-5-ultra", "rockchip,rk3588";
> +};
> +
> +&led_blue_pwm {
> +	pwms = <&pwm4 0 25000 PWM_POLARITY_INVERTED>;
> +};
> +
> +&led_green_pwm {
> +	pwms = <&pwm5 0 25000 PWM_POLARITY_INVERTED>;
> +};
> +
> +&pinctrl {
> +
> +	usb {
> +		usb_otg_pwren: usb-otg-pwren {
> +			rockchip,pins = <4 RK_PB1 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +	};
> +};
> +
> +&vcc5v0_usb30_otg {
> +	gpios = <&gpio4 RK_PB1 GPIO_ACTIVE_HIGH>;
> +};

Error: arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-ultra.dts:58.24-25
syntax error
FATAL ERROR: Unable to parse input tree

I think you may need to include <dt-bindings/pwm/pwm.h>

JE



WARNING: multiple messages have this Message-ID (diff)
From: Johannes Erdfelt <johannes@erdfelt.com>
To: Jimmy Hon <honyuenkwun@gmail.com>
Cc: Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v6 3/5] arm64: dts: rockchip: Add Orange Pi 5 Ultra board
Date: Sat, 22 Feb 2025 11:02:20 -0800	[thread overview]
Message-ID: <20250222190220.GX16911@sventech.com> (raw)
In-Reply-To: <20250222172752.6254-4-honyuenkwun@gmail.com>

On Sat, Feb 22, 2025, Jimmy Hon <honyuenkwun@gmail.com> wrote:
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-ultra.dts b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-ultra.dts
> new file mode 100644
> index 000000000000..fa975c5db0ae
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-ultra.dts
> @@ -0,0 +1,33 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/pinctrl/rockchip.h>
> +#include "rk3588-orangepi-5-compact.dtsi"
> +
> +/ {
> +	model = "Xunlong Orange Pi 5 Ultra";
> +	compatible = "xunlong,orangepi-5-ultra", "rockchip,rk3588";
> +};
> +
> +&led_blue_pwm {
> +	pwms = <&pwm4 0 25000 PWM_POLARITY_INVERTED>;
> +};
> +
> +&led_green_pwm {
> +	pwms = <&pwm5 0 25000 PWM_POLARITY_INVERTED>;
> +};
> +
> +&pinctrl {
> +
> +	usb {
> +		usb_otg_pwren: usb-otg-pwren {
> +			rockchip,pins = <4 RK_PB1 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +	};
> +};
> +
> +&vcc5v0_usb30_otg {
> +	gpios = <&gpio4 RK_PB1 GPIO_ACTIVE_HIGH>;
> +};

Error: arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-ultra.dts:58.24-25
syntax error
FATAL ERROR: Unable to parse input tree

I think you may need to include <dt-bindings/pwm/pwm.h>

JE


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2025-02-22 19:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-22 17:27 [PATCH v6 0/5] Orange Pi 5 Ultra Jimmy Hon
2025-02-22 17:27 ` Jimmy Hon
2025-02-22 17:27 ` [PATCH v6 1/5] arm64: dts: rockchip: Differences in Orange Pi 5 Max Jimmy Hon
2025-02-22 17:27   ` Jimmy Hon
2025-02-22 17:27 ` [PATCH v6 2/5] dt-bindings: arm: rockchip: Add Xunlong Orange Pi 5 Ultra Jimmy Hon
2025-02-22 17:27   ` Jimmy Hon
2025-02-22 17:27 ` [PATCH v6 3/5] arm64: dts: rockchip: Add Orange Pi 5 Ultra board Jimmy Hon
2025-02-22 17:27   ` Jimmy Hon
2025-02-22 19:02   ` Johannes Erdfelt [this message]
2025-02-22 19:02     ` Johannes Erdfelt
2025-02-22 17:27 ` [PATCH v6 4/5] arm64: dts: rockchip: Enable HDMI1 on Orange Pi 5 Ultra Jimmy Hon
2025-02-22 17:27   ` Jimmy Hon
2025-02-22 17:27 ` [PATCH v6 5/5] arm64: dts: rockchip: Enable HDMI1 audio output for " Jimmy Hon
2025-02-22 17:27   ` Jimmy Hon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250222190220.GX16911@sventech.com \
    --to=johannes@erdfelt.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=honyuenkwun@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.