From: SeongJae Park <sj@kernel.org>
To: bus710 <bus710@gmail.com>
Cc: SeongJae Park <sj@kernel.org>, damon@lists.linux.dev
Subject: Re: [PATCH] A typo in the kconfig - sameple
Date: Mon, 24 Feb 2025 09:10:03 -0800 [thread overview]
Message-ID: <20250224171003.58091-1-sj@kernel.org> (raw)
In-Reply-To: <20250224055515.1614285-1-bus710@gmail.com>
Hi bus710,
Thank you for the fix. The change looks good to me. But, we cannot accept
patches that not having proper Signed-off-by: tag. Could you please add it and
resend?
Also, please update the subjejct to have 'samples/damon:' prefix, and add more
proper commit description.
Thanks,
SJ
On Sun, 23 Feb 2025 21:55:15 -0800 bus710 <bus710@gmail.com> wrote:
> ---
> samples/damon/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/samples/damon/Kconfig b/samples/damon/Kconfig
> index 63f6dcd71daa..564c49ed69a2 100644
> --- a/samples/damon/Kconfig
> +++ b/samples/damon/Kconfig
> @@ -3,7 +3,7 @@
> menu "DAMON Samples"
>
> config SAMPLE_DAMON_WSSE
> - bool "DAMON sameple module for working set size estimation"
> + bool "DAMON sample module for working set size estimation"
> depends on DAMON && DAMON_VADDR
> help
> This builds DAMON sample module for working set size estimation.
> @@ -15,7 +15,7 @@ config SAMPLE_DAMON_WSSE
> If unsure, say N.
>
> config SAMPLE_DAMON_PRCL
> - bool "DAMON sameple module for access-aware proactive reclamation"
> + bool "DAMON sample module for access-aware proactive reclamation"
> depends on DAMON && DAMON_VADDR
> help
> This builds DAMON sample module for access-aware proactive
> --
> 2.47.2
next prev parent reply other threads:[~2025-02-24 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 5:55 [PATCH] A typo in the kconfig - sameple bus710
2025-02-24 17:10 ` SeongJae Park [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-02-24 17:58 bus710
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250224171003.58091-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=bus710@gmail.com \
--cc=damon@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.