All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] A typo in the kconfig - sameple
@ 2025-02-24  5:55 bus710
  2025-02-24 17:10 ` SeongJae Park
  0 siblings, 1 reply; 3+ messages in thread
From: bus710 @ 2025-02-24  5:55 UTC (permalink / raw)
  To: damon; +Cc: bus710

---
 samples/damon/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/samples/damon/Kconfig b/samples/damon/Kconfig
index 63f6dcd71daa..564c49ed69a2 100644
--- a/samples/damon/Kconfig
+++ b/samples/damon/Kconfig
@@ -3,7 +3,7 @@
 menu "DAMON Samples"
 
 config SAMPLE_DAMON_WSSE
-	bool "DAMON sameple module for working set size estimation"
+	bool "DAMON sample module for working set size estimation"
 	depends on DAMON && DAMON_VADDR
 	help
 	  This builds DAMON sample module for working set size estimation.
@@ -15,7 +15,7 @@ config SAMPLE_DAMON_WSSE
 	  If unsure, say N.
 
 config SAMPLE_DAMON_PRCL
-	bool "DAMON sameple module for access-aware proactive reclamation"
+	bool "DAMON sample module for access-aware proactive reclamation"
 	depends on DAMON && DAMON_VADDR
 	help
 	  This builds DAMON sample module for access-aware proactive
-- 
2.47.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] A typo in the kconfig - sameple
  2025-02-24  5:55 [PATCH] A typo in the kconfig - sameple bus710
@ 2025-02-24 17:10 ` SeongJae Park
  0 siblings, 0 replies; 3+ messages in thread
From: SeongJae Park @ 2025-02-24 17:10 UTC (permalink / raw)
  To: bus710; +Cc: SeongJae Park, damon

Hi bus710,


Thank you for the fix.  The change looks good to me.  But, we cannot accept
patches that not having proper Signed-off-by: tag.  Could you please add it and
resend?

Also, please update the subjejct to have 'samples/damon:' prefix, and add more
proper commit description.


Thanks,
SJ

On Sun, 23 Feb 2025 21:55:15 -0800 bus710 <bus710@gmail.com> wrote:

> ---
>  samples/damon/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/samples/damon/Kconfig b/samples/damon/Kconfig
> index 63f6dcd71daa..564c49ed69a2 100644
> --- a/samples/damon/Kconfig
> +++ b/samples/damon/Kconfig
> @@ -3,7 +3,7 @@
>  menu "DAMON Samples"
>  
>  config SAMPLE_DAMON_WSSE
> -	bool "DAMON sameple module for working set size estimation"
> +	bool "DAMON sample module for working set size estimation"
>  	depends on DAMON && DAMON_VADDR
>  	help
>  	  This builds DAMON sample module for working set size estimation.
> @@ -15,7 +15,7 @@ config SAMPLE_DAMON_WSSE
>  	  If unsure, say N.
>  
>  config SAMPLE_DAMON_PRCL
> -	bool "DAMON sameple module for access-aware proactive reclamation"
> +	bool "DAMON sample module for access-aware proactive reclamation"
>  	depends on DAMON && DAMON_VADDR
>  	help
>  	  This builds DAMON sample module for access-aware proactive
> -- 
> 2.47.2

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] A typo in the kconfig - sameple
@ 2025-02-24 17:58 bus710
  0 siblings, 0 replies; 3+ messages in thread
From: bus710 @ 2025-02-24 17:58 UTC (permalink / raw)
  To: damon; +Cc: bus710

Signed-off-by: bus710 <bus710@gmail.com>
---
Hi SeongJae Park, 

I found a trivial typo in the Kconfig file of the damon sample module
while I was trying to do some experiments with sample codes.
The word "sameple" should be "sample", I believe. Please find the diff below.

Since the title should follow the format of the project, I sent a new
email to the mailing list. Sorry for the inconvenience.

Thanks for the interesting project! DAMON will be very useful for many
projects.

Thanks,


 samples/damon/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/samples/damon/Kconfig b/samples/damon/Kconfig
index 63f6dcd71daa..564c49ed69a2 100644
--- a/samples/damon/Kconfig
+++ b/samples/damon/Kconfig
@@ -3,7 +3,7 @@
 menu "DAMON Samples"
 
 config SAMPLE_DAMON_WSSE
-	bool "DAMON sameple module for working set size estimation"
+	bool "DAMON sample module for working set size estimation"
 	depends on DAMON && DAMON_VADDR
 	help
 	  This builds DAMON sample module for working set size estimation.
@@ -15,7 +15,7 @@ config SAMPLE_DAMON_WSSE
 	  If unsure, say N.
 
 config SAMPLE_DAMON_PRCL
-	bool "DAMON sameple module for access-aware proactive reclamation"
+	bool "DAMON sample module for access-aware proactive reclamation"
 	depends on DAMON && DAMON_VADDR
 	help
 	  This builds DAMON sample module for access-aware proactive
-- 
2.47.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-02-24 17:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-24  5:55 [PATCH] A typo in the kconfig - sameple bus710
2025-02-24 17:10 ` SeongJae Park
  -- strict thread matches above, loose matches on Subject: below --
2025-02-24 17:58 bus710

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.