[PATCH v1] selftests/user_events: Fix failures caused by test code

[PATCH v1] selftests/user_events: Fix failures caused by test code

[realxxyq]

From: Yiqian Xun <xunyiqian@kylinos.cn>

In parse_abi function,the dyn_test fails because the
enable_file isn’t closed after successfully registering an event.
By adding wait_for_delete(), the dyn_test now passes as expected.

Signed-off-by: Yiqian Xun <xunyiqian@kylinos.cn>
---
 tools/testing/selftests/user_events/dyn_test.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/user_events/dyn_test.c b/tools/testing/selftests/user_events/dyn_test.c
index bdf9ab127488..54c9412f8dee 100644
--- a/tools/testing/selftests/user_events/dyn_test.c
+++ b/tools/testing/selftests/user_events/dyn_test.c
@@ -127,6 +127,8 @@ static int parse_abi(int *check, const char *value)
 
 	close(fd);
 
+	wait_for_delete();
+
 	return ret;
 }
 
-- 
2.25.1

Re: [PATCH v1] selftests/user_events: Fix failures caused by test code

[Shuah Khan]

On 2/20/25 20:35, realxxyq@163.com wrote:
> From: Yiqian Xun <xunyiqian@kylinos.cn>
> 
> In parse_abi function,the dyn_test fails because the
> enable_file isn’t closed after successfully registering an event.
> By adding wait_for_delete(), the dyn_test now passes as expected.
> 
> Signed-off-by: Yiqian Xun <xunyiqian@kylinos.cn>
> ---
>   tools/testing/selftests/user_events/dyn_test.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/user_events/dyn_test.c b/tools/testing/selftests/user_events/dyn_test.c
> index bdf9ab127488..54c9412f8dee 100644
> --- a/tools/testing/selftests/user_events/dyn_test.c
> +++ b/tools/testing/selftests/user_events/dyn_test.c
> @@ -127,6 +127,8 @@ static int parse_abi(int *check, const char *value)
>   
>   	close(fd);
>   
> +	wait_for_delete();
> +
>   	return ret;
>   }
>   

Adding Steve for review.

Steve, please review the patch. If you are happy with it
give me Ack or Reviewed-by if you want to take this through
my tree.

thanks,
-- Shuah

Re: [PATCH v1] selftests/user_events: Fix failures caused by test code

[Steven Rostedt]

On Fri, 21 Feb 2025 08:46:31 -0700
Shuah Khan <skhan@linuxfoundation.org> wrote:

> On 2/20/25 20:35, realxxyq@163.com wrote:
> > From: Yiqian Xun <xunyiqian@kylinos.cn>
> > 
> > In parse_abi function,the dyn_test fails because the
> > enable_file isn’t closed after successfully registering an event.
> > By adding wait_for_delete(), the dyn_test now passes as expected.
> > 
> > Signed-off-by: Yiqian Xun <xunyiqian@kylinos.cn>
> > ---
> >   tools/testing/selftests/user_events/dyn_test.c | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/tools/testing/selftests/user_events/dyn_test.c b/tools/testing/selftests/user_events/dyn_test.c
> > index bdf9ab127488..54c9412f8dee 100644
> > --- a/tools/testing/selftests/user_events/dyn_test.c
> > +++ b/tools/testing/selftests/user_events/dyn_test.c
> > @@ -127,6 +127,8 @@ static int parse_abi(int *check, const char *value)
> >   
> >   	close(fd);
> >   
> > +	wait_for_delete();
> > +
> >   	return ret;
> >   }
> >     
> 
> Adding Steve for review.
> 
> Steve, please review the patch. If you are happy with it
> give me Ack or Reviewed-by if you want to take this through
> my tree.

Actually, Beau should review it.

Beau?

Here's the patch: https://lore.kernel.org/all/20250221033555.326716-1-realxxyq@163.com/

-- Steve

Re: [PATCH v1] selftests/user_events: Fix failures caused by test code

[Beau Belgrave]

On Fri, Feb 21, 2025 at 12:28:42PM -0500, Steven Rostedt wrote:
> On Fri, 21 Feb 2025 08:46:31 -0700
> Shuah Khan <skhan@linuxfoundation.org> wrote:
> 
> > On 2/20/25 20:35, realxxyq@163.com wrote:
> > > From: Yiqian Xun <xunyiqian@kylinos.cn>
> > > 
> > > In parse_abi function,the dyn_test fails because the
> > > enable_file isn’t closed after successfully registering an event.
> > > By adding wait_for_delete(), the dyn_test now passes as expected.
> > > 
> > > Signed-off-by: Yiqian Xun <xunyiqian@kylinos.cn>
> > > ---
> > >   tools/testing/selftests/user_events/dyn_test.c | 2 ++
> > >   1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/tools/testing/selftests/user_events/dyn_test.c b/tools/testing/selftests/user_events/dyn_test.c
> > > index bdf9ab127488..54c9412f8dee 100644
> > > --- a/tools/testing/selftests/user_events/dyn_test.c
> > > +++ b/tools/testing/selftests/user_events/dyn_test.c
> > > @@ -127,6 +127,8 @@ static int parse_abi(int *check, const char *value)
> > >   
> > >   	close(fd);
> > >   
> > > +	wait_for_delete();
> > > +
> > >   	return ret;
> > >   }
> > >     
> > 

Thank you for this fix!

> > Adding Steve for review.
> > 
> > Steve, please review the patch. If you are happy with it
> > give me Ack or Reviewed-by if you want to take this through
> > my tree.
> 
> Actually, Beau should review it.
> 
> Beau?
> 

I applied it locally and ensured it passed (seems timing related).

Acked-by: Beau Belgrave <beaub@linux.microsoft.com>

-Beau

> Here's the patch: https://lore.kernel.org/all/20250221033555.326716-1-realxxyq@163.com/
> 
> -- Steve
> 
> 

Re: [PATCH v1] selftests/user_events: Fix failures caused by test code

[Steven Rostedt]

On Mon, 24 Feb 2025 19:21:26 +0000
Beau Belgrave <beaub@linux.microsoft.com> wrote:

> > Beau?
> >   
> 
> I applied it locally and ensured it passed (seems timing related).
> 
> Acked-by: Beau Belgrave <beaub@linux.microsoft.com>

Thanks Beau,

Shuah,

Please apply this patch:

Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve

Re: [PATCH v1] selftests/user_events: Fix failures caused by test code

[Shuah Khan]

On 2/24/25 12:26, Steven Rostedt wrote:
> On Mon, 24 Feb 2025 19:21:26 +0000
> Beau Belgrave <beaub@linux.microsoft.com> wrote:
> 
>>> Beau?
>>>    
>>
>> I applied it locally and ensured it passed (seems timing related).
>>
>> Acked-by: Beau Belgrave <beaub@linux.microsoft.com>
> 
> Thanks Beau,
> 
> Shuah,
> 
> Please apply this patch:
> 
> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> 
> -- Steve

Thanks. Applied to linux-kselftest next for Linux 6.15-rc1.

thanks,
-- Shuah