From: Simon Horman <horms@kernel.org>
To: Grzegorz Nitka <grzegorz.nitka@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Karol Kolacinski <karol.kolacinski@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 2/3] ice: refactor ice_sbq_msg_dev enum
Date: Tue, 25 Feb 2025 15:08:07 +0000 [thread overview]
Message-ID: <20250225150807.GB1615191@kernel.org> (raw)
In-Reply-To: <20250221123123.2833395-3-grzegorz.nitka@intel.com>
On Fri, Feb 21, 2025 at 01:31:22PM +0100, Grzegorz Nitka wrote:
> From: Karol Kolacinski <karol.kolacinski@intel.com>
>
> Rename ice_sbq_msg_dev to ice_sbq_dev_id to reflect the meaning of this
> type more precisely. This enum type describes RDA (Remote Device Access)
> client ids, accessible over SB (Side Band) interface.
> Rename enum elements to make a driver namespace more cleaner and
> consistent with other definitions within SB
> Remove unused 'rmn_x' entries, specific to unsupported E824 device.
> Adjust clients '2' and '13' names (phy_0 and phy_0_peer respectively) to
> be compliant with EAS doc. According to the specification, regardless of
> the complex entity (single or dual), when accessing its own ports,
> they're accessed always as 'phy_0' client. And referred as 'phy_0_peer'
> when handling ports conneced to the other complex.
>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>
> Co-developed-by: Grzegorz Nitka <grzegorz.nitka@intel.com>
> Signed-off-by: Grzegorz Nitka <grzegorz.nitka@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Grzegorz Nitka <grzegorz.nitka@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Karol Kolacinski <karol.kolacinski@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH iwl-next v1 2/3] ice: refactor ice_sbq_msg_dev enum
Date: Tue, 25 Feb 2025 15:08:07 +0000 [thread overview]
Message-ID: <20250225150807.GB1615191@kernel.org> (raw)
In-Reply-To: <20250221123123.2833395-3-grzegorz.nitka@intel.com>
On Fri, Feb 21, 2025 at 01:31:22PM +0100, Grzegorz Nitka wrote:
> From: Karol Kolacinski <karol.kolacinski@intel.com>
>
> Rename ice_sbq_msg_dev to ice_sbq_dev_id to reflect the meaning of this
> type more precisely. This enum type describes RDA (Remote Device Access)
> client ids, accessible over SB (Side Band) interface.
> Rename enum elements to make a driver namespace more cleaner and
> consistent with other definitions within SB
> Remove unused 'rmn_x' entries, specific to unsupported E824 device.
> Adjust clients '2' and '13' names (phy_0 and phy_0_peer respectively) to
> be compliant with EAS doc. According to the specification, regardless of
> the complex entity (single or dual), when accessing its own ports,
> they're accessed always as 'phy_0' client. And referred as 'phy_0_peer'
> when handling ports conneced to the other complex.
>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>
> Co-developed-by: Grzegorz Nitka <grzegorz.nitka@intel.com>
> Signed-off-by: Grzegorz Nitka <grzegorz.nitka@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-02-25 15:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 12:31 [Intel-wired-lan] [PATCH iwl-next v1 0/3] E825C timesync dual NAC support Grzegorz Nitka
2025-02-21 12:31 ` Grzegorz Nitka
2025-02-21 12:31 ` [Intel-wired-lan] [PATCH iwl-next v1 1/3] ice: remove SW side band access workaround for E825 Grzegorz Nitka
2025-02-21 12:31 ` Grzegorz Nitka
2025-02-21 21:16 ` [Intel-wired-lan] " Paul Menzel
2025-03-04 13:03 ` Nitka, Grzegorz
2025-03-04 13:03 ` Nitka, Grzegorz
2025-03-10 12:36 ` Nitka, Grzegorz
2025-03-10 12:36 ` Nitka, Grzegorz
2025-03-17 16:33 ` Simon Horman
2025-02-21 12:31 ` [Intel-wired-lan] [PATCH iwl-next v1 2/3] ice: refactor ice_sbq_msg_dev enum Grzegorz Nitka
2025-02-21 12:31 ` Grzegorz Nitka
2025-02-25 15:08 ` Simon Horman [this message]
2025-02-25 15:08 ` Simon Horman
2025-02-21 12:31 ` [Intel-wired-lan] [PATCH iwl-next v1 3/3] ice: enable timesync operation on 2xNAC E825 devices Grzegorz Nitka
2025-02-21 12:31 ` Grzegorz Nitka
2025-02-25 15:04 ` [Intel-wired-lan] " Simon Horman
2025-02-25 15:04 ` Simon Horman
2025-03-04 18:10 ` [Intel-wired-lan] " Nitka, Grzegorz
2025-03-04 18:10 ` Nitka, Grzegorz
2025-02-25 15:06 ` [Intel-wired-lan] " Simon Horman
2025-02-25 15:06 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250225150807.GB1615191@kernel.org \
--to=horms@kernel.org \
--cc=grzegorz.nitka@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=karol.kolacinski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.