From: Denys Dmytriyenko <denis@denix.org>
To: Randolph Sapp <rs@ti.com>
Cc: reatmon@ti.com, meta-arago@lists.yoctoproject.org,
detheridge@ti.com, vijayp@ti.com
Subject: Re: [meta-arago][scarthgap/master][PATCH] packagegroups: opencl and vulkan utilities
Date: Thu, 27 Feb 2025 11:13:33 -0500 [thread overview]
Message-ID: <20250227161333.GJ1879@denix.org> (raw)
In-Reply-To: <D82OX8G8LTUU.307PE16JJWS5L@ti.com>
On Wed, Feb 26, 2025 at 03:20:48PM -0600, Randolph Sapp wrote:
> On Wed Feb 26, 2025 at 2:43 PM CST, Denys Dmytriyenko wrote:
> > On Wed, Feb 26, 2025 at 02:13:34PM -0600, rs@ti.com wrote:
> >> From: Randolph Sapp <rs@ti.com>
> >>
> >> Add package groups for OpenCL and Vulkan related utilities.
> >> Conditionally install them in tisdk-default-image if we enable the
> >> required distro features.
> >>
> >> Currently these package groups consist of clinfo and vulkaninfo
> >> respectively. These are useful tools for checking device extension
> >> compatibility and ICD loader functionality.
> >>
> >> Signed-off-by: Randolph Sapp <rs@ti.com>
> >> ---
> >> .../recipes-core/images/tisdk-default-image.bb | 2 ++
> >> .../packagegroups/packagegroup-arago-opencl.bb | 13 +++++++++++++
> >> .../packagegroups/packagegroup-arago-vulkan.bb | 13 +++++++++++++
> >> 3 files changed, 28 insertions(+)
> >> create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb
> >> create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb
> >>
> >> diff --git a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
> >> index aace490b..bc067857 100644
> >> --- a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
> >> +++ b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
> >> @@ -17,6 +17,8 @@ IMAGE_INSTALL += "\
> >> ti-test-extras \
> >> ${@bb.utils.contains('DISTRO_FEATURES','opengl','packagegroup-arago-tisdk-graphics','',d)} \
> >> ${@bb.utils.contains('DISTRO_FEATURES','opengl','packagegroup-arago-tisdk-gtk','',d)} \
> >> + ${@bb.utils.contains('DISTRO_FEATURES','opencl','packagegroup-arago-opencl','',d)} \
> >> + ${@bb.utils.contains('DISTRO_FEATURES','vulkan','packagegroup-arago-vulkan','',d)} \
> >> packagegroup-arago-tisdk-connectivity \
> >> packagegroup-arago-tisdk-crypto \
> >> packagegroup-arago-tisdk-multimedia \
> >> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb
> >> new file mode 100644
> >> index 00000000..49b6efc8
> >> --- /dev/null
> >> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb
> >> @@ -0,0 +1,13 @@
> >> +DESCRIPTION = "Group containing various useful 0penCL packages"
> >
> > SUMMARY is required these days.
> >
> >
> >> +LICENSE = "MIT"
>
> Verifying against oe-core I see that LICENSE is no longer being populated as
> well. Do you want me to drop that or not?
packagegroup.bbclass already weakly sets LICENSE to MIT, so unless you set a
different license, you don't need it.
> >> +PR = "r0"
> >
> > No explicit PR is needed these days.
> >
> >
> >> +PACKAGE_ARCH = "${MACHINE_ARCH}"
Also, I was wondering why you set these packagroups as machine-specific.
> >> +inherit packagegroup features_check
> >> +
> >> +REQUIRED_DISTRO_FEATURES = "opencl"
> >> +
> >> +RDEPENDS:${PN} = "\
> >> + clinfo \
> >> +"
> >> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb
> >> new file mode 100644
> >> index 00000000..36ee4b7b
> >> --- /dev/null
> >> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb
> >> @@ -0,0 +1,13 @@
> >> +DESCRIPTION = "Group containing various useful Vulkan packages"
> >> +LICENSE = "MIT"
> >> +PR = "r0"
> >
> > Same 2 comments as above.
> >
> >
> >> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> >> +
> >> +inherit packagegroup features_check
> >> +
> >> +REQUIRED_DISTRO_FEATURES = "vulkan"
> >> +
> >> +RDEPENDS:${PN} = "\
> >> + vulkan-tools \
> >> +"
> >> --
> >> 2.48.1
prev parent reply other threads:[~2025-02-27 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 20:13 [meta-arago][scarthgap/master][PATCH] packagegroups: opencl and vulkan utilities rs
2025-02-26 20:43 ` Denys Dmytriyenko
2025-02-26 21:20 ` Randolph Sapp
2025-02-27 16:13 ` Denys Dmytriyenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250227161333.GJ1879@denix.org \
--to=denis@denix.org \
--cc=detheridge@ti.com \
--cc=meta-arago@lists.yoctoproject.org \
--cc=reatmon@ti.com \
--cc=rs@ti.com \
--cc=vijayp@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.