[GIT PULL] Please pull IOMMUFD shared branch

[GIT PULL] Please pull IOMMUFD shared branch

[Jason Gunthorpe]

[-- Attachment #1: Type: text/plain, Size: 2803 bytes --]

Hi Joerg,

As discussed here is the shared branch with the three series.

Thanks,
Jason

The following changes since commit a64dcfb451e254085a7daee5fe51bf22959d52d3:

  Linux 6.14-rc2 (2025-02-09 12:45:03 -0800)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/jgg/iommufd.git tags/for-joerg

for you to fetch changes up to 5e9f822c9c683ae884fa5e71df41d1647b2876c6:

  iommu: Swap the order of setting group->pasid_array and calling attach op of iommu drivers (2025-02-28 10:07:14 -0400)

----------------------------------------------------------------
iommu shared branch with iommufd

The three dependent series on a shared branch:

- Change the iommufd fault handle into an always present hwpt handle in
  the domain

- Give iommufd its own SW_MSI implementation along with some IRQ layer
  rework

- Improvements to the handle attach API

----------------------------------------------------------------
Jason Gunthorpe (5):
      genirq/msi: Store the IOMMU IOVA directly in msi_desc instead of iommu_cookie
      genirq/msi: Refactor iommu_dma_compose_msi_msg()
      iommu: Make iommu_dma_prepare_msi() into a generic operation
      irqchip: Have CONFIG_IRQ_MSI_IOMMU be selected by irqchips that need it
      iommufd: Implement sw_msi support natively

Nicolin Chen (3):
      iommufd: Make attach_handle generic than fault specific
      iommufd/fault: Remove iommufd_fault_domain_attach/detach/replace_dev()
      iommu: Turn fault_data to iommufd private pointer

Yi Liu (4):
      iommu: Make @handle mandatory in iommu_{attach|replace}_group_handle()
      iommu: Drop iommu_group_replace_domain()
      iommu: Store either domain or handle in group->pasid_array
      iommu: Swap the order of setting group->pasid_array and calling attach op of iommu drivers

 drivers/iommu/Kconfig                   |   1 -
 drivers/iommu/dma-iommu.c               |  65 +++-----
 drivers/iommu/iommu-priv.h              |   3 -
 drivers/iommu/iommu.c                   | 164 +++++++++++++-------
 drivers/iommu/iommufd/device.c          | 266 +++++++++++++++++++++++++++++---
 drivers/iommu/iommufd/fault.c           | 130 +---------------
 drivers/iommu/iommufd/hw_pagetable.c    |   5 +-
 drivers/iommu/iommufd/iommufd_private.h |  64 ++++----
 drivers/iommu/iommufd/main.c            |   9 ++
 drivers/irqchip/Kconfig                 |   4 +
 drivers/irqchip/irq-gic-v2m.c           |   5 +-
 drivers/irqchip/irq-gic-v3-its.c        |  13 +-
 drivers/irqchip/irq-gic-v3-mbi.c        |  12 +-
 drivers/irqchip/irq-ls-scfg-msi.c       |   5 +-
 include/linux/iommu.h                   |  56 ++++---
 include/linux/msi.h                     |  55 ++++---
 kernel/irq/Kconfig                      |   1 +
 17 files changed, 501 insertions(+), 357 deletions(-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [GIT PULL] Please pull IOMMUFD shared branch

[Joerg Roedel]

On Fri, Feb 28, 2025 at 10:29:33AM -0400, Jason Gunthorpe wrote:
> Hi Joerg,
> 
> As discussed here is the shared branch with the three series.

Pulled into core branch, thanks Jason.

Re: [GIT PULL] Please pull IOMMUFD shared branch

[Robin Murphy]

On 28/02/2025 2:29 pm, Jason Gunthorpe wrote:
> Hi Joerg,
> 
> As discussed here is the shared branch with the three series.
> 
> Thanks,
> Jason
> 
> The following changes since commit a64dcfb451e254085a7daee5fe51bf22959d52d3:
> 
>    Linux 6.14-rc2 (2025-02-09 12:45:03 -0800)
> 
> are available in the Git repository at:
> 
>    git://git.kernel.org/pub/scm/linux/kernel/git/jgg/iommufd.git tags/for-joerg
> 
> for you to fetch changes up to 5e9f822c9c683ae884fa5e71df41d1647b2876c6:
> 
>    iommu: Swap the order of setting group->pasid_array and calling attach op of iommu drivers (2025-02-28 10:07:14 -0400)
> 
> ----------------------------------------------------------------
> iommu shared branch with iommufd
> 
> The three dependent series on a shared branch:
> 
> - Change the iommufd fault handle into an always present hwpt handle in
>    the domain
> 
> - Give iommufd its own SW_MSI implementation along with some IRQ layer
>    rework
> 
> - Improvements to the handle attach API
> 
> ----------------------------------------------------------------
> Jason Gunthorpe (5):
>        genirq/msi: Store the IOMMU IOVA directly in msi_desc instead of iommu_cookie
>        genirq/msi: Refactor iommu_dma_compose_msi_msg()
>        iommu: Make iommu_dma_prepare_msi() into a generic operation

So we're just merging this anyway despite it getting no review other 
than my objection to it? Oh well...

Robin.

>        irqchip: Have CONFIG_IRQ_MSI_IOMMU be selected by irqchips that need it
>        iommufd: Implement sw_msi support natively
> 
> Nicolin Chen (3):
>        iommufd: Make attach_handle generic than fault specific
>        iommufd/fault: Remove iommufd_fault_domain_attach/detach/replace_dev()
>        iommu: Turn fault_data to iommufd private pointer
> 
> Yi Liu (4):
>        iommu: Make @handle mandatory in iommu_{attach|replace}_group_handle()
>        iommu: Drop iommu_group_replace_domain()
>        iommu: Store either domain or handle in group->pasid_array
>        iommu: Swap the order of setting group->pasid_array and calling attach op of iommu drivers
> 
>   drivers/iommu/Kconfig                   |   1 -
>   drivers/iommu/dma-iommu.c               |  65 +++-----
>   drivers/iommu/iommu-priv.h              |   3 -
>   drivers/iommu/iommu.c                   | 164 +++++++++++++-------
>   drivers/iommu/iommufd/device.c          | 266 +++++++++++++++++++++++++++++---
>   drivers/iommu/iommufd/fault.c           | 130 +---------------
>   drivers/iommu/iommufd/hw_pagetable.c    |   5 +-
>   drivers/iommu/iommufd/iommufd_private.h |  64 ++++----
>   drivers/iommu/iommufd/main.c            |   9 ++
>   drivers/irqchip/Kconfig                 |   4 +
>   drivers/irqchip/irq-gic-v2m.c           |   5 +-
>   drivers/irqchip/irq-gic-v3-its.c        |  13 +-
>   drivers/irqchip/irq-gic-v3-mbi.c        |  12 +-
>   drivers/irqchip/irq-ls-scfg-msi.c       |   5 +-
>   include/linux/iommu.h                   |  56 ++++---
>   include/linux/msi.h                     |  55 ++++---
>   kernel/irq/Kconfig                      |   1 +
>   17 files changed, 501 insertions(+), 357 deletions(-)

Re: [GIT PULL] Please pull IOMMUFD shared branch

[Jason Gunthorpe]

On Fri, Feb 28, 2025 at 04:01:43PM +0000, Robin Murphy wrote:
> > Jason Gunthorpe (5):
> >        genirq/msi: Store the IOMMU IOVA directly in msi_desc instead of iommu_cookie
> >        genirq/msi: Refactor iommu_dma_compose_msi_msg()
> >        iommu: Make iommu_dma_prepare_msi() into a generic operation
> 
> So we're just merging this anyway despite it getting no review other than my
> objection to it? Oh well...

Thomas reviewed the first two patches, Joerg acked the whole
series. Nicolin reviewed the third series. It's been on the list since
Jan 10.

It was already in my tree and pushed out *before* you started making
comments.

Patch 7 that seemed to have the most problems was dropped.

We all promised to fix your style concerns in patch 3. I thought that
discussion was agreed that would be done after since we need some new
infrastructure.There are already 3 series trying to figure that out,
so I think it is likely one of them will go along with this merge
window.

People are waiting on this work. It is fixing bugs and problems that
prevent actually rolling out years of effort here.

Jason

Re: [GIT PULL] Please pull IOMMUFD shared branch

[Nicolin Chen]

On Fri, Feb 28, 2025 at 10:29:33AM -0400, Jason Gunthorpe wrote:
> The following changes since commit a64dcfb451e254085a7daee5fe51bf22959d52d3:
> 
>   Linux 6.14-rc2 (2025-02-09 12:45:03 -0800)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/jgg/iommufd.git tags/for-joerg
> 
> for you to fetch changes up to 5e9f822c9c683ae884fa5e71df41d1647b2876c6:

I see the tag "for-joerg" is pointing to a different commit that
is on v6.1-rc3. Should it be "for-next" instead?

Asking because I cannot find these commits in Joerg's "core" on
git://git.kernel.org/pub/scm/linux/kernel/git/iommu/linux.git

Or maybe it's a different "core" branch?

Thanks
Nicolin

Re: [GIT PULL] Please pull IOMMUFD shared branch

[Nicolin Chen]

On Fri, Feb 28, 2025 at 10:06:44AM -0800, Nicolin Chen wrote:
> On Fri, Feb 28, 2025 at 10:29:33AM -0400, Jason Gunthorpe wrote:
> > The following changes since commit a64dcfb451e254085a7daee5fe51bf22959d52d3:
> > 
> >   Linux 6.14-rc2 (2025-02-09 12:45:03 -0800)
> > 
> > are available in the Git repository at:
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/jgg/iommufd.git tags/for-joerg
> > 
> > for you to fetch changes up to 5e9f822c9c683ae884fa5e71df41d1647b2876c6:
> 
> I see the tag "for-joerg" is pointing to a different commit that
> is on v6.1-rc3. Should it be "for-next" instead?

Oh, please ignore this. It turned out that the tags in my git
repo wasn't updated successfully.

Thanks
Nicolin