From: Simon Horman <horms@kernel.org>
To: Martyna Szapar-Mudlaw <martyna.szapar-mudlaw@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Jan Glaza <jan.glaza@intel.com>,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
Jedrzej Jagielski <jedrzej.jagielski@intel.com>
Subject: Re: [Intel-wired-lan] [iwl-net v2 2/5] ice: stop truncating queue ids when checking
Date: Fri, 28 Feb 2025 17:18:19 +0000 [thread overview]
Message-ID: <20250228171819.GM1615191@kernel.org> (raw)
In-Reply-To: <20250225090847.513849-5-martyna.szapar-mudlaw@linux.intel.com>
On Tue, Feb 25, 2025 at 10:08:46AM +0100, Martyna Szapar-Mudlaw wrote:
> From: Jan Glaza <jan.glaza@intel.com>
>
> Queue IDs can be up to 4096, fix invalid check to stop
> truncating IDs to 8 bits.
>
> Fixes: bf93bf791cec8 ("ice: introduce ice_virtchnl.c and ice_virtchnl.h")
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> Reviewed-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
> Signed-off-by: Jan Glaza <jan.glaza@intel.com>
> Signed-off-by: Martyna Szapar-Mudlaw <martyna.szapar-mudlaw@linux.intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Martyna Szapar-Mudlaw <martyna.szapar-mudlaw@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Jan Glaza <jan.glaza@intel.com>,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
Jedrzej Jagielski <jedrzej.jagielski@intel.com>
Subject: Re: [iwl-net v2 2/5] ice: stop truncating queue ids when checking
Date: Fri, 28 Feb 2025 17:18:19 +0000 [thread overview]
Message-ID: <20250228171819.GM1615191@kernel.org> (raw)
In-Reply-To: <20250225090847.513849-5-martyna.szapar-mudlaw@linux.intel.com>
On Tue, Feb 25, 2025 at 10:08:46AM +0100, Martyna Szapar-Mudlaw wrote:
> From: Jan Glaza <jan.glaza@intel.com>
>
> Queue IDs can be up to 4096, fix invalid check to stop
> truncating IDs to 8 bits.
>
> Fixes: bf93bf791cec8 ("ice: introduce ice_virtchnl.c and ice_virtchnl.h")
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> Reviewed-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
> Signed-off-by: Jan Glaza <jan.glaza@intel.com>
> Signed-off-by: Martyna Szapar-Mudlaw <martyna.szapar-mudlaw@linux.intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-02-28 17:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 9:08 [Intel-wired-lan] [iwl-net v2 0/5] ice: fix validation issues in virtchnl parameters Martyna Szapar-Mudlaw
2025-02-25 9:08 ` Martyna Szapar-Mudlaw
2025-02-25 9:08 ` [Intel-wired-lan] [iwl-net v2 1/5] virtchnl: make proto and filter action count unsigned Martyna Szapar-Mudlaw
2025-02-25 9:08 ` Martyna Szapar-Mudlaw
2025-02-28 17:18 ` [Intel-wired-lan] " Simon Horman
2025-02-28 17:18 ` Simon Horman
2025-02-25 9:08 ` [Intel-wired-lan] [iwl-net v2 2/5] ice: stop truncating queue ids when checking Martyna Szapar-Mudlaw
2025-02-25 9:08 ` Martyna Szapar-Mudlaw
2025-02-28 17:18 ` Simon Horman [this message]
2025-02-28 17:18 ` Simon Horman
2025-02-25 9:08 ` [Intel-wired-lan] [iwl-net v2 3/5] ice: validate queue quanta parameters to prevent OOB access Martyna Szapar-Mudlaw
2025-02-25 9:08 ` Martyna Szapar-Mudlaw
2025-02-28 17:18 ` [Intel-wired-lan] " Simon Horman
2025-02-28 17:18 ` Simon Horman
2025-02-25 9:08 ` [Intel-wired-lan] [iwl-net v2 4/5] ice: fix input validation for virtchnl BW Martyna Szapar-Mudlaw
2025-02-25 9:08 ` Martyna Szapar-Mudlaw
2025-02-28 17:19 ` [Intel-wired-lan] " Simon Horman
2025-02-28 17:19 ` Simon Horman
2025-02-25 9:08 ` [Intel-wired-lan] [iwl-net v2 5/5] ice: fix using untrusted value of pkt_len in ice_vc_fdir_parse_raw() Martyna Szapar-Mudlaw
2025-02-25 9:08 ` Martyna Szapar-Mudlaw
2025-02-25 10:34 ` [Intel-wired-lan] " Przemek Kitszel
2025-02-28 17:09 ` Simon Horman
2025-02-28 17:09 ` Simon Horman
2025-03-03 16:31 ` [Intel-wired-lan] " Szapar-Mudlaw, Martyna
2025-03-03 16:31 ` Szapar-Mudlaw, Martyna
2025-02-28 17:17 ` [Intel-wired-lan] " Simon Horman
2025-02-28 17:17 ` Simon Horman
2025-03-03 10:00 ` [Intel-wired-lan] " Przemek Kitszel
2025-03-03 10:00 ` Przemek Kitszel
2025-03-03 16:32 ` [Intel-wired-lan] " Szapar-Mudlaw, Martyna
2025-03-03 16:32 ` Szapar-Mudlaw, Martyna
2025-03-05 11:18 ` [Intel-wired-lan] " Simon Horman
2025-03-05 11:18 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250228171819.GM1615191@kernel.org \
--to=horms@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jan.glaza@intel.com \
--cc=jedrzej.jagielski@intel.com \
--cc=martyna.szapar-mudlaw@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.