From: Jonathan Cameron via <qemu-arm@nongnu.org>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Igor Mammedov <imammedo@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Shiju Jose <shiju.jose@huawei.com>, <qemu-arm@nongnu.org>,
<qemu-devel@nongnu.org>, Ani Sinha <anisinha@redhat.com>,
Dongjiu Geng <gengdongjiu1@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
"Shannon Zhao" <shannon.zhaosl@gmail.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 05/19] acpi/ghes: prepare to change the way HEST offsets are calculated
Date: Fri, 28 Feb 2025 17:26:35 +0800 [thread overview]
Message-ID: <20250228172635.000027c4@huawei.com> (raw)
In-Reply-To: <ac3cc2002267e1ad848aea367ff0b08f2c4b5c69.1740671863.git.mchehab+huawei@kernel.org>
On Thu, 27 Feb 2025 17:00:43 +0100
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote:
> Add a new ags flag to change the way HEST offsets are calculated.
> Currently, offsets needed to store ACPI HEST offsets and read ack
> are calculated based on a previous knowledge from the logic
> which creates the HEST table.
>
> Such logic is not generic, not allowing to easily add more HEST
> entries nor replicates what OSPM does.
>
> As the next patches will be adding a more generic logic, add a
> new use_hest_addr, set to false, in preparation for such changes.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron via <qemu-devel@nongnu.org>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Igor Mammedov <imammedo@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Shiju Jose <shiju.jose@huawei.com>, <qemu-arm@nongnu.org>,
<qemu-devel@nongnu.org>, Ani Sinha <anisinha@redhat.com>,
Dongjiu Geng <gengdongjiu1@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
"Shannon Zhao" <shannon.zhaosl@gmail.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 05/19] acpi/ghes: prepare to change the way HEST offsets are calculated
Date: Fri, 28 Feb 2025 17:26:35 +0800 [thread overview]
Message-ID: <20250228172635.000027c4@huawei.com> (raw)
In-Reply-To: <ac3cc2002267e1ad848aea367ff0b08f2c4b5c69.1740671863.git.mchehab+huawei@kernel.org>
On Thu, 27 Feb 2025 17:00:43 +0100
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote:
> Add a new ags flag to change the way HEST offsets are calculated.
> Currently, offsets needed to store ACPI HEST offsets and read ack
> are calculated based on a previous knowledge from the logic
> which creates the HEST table.
>
> Such logic is not generic, not allowing to easily add more HEST
> entries nor replicates what OSPM does.
>
> As the next patches will be adding a more generic logic, add a
> new use_hest_addr, set to false, in preparation for such changes.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Igor Mammedov <imammedo@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Shiju Jose <shiju.jose@huawei.com>, <qemu-arm@nongnu.org>,
<qemu-devel@nongnu.org>, Ani Sinha <anisinha@redhat.com>,
Dongjiu Geng <gengdongjiu1@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
"Shannon Zhao" <shannon.zhaosl@gmail.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 05/19] acpi/ghes: prepare to change the way HEST offsets are calculated
Date: Fri, 28 Feb 2025 17:26:35 +0800 [thread overview]
Message-ID: <20250228172635.000027c4@huawei.com> (raw)
In-Reply-To: <ac3cc2002267e1ad848aea367ff0b08f2c4b5c69.1740671863.git.mchehab+huawei@kernel.org>
On Thu, 27 Feb 2025 17:00:43 +0100
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote:
> Add a new ags flag to change the way HEST offsets are calculated.
> Currently, offsets needed to store ACPI HEST offsets and read ack
> are calculated based on a previous knowledge from the logic
> which creates the HEST table.
>
> Such logic is not generic, not allowing to easily add more HEST
> entries nor replicates what OSPM does.
>
> As the next patches will be adding a more generic logic, add a
> new use_hest_addr, set to false, in preparation for such changes.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
next prev parent reply other threads:[~2025-02-28 9:27 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 16:00 [PATCH v6 00/19] Change ghes to use HEST-based offsets and add support for error inject Mauro Carvalho Chehab
2025-02-27 16:00 ` [PATCH v6 01/19] tests/acpi: virt: add an empty HEST file Mauro Carvalho Chehab
2025-02-28 9:16 ` Jonathan Cameron
2025-02-28 9:16 ` Jonathan Cameron via
2025-02-27 16:00 ` [PATCH v6 02/19] tests/qtest/bios-tables-test: extend to also check HEST table Mauro Carvalho Chehab
2025-02-28 9:17 ` Jonathan Cameron via
2025-02-28 9:17 ` Jonathan Cameron
2025-02-28 9:17 ` Jonathan Cameron via
2025-02-27 16:00 ` [PATCH v6 03/19] tests/acpi: virt: update HEST file with its current data Mauro Carvalho Chehab
2025-02-28 9:18 ` Jonathan Cameron
2025-02-28 9:18 ` Jonathan Cameron via
2025-02-27 16:00 ` [PATCH v6 04/19] acpi/ghes: Cleanup the code which gets ghes ged state Mauro Carvalho Chehab
2025-02-28 9:19 ` Jonathan Cameron
2025-02-28 9:19 ` Jonathan Cameron via
2025-02-28 9:19 ` Jonathan Cameron via
2025-02-27 16:00 ` [PATCH v6 05/19] acpi/ghes: prepare to change the way HEST offsets are calculated Mauro Carvalho Chehab
2025-02-28 9:26 ` Jonathan Cameron via [this message]
2025-02-28 9:26 ` Jonathan Cameron
2025-02-28 9:26 ` Jonathan Cameron via
2025-02-28 12:57 ` Igor Mammedov
2025-02-27 16:00 ` [PATCH v6 06/19] acpi/ghes: add a firmware file with HEST address Mauro Carvalho Chehab
2025-02-27 16:00 ` [PATCH v6 07/19] acpi/ghes: Use HEST table offsets when preparing GHES records Mauro Carvalho Chehab
2025-02-27 16:00 ` [PATCH v6 08/19] acpi/ghes: don't hard-code the number of sources for HEST table Mauro Carvalho Chehab
2025-02-27 16:00 ` [PATCH v6 09/19] acpi/ghes: add a notifier to notify when error data is ready Mauro Carvalho Chehab
2025-02-28 12:58 ` Igor Mammedov
2025-02-27 16:00 ` [PATCH v6 10/19] acpi/generic_event_device: Update GHES migration to cover hest addr Mauro Carvalho Chehab
2025-02-27 16:00 ` [PATCH v6 11/19] acpi/generic_event_device: add logic to detect if HEST addr is available Mauro Carvalho Chehab
2025-02-27 16:00 ` [PATCH v6 12/19] acpi/generic_event_device: add an APEI error device Mauro Carvalho Chehab
2025-02-27 16:00 ` [PATCH v6 13/19] tests/acpi: virt: allow acpi table changes at DSDT and HEST tables Mauro Carvalho Chehab
2025-02-28 9:28 ` Jonathan Cameron via
2025-02-28 9:28 ` Jonathan Cameron
2025-02-28 9:28 ` Jonathan Cameron via
2025-02-27 16:00 ` [PATCH v6 14/19] arm/virt: Wire up a GED error device for ACPI / GHES Mauro Carvalho Chehab
2025-02-27 16:00 ` [PATCH v6 15/19] qapi/acpi-hest: add an interface to do generic CPER error injection Mauro Carvalho Chehab
2025-02-27 16:00 ` [PATCH v6 16/19] acpi/generic_event_device.c: enable use_hest_addr for QEMU 10.x Mauro Carvalho Chehab
2025-02-28 9:29 ` Jonathan Cameron via
2025-02-28 9:29 ` Jonathan Cameron
2025-02-28 9:29 ` Jonathan Cameron via
2025-02-28 12:59 ` Igor Mammedov
2025-02-27 16:00 ` [PATCH v6 17/19] tests/acpi: virt: update HEST and DSDT tables Mauro Carvalho Chehab
2025-02-28 9:33 ` Jonathan Cameron via
2025-02-28 9:33 ` Jonathan Cameron
2025-02-28 9:33 ` Jonathan Cameron via
2025-02-28 9:44 ` Mauro Carvalho Chehab
2025-02-28 13:04 ` Igor Mammedov
2025-02-27 16:00 ` [PATCH v6 18/19] docs: hest: add new "etc/acpi_table_hest_addr" and update workflow Mauro Carvalho Chehab
2025-02-28 9:36 ` Jonathan Cameron via
2025-02-28 9:36 ` Jonathan Cameron
2025-02-28 9:36 ` Jonathan Cameron via
2025-02-28 13:08 ` Igor Mammedov
2025-02-27 16:00 ` [PATCH v6 19/19] scripts/ghes_inject: add a script to generate GHES error inject Mauro Carvalho Chehab
2025-02-27 16:43 ` [PATCH v6 00/19] Change ghes to use HEST-based offsets and add support for " Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250228172635.000027c4@huawei.com \
--to=qemu-arm@nongnu.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=anisinha@redhat.com \
--cc=gengdongjiu1@gmail.com \
--cc=imammedo@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=shiju.jose@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.