All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Tomas Glozar <tglozar@redhat.com>, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 6.6 3/4] rtla/timerlat_hist: Set OSNOISE_WORKLOAD for kernel threads
Date: Fri, 28 Feb 2025 23:20:42 -0500	[thread overview]
Message-ID: <20250228191628-f24381210ba2f0fa@stable.kernel.org> (raw)
In-Reply-To: <20250228135708.604410-4-tglozar@redhat.com>

[ Sasha's backport helper bot ]

Hi,

✅ All tests passed successfully. No issues detected.
No action required from the submitter.

The upstream commit SHA1 provided is correct: d8d866171a414ed88bd0d720864095fd75461134

Note: The patch differs from the upstream commit:
---
1:  d8d866171a414 ! 1:  2b6c95fecd276 rtla/timerlat_hist: Set OSNOISE_WORKLOAD for kernel threads
    @@ Metadata
      ## Commit message ##
         rtla/timerlat_hist: Set OSNOISE_WORKLOAD for kernel threads
     
    +    commit d8d866171a414ed88bd0d720864095fd75461134 upstream.
    +
         When using rtla timerlat with userspace threads (-u or -U), rtla
         disables the OSNOISE_WORKLOAD option in
         /sys/kernel/tracing/osnoise/options. This option is not re-enabled in a
    @@ Commit message
         Fixes: ed774f7481fa ("rtla/timerlat_hist: Add timerlat user-space support")
         Signed-off-by: Tomas Glozar <tglozar@redhat.com>
         Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
    +    [ params->kernel_workload does not exist in 6.6, use
    +    !params->user_hist ]
    +    Signed-off-by: Tomas Glozar <tglozar@redhat.com>
     
      ## tools/tracing/rtla/src/timerlat_hist.c ##
     @@ tools/tracing/rtla/src/timerlat_hist.c: timerlat_hist_apply_config(struct osnoise_tool *tool, struct timerlat_hist_param
    - 		}
    + 		auto_house_keeping(&params->monitored_cpus);
      	}
      
     -	if (params->user_hist) {
    @@ tools/tracing/rtla/src/timerlat_hist.c: timerlat_hist_apply_config(struct osnois
     +	* On kernels without support, user threads will have already failed
     +	* on missing timerlat_fd, and kernel threads do not need it.
     +	*/
    -+	retval = osnoise_set_workload(tool->context, params->kernel_workload);
    ++	retval = osnoise_set_workload(tool->context, !params->user_hist);
     +	if (retval < -1) {
     +		err_msg("Failed to set OSNOISE_WORKLOAD option\n");
     +		goto out_err;
---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.6.y        |  Success    |  Success   |

  reply	other threads:[~2025-03-01  4:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-28 13:57 [PATCH 6.6 0/4] rtla/timerlat: Fix "Set OSNOISE_WORKLOAD for kernel threads" Tomas Glozar
2025-02-28 13:57 ` [PATCH 6.6 1/4] Revert "rtla/timerlat_top: Set " Tomas Glozar
2025-03-01  4:20   ` Sasha Levin
2025-02-28 13:57 ` [PATCH 6.6 2/4] Revert "rtla/timerlat_hist: " Tomas Glozar
2025-03-01  4:20   ` Sasha Levin
2025-02-28 13:57 ` [PATCH 6.6 3/4] rtla/timerlat_hist: Set OSNOISE_WORKLOAD for kernel threads Tomas Glozar
2025-03-01  4:20   ` Sasha Levin [this message]
2025-02-28 13:57 ` [PATCH 6.6 4/4] rtla/timerlat_top: " Tomas Glozar
2025-03-01  4:20   ` Sasha Levin
2025-02-28 14:58 ` [PATCH 6.6 0/4] rtla/timerlat: Fix "Set OSNOISE_WORKLOAD for kernel threads" Steven Rostedt
2025-03-05 12:54   ` Greg Kroah-Hartman
2025-02-28 17:54 ` Jan Kundrát

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250228191628-f24381210ba2f0fa@stable.kernel.org \
    --to=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tglozar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.