From: "Jan Kundrát" <jan.kundrat@cesnet.cz>
To: Tomas Glozar <tglozar@redhat.com>
Cc: <stable@vger.kernel.org>, Steven Rostedt <rostedt@goodmis.org>,
Luis Goncalves <lgoncalv@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guillaume Morin <guillaume@morinfr.org>,
Wang Yugui <wangyugui@e16-tech.com>
Subject: Re: [PATCH 6.6 0/4] rtla/timerlat: Fix "Set OSNOISE_WORKLOAD for kernel threads"
Date: Fri, 28 Feb 2025 18:54:41 +0100 [thread overview]
Message-ID: <5add3e65-9fd1-4a84-8f7a-40b80ff42ae3@cesnet.cz> (raw)
In-Reply-To: <20250228135708.604410-1-tglozar@redhat.com>
On pátek 28. února 2025 14:57:04 CET, Tomas Glozar wrote:
> Two rtla commits that fix a bug in setting OSNOISE_WORKLOAD (see
> the patches for details) were improperly backported to 6.6-stable,
> referencing non-existent field params->kernel_workload.
>
> Revert the broken backports and backport this properly, using
> !params->user_hist and !params->user_top instead of the non-existent
> params->user_workload.
>
> The patchset was tested to build and fix the bug.
>
> Tomas Glozar (4):
> Revert "rtla/timerlat_top: Set OSNOISE_WORKLOAD for kernel threads"
> Revert "rtla/timerlat_hist: Set OSNOISE_WORKLOAD for kernel threads"
> rtla/timerlat_hist: Set OSNOISE_WORKLOAD for kernel threads
> rtla/timerlat_top: Set OSNOISE_WORKLOAD for kernel threads
>
> tools/tracing/rtla/src/timerlat_hist.c | 2 +-
> tools/tracing/rtla/src/timerlat_top.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
Thanks for a quick fix, it now builds again and the tool appears to work.
Tested-by: Jan Kundrát <jan.kundrat@cesnet.cz>
With kind regards,
Jan
prev parent reply other threads:[~2025-02-28 17:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 13:57 [PATCH 6.6 0/4] rtla/timerlat: Fix "Set OSNOISE_WORKLOAD for kernel threads" Tomas Glozar
2025-02-28 13:57 ` [PATCH 6.6 1/4] Revert "rtla/timerlat_top: Set " Tomas Glozar
2025-03-01 4:20 ` Sasha Levin
2025-02-28 13:57 ` [PATCH 6.6 2/4] Revert "rtla/timerlat_hist: " Tomas Glozar
2025-03-01 4:20 ` Sasha Levin
2025-02-28 13:57 ` [PATCH 6.6 3/4] rtla/timerlat_hist: Set OSNOISE_WORKLOAD for kernel threads Tomas Glozar
2025-03-01 4:20 ` Sasha Levin
2025-02-28 13:57 ` [PATCH 6.6 4/4] rtla/timerlat_top: " Tomas Glozar
2025-03-01 4:20 ` Sasha Levin
2025-02-28 14:58 ` [PATCH 6.6 0/4] rtla/timerlat: Fix "Set OSNOISE_WORKLOAD for kernel threads" Steven Rostedt
2025-03-05 12:54 ` Greg Kroah-Hartman
2025-02-28 17:54 ` Jan Kundrát [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5add3e65-9fd1-4a84-8f7a-40b80ff42ae3@cesnet.cz \
--to=jan.kundrat@cesnet.cz \
--cc=gregkh@linuxfoundation.org \
--cc=guillaume@morinfr.org \
--cc=lgoncalv@redhat.com \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=tglozar@redhat.com \
--cc=wangyugui@e16-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.