[PATCH] kern: Unbreak support for nested partitions

[PATCH] kern: Unbreak support for nested partitions

[Vladimir Serbinenko]

When using syntax hd0,gtp3,dfly1 then ptr points to trailing part ",dfly1"
so it's improper to consider it invalid partition

Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>
---
 grub-core/kern/partition.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/grub-core/kern/partition.c b/grub-core/kern/partition.c
index c6a578cf4..3b128e6d2 100644
--- a/grub-core/kern/partition.c
+++ b/grub-core/kern/partition.c
@@ -134,7 +134,7 @@ grub_partition_probe (struct grub_disk *disk, const char *str)
       partname_end = ptr;
 
       num = grub_strtoul (ptr, &ptr, 0);
-      if (*ptr != '\0' || num == 0 || num > GRUB_INT_MAX)
+      if (num == 0 || num > GRUB_INT_MAX)
 	{
 	  grub_error (GRUB_ERR_BAD_NUMBER, N_("invalid partition number"));
 	  return 0;
-- 
2.48.1


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] kern: Unbreak support for nested partitions

[Daniel Kiper]

On Mon, Mar 03, 2025 at 12:02:21AM +0300, Vladimir Serbinenko wrote:
> When using syntax hd0,gtp3,dfly1 then ptr points to trailing part ",dfly1"
> so it's improper to consider it invalid partition
>
> Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel