From: Faizal Rahim <faizal.abdul.rahim@linux.intel.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Simon Horman <horms@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Furong Xu <0x1207@gmail.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Serge Semin <fancer.lancer@gmail.com>,
Xiaolei Wang <xiaolei.wang@windriver.com>,
Suraj Jaiswal <quic_jsuraj@quicinc.com>,
Kory Maincent <kory.maincent@bootlin.com>,
Gal Pressman <gal@nvidia.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Andrew Halaney <ahalaney@redhat.com>,
Choong Yong Liang <yong.liang.choong@linux.intel.com>,
Faizal Rahim <faizal.abdul.rahim@linux.intel.com>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org
Subject: [PATCH iwl-next v7 7/9] igc: Block setting preemptible traffic class in taprio
Date: Mon, 3 Mar 2025 05:26:56 -0500 [thread overview]
Message-ID: <20250303102658.3580232-8-faizal.abdul.rahim@linux.intel.com> (raw)
In-Reply-To: <20250303102658.3580232-1-faizal.abdul.rahim@linux.intel.com>
Since preemptible tc implementation is not ready yet, block it from being
set in taprio. The existing code already blocks it in mqprio.
Signed-off-by: Faizal Rahim <faizal.abdul.rahim@linux.intel.com>
---
drivers/net/ethernet/intel/igc/igc_main.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index fc086919387c..319eeb5b0a54 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -6407,6 +6407,10 @@ static int igc_save_qbv_schedule(struct igc_adapter *adapter,
if (!validate_schedule(adapter, qopt))
return -EINVAL;
+ /* preemptible isn't supported yet */
+ if (qopt->mqprio.preemptible_tcs)
+ return -EOPNOTSUPP;
+
igc_ptp_read(adapter, &now);
if (igc_tsn_is_taprio_activated_by_user(adapter) &&
--
2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Faizal Rahim <faizal.abdul.rahim@linux.intel.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Simon Horman <horms@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Furong Xu <0x1207@gmail.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Serge Semin <fancer.lancer@gmail.com>,
Xiaolei Wang <xiaolei.wang@windriver.com>,
Suraj Jaiswal <quic_jsuraj@quicinc.com>,
Kory Maincent <kory.maincent@bootlin.com>,
Gal Pressman <gal@nvidia.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Andrew Halaney <ahalaney@redhat.com>,
Choong Yong Liang <yong.liang.choong@linux.intel.com>,
Faizal Rahim <faizal.abdul.rahim@linux.intel.com>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org
Subject: [Intel-wired-lan] [PATCH iwl-next v7 7/9] igc: Block setting preemptible traffic class in taprio
Date: Mon, 3 Mar 2025 05:26:56 -0500 [thread overview]
Message-ID: <20250303102658.3580232-8-faizal.abdul.rahim@linux.intel.com> (raw)
In-Reply-To: <20250303102658.3580232-1-faizal.abdul.rahim@linux.intel.com>
Since preemptible tc implementation is not ready yet, block it from being
set in taprio. The existing code already blocks it in mqprio.
Signed-off-by: Faizal Rahim <faizal.abdul.rahim@linux.intel.com>
---
drivers/net/ethernet/intel/igc/igc_main.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index fc086919387c..319eeb5b0a54 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -6407,6 +6407,10 @@ static int igc_save_qbv_schedule(struct igc_adapter *adapter,
if (!validate_schedule(adapter, qopt))
return -EINVAL;
+ /* preemptible isn't supported yet */
+ if (qopt->mqprio.preemptible_tcs)
+ return -EOPNOTSUPP;
+
igc_ptp_read(adapter, &now);
if (igc_tsn_is_taprio_activated_by_user(adapter) &&
--
2.34.1
next prev parent reply other threads:[~2025-03-03 10:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 10:26 [PATCH iwl-next v7 0/9] igc: Add support for Frame Preemption feature in IGC Faizal Rahim
2025-03-03 10:26 ` [Intel-wired-lan] " Faizal Rahim
2025-03-03 10:26 ` [PATCH iwl-next v7 1/9] net: ethtool: mm: extract stmmac verification logic into common library Faizal Rahim
2025-03-03 10:26 ` [Intel-wired-lan] " Faizal Rahim
2025-03-04 22:21 ` Vladimir Oltean
2025-03-04 22:21 ` [Intel-wired-lan] " Vladimir Oltean
2025-03-03 10:26 ` [PATCH iwl-next v7 2/9] igc: Rename xdp_get_tx_ring() for non-xdp usage Faizal Rahim
2025-03-03 10:26 ` [Intel-wired-lan] " Faizal Rahim
2025-03-03 10:26 ` [PATCH iwl-next v7 3/9] igc: Optimize the TX packet buffer utilization Faizal Rahim
2025-03-03 10:26 ` [Intel-wired-lan] " Faizal Rahim
2025-03-03 10:26 ` [PATCH iwl-next v7 4/9] igc: Set the RX packet buffer size for TSN mode Faizal Rahim
2025-03-03 10:26 ` [Intel-wired-lan] " Faizal Rahim
2025-03-03 10:26 ` [PATCH iwl-next v7 5/9] igc: Add support for frame preemption verification Faizal Rahim
2025-03-03 10:26 ` [Intel-wired-lan] " Faizal Rahim
2025-03-04 15:26 ` Vladimir Oltean
2025-03-04 15:26 ` [Intel-wired-lan] " Vladimir Oltean
2025-03-05 12:33 ` Abdul Rahim, Faizal
2025-03-05 12:33 ` [Intel-wired-lan] " Abdul Rahim, Faizal
2025-03-03 10:26 ` [PATCH iwl-next v7 6/9] igc: Add support to set tx-min-frag-size Faizal Rahim
2025-03-03 10:26 ` [Intel-wired-lan] " Faizal Rahim
2025-03-03 10:26 ` Faizal Rahim [this message]
2025-03-03 10:26 ` [Intel-wired-lan] [PATCH iwl-next v7 7/9] igc: Block setting preemptible traffic class in taprio Faizal Rahim
2025-03-03 10:26 ` [PATCH iwl-next v7 8/9] igc: Add support to get MAC Merge data via ethtool Faizal Rahim
2025-03-03 10:26 ` [Intel-wired-lan] " Faizal Rahim
2025-03-03 10:26 ` [PATCH iwl-next v7 9/9] igc: Add support to get frame preemption statistics " Faizal Rahim
2025-03-03 10:26 ` [Intel-wired-lan] " Faizal Rahim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250303102658.3580232-8-faizal.abdul.rahim@linux.intel.com \
--to=faizal.abdul.rahim@linux.intel.com \
--cc=0x1207@gmail.com \
--cc=ahalaney@redhat.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fancer.lancer@gmail.com \
--cc=gal@nvidia.com \
--cc=hawk@kernel.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesper.nilsson@axis.com \
--cc=john.fastabend@gmail.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=quic_jsuraj@quicinc.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=vinicius.gomes@intel.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiaolei.wang@windriver.com \
--cc=yong.liang.choong@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.