* Re: [PATCH v2] drm/panthor: Update CS_STATUS_ defines to correct values
2025-03-03 18:04 [PATCH v2] drm/panthor: Update CS_STATUS_ defines to correct values Ashley Smith
@ 2025-03-03 18:56 ` Liviu Dudau
2025-03-03 19:56 ` Adrian Larumbe
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Liviu Dudau @ 2025-03-03 18:56 UTC (permalink / raw)
To: Ashley Smith
Cc: Boris Brezillon, Steven Price, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Heiko Stuebner,
kernel, dri-devel, linux-kernel
On Mon, Mar 03, 2025 at 06:04:32PM +0000, Ashley Smith wrote:
> Values for SC_STATUS_BLOCKED_REASON_ are documented in the G610 "Odin"
> GPU specification (CS_STATUS_BLOCKED_REASON register).
>
> This change updates the defines to the correct values.
>
> Fixes: 2718d91816ee ("drm/panthor: Add the FW logical block")
> Signed-off-by: Ashley Smith <ashley.smith@collabora.com>
Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
You could also add Steven's r-b, as per his email if you send another version,
otherwise it will need to be edited by whomever merges it.
Best regards,
Liviu
> ---
> Changes in v2:
> - Rename _RES to _RESOURCE
> ---
> drivers/gpu/drm/panthor/panthor_fw.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_fw.h b/drivers/gpu/drm/panthor/panthor_fw.h
> index 22448abde992..6598d96c6d2a 100644
> --- a/drivers/gpu/drm/panthor/panthor_fw.h
> +++ b/drivers/gpu/drm/panthor/panthor_fw.h
> @@ -102,9 +102,9 @@ struct panthor_fw_cs_output_iface {
> #define CS_STATUS_BLOCKED_REASON_SB_WAIT 1
> #define CS_STATUS_BLOCKED_REASON_PROGRESS_WAIT 2
> #define CS_STATUS_BLOCKED_REASON_SYNC_WAIT 3
> -#define CS_STATUS_BLOCKED_REASON_DEFERRED 5
> -#define CS_STATUS_BLOCKED_REASON_RES 6
> -#define CS_STATUS_BLOCKED_REASON_FLUSH 7
> +#define CS_STATUS_BLOCKED_REASON_DEFERRED 4
> +#define CS_STATUS_BLOCKED_REASON_RESOURCE 5
> +#define CS_STATUS_BLOCKED_REASON_FLUSH 6
> #define CS_STATUS_BLOCKED_REASON_MASK GENMASK(3, 0)
> u32 status_blocked_reason;
> u32 status_wait_sync_value_hi;
>
> base-commit: 16e57a72780931c3c70dbc928aeee4a0518075de
> --
> 2.43.0
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] drm/panthor: Update CS_STATUS_ defines to correct values
2025-03-03 18:04 [PATCH v2] drm/panthor: Update CS_STATUS_ defines to correct values Ashley Smith
2025-03-03 18:56 ` Liviu Dudau
@ 2025-03-03 19:56 ` Adrian Larumbe
2025-03-04 8:11 ` Boris Brezillon
2025-03-05 10:42 ` Steven Price
3 siblings, 0 replies; 5+ messages in thread
From: Adrian Larumbe @ 2025-03-03 19:56 UTC (permalink / raw)
To: Ashley Smith
Cc: Boris Brezillon, Steven Price, Liviu Dudau, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Heiko Stuebner, kernel, dri-devel, linux-kernel
> On 03.03.2025 18:04, Ashley Smith wrote:
> Values for SC_STATUS_BLOCKED_REASON_ are documented in the G610 "Odin"
> GPU specification (CS_STATUS_BLOCKED_REASON register).
>
> This change updates the defines to the correct values.
>
> Fixes: 2718d91816ee ("drm/panthor: Add the FW logical block")
> Signed-off-by: Ashley Smith <ashley.smith@collabora.com>
Reviewed-by: Adrián Larumbe <adrian.larumbe@collabora.com>
> ---
> Changes in v2:
> - Rename _RES to _RESOURCE
> ---
> drivers/gpu/drm/panthor/panthor_fw.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_fw.h b/drivers/gpu/drm/panthor/panthor_fw.h
> index 22448abde992..6598d96c6d2a 100644
> --- a/drivers/gpu/drm/panthor/panthor_fw.h
> +++ b/drivers/gpu/drm/panthor/panthor_fw.h
> @@ -102,9 +102,9 @@ struct panthor_fw_cs_output_iface {
> #define CS_STATUS_BLOCKED_REASON_SB_WAIT 1
> #define CS_STATUS_BLOCKED_REASON_PROGRESS_WAIT 2
> #define CS_STATUS_BLOCKED_REASON_SYNC_WAIT 3
> -#define CS_STATUS_BLOCKED_REASON_DEFERRED 5
> -#define CS_STATUS_BLOCKED_REASON_RES 6
> -#define CS_STATUS_BLOCKED_REASON_FLUSH 7
> +#define CS_STATUS_BLOCKED_REASON_DEFERRED 4
> +#define CS_STATUS_BLOCKED_REASON_RESOURCE 5
> +#define CS_STATUS_BLOCKED_REASON_FLUSH 6
> #define CS_STATUS_BLOCKED_REASON_MASK GENMASK(3, 0)
> u32 status_blocked_reason;
> u32 status_wait_sync_value_hi;
>
> base-commit: 16e57a72780931c3c70dbc928aeee4a0518075de
> --
> 2.43.0
Adrian Larumbe
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] drm/panthor: Update CS_STATUS_ defines to correct values
2025-03-03 18:04 [PATCH v2] drm/panthor: Update CS_STATUS_ defines to correct values Ashley Smith
2025-03-03 18:56 ` Liviu Dudau
2025-03-03 19:56 ` Adrian Larumbe
@ 2025-03-04 8:11 ` Boris Brezillon
2025-03-05 10:42 ` Steven Price
3 siblings, 0 replies; 5+ messages in thread
From: Boris Brezillon @ 2025-03-04 8:11 UTC (permalink / raw)
To: Ashley Smith
Cc: Steven Price, Liviu Dudau, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Heiko Stuebner,
kernel, dri-devel, linux-kernel
On Mon, 3 Mar 2025 18:04:32 +0000
Ashley Smith <ashley.smith@collabora.com> wrote:
> Values for SC_STATUS_BLOCKED_REASON_ are documented in the G610 "Odin"
> GPU specification (CS_STATUS_BLOCKED_REASON register).
>
> This change updates the defines to the correct values.
>
> Fixes: 2718d91816ee ("drm/panthor: Add the FW logical block")
> Signed-off-by: Ashley Smith <ashley.smith@collabora.com>
Adding my
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
back, so whoever ends up applying this patch doesn't have to add it
manually.
> ---
> Changes in v2:
> - Rename _RES to _RESOURCE
> ---
> drivers/gpu/drm/panthor/panthor_fw.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_fw.h b/drivers/gpu/drm/panthor/panthor_fw.h
> index 22448abde992..6598d96c6d2a 100644
> --- a/drivers/gpu/drm/panthor/panthor_fw.h
> +++ b/drivers/gpu/drm/panthor/panthor_fw.h
> @@ -102,9 +102,9 @@ struct panthor_fw_cs_output_iface {
> #define CS_STATUS_BLOCKED_REASON_SB_WAIT 1
> #define CS_STATUS_BLOCKED_REASON_PROGRESS_WAIT 2
> #define CS_STATUS_BLOCKED_REASON_SYNC_WAIT 3
> -#define CS_STATUS_BLOCKED_REASON_DEFERRED 5
> -#define CS_STATUS_BLOCKED_REASON_RES 6
> -#define CS_STATUS_BLOCKED_REASON_FLUSH 7
> +#define CS_STATUS_BLOCKED_REASON_DEFERRED 4
> +#define CS_STATUS_BLOCKED_REASON_RESOURCE 5
> +#define CS_STATUS_BLOCKED_REASON_FLUSH 6
> #define CS_STATUS_BLOCKED_REASON_MASK GENMASK(3, 0)
> u32 status_blocked_reason;
> u32 status_wait_sync_value_hi;
>
> base-commit: 16e57a72780931c3c70dbc928aeee4a0518075de
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] drm/panthor: Update CS_STATUS_ defines to correct values
2025-03-03 18:04 [PATCH v2] drm/panthor: Update CS_STATUS_ defines to correct values Ashley Smith
` (2 preceding siblings ...)
2025-03-04 8:11 ` Boris Brezillon
@ 2025-03-05 10:42 ` Steven Price
3 siblings, 0 replies; 5+ messages in thread
From: Steven Price @ 2025-03-05 10:42 UTC (permalink / raw)
To: Ashley Smith, Boris Brezillon, Liviu Dudau, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Heiko Stuebner
Cc: kernel, dri-devel, linux-kernel
On 03/03/2025 18:04, Ashley Smith wrote:
> Values for SC_STATUS_BLOCKED_REASON_ are documented in the G610 "Odin"
> GPU specification (CS_STATUS_BLOCKED_REASON register).
>
> This change updates the defines to the correct values.
>
> Fixes: 2718d91816ee ("drm/panthor: Add the FW logical block")
> Signed-off-by: Ashley Smith <ashley.smith@collabora.com>
Reviewed-by: Steven Price <steven.price@arm.com>
I'll push this to drm-misc-next.
Steve
> ---
> Changes in v2:
> - Rename _RES to _RESOURCE
> ---
> drivers/gpu/drm/panthor/panthor_fw.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_fw.h b/drivers/gpu/drm/panthor/panthor_fw.h
> index 22448abde992..6598d96c6d2a 100644
> --- a/drivers/gpu/drm/panthor/panthor_fw.h
> +++ b/drivers/gpu/drm/panthor/panthor_fw.h
> @@ -102,9 +102,9 @@ struct panthor_fw_cs_output_iface {
> #define CS_STATUS_BLOCKED_REASON_SB_WAIT 1
> #define CS_STATUS_BLOCKED_REASON_PROGRESS_WAIT 2
> #define CS_STATUS_BLOCKED_REASON_SYNC_WAIT 3
> -#define CS_STATUS_BLOCKED_REASON_DEFERRED 5
> -#define CS_STATUS_BLOCKED_REASON_RES 6
> -#define CS_STATUS_BLOCKED_REASON_FLUSH 7
> +#define CS_STATUS_BLOCKED_REASON_DEFERRED 4
> +#define CS_STATUS_BLOCKED_REASON_RESOURCE 5
> +#define CS_STATUS_BLOCKED_REASON_FLUSH 6
> #define CS_STATUS_BLOCKED_REASON_MASK GENMASK(3, 0)
> u32 status_blocked_reason;
> u32 status_wait_sync_value_hi;
>
> base-commit: 16e57a72780931c3c70dbc928aeee4a0518075de
^ permalink raw reply [flat|nested] 5+ messages in thread