From: Simon Horman <horms@kernel.org>
To: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org, andrew@lunn.ch, pmenzel@molgen.mpg.de,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3 4/4] ixgbe: add E610 .set_phys_id() callback implementation
Date: Wed, 5 Mar 2025 11:17:07 +0000 [thread overview]
Message-ID: <20250305111707.GM3666230@kernel.org> (raw)
In-Reply-To: <20250303120630.226353-5-jedrzej.jagielski@intel.com>
On Mon, Mar 03, 2025 at 01:06:30PM +0100, Jedrzej Jagielski wrote:
> Legacy implementation of .set_phys_id() ethtool callback is not
> applicable for E610 device.
>
> Add new implementation which uses 0x06E9 command by calling
> ixgbe_aci_set_port_id_led().
>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
> ---
> v3: move the #defines related to ixgbe_aci_cmd_set_port_id_led out of the
> struct definition
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org, andrew@lunn.ch, pmenzel@molgen.mpg.de,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Subject: Re: [PATCH iwl-next v3 4/4] ixgbe: add E610 .set_phys_id() callback implementation
Date: Wed, 5 Mar 2025 11:17:07 +0000 [thread overview]
Message-ID: <20250305111707.GM3666230@kernel.org> (raw)
In-Reply-To: <20250303120630.226353-5-jedrzej.jagielski@intel.com>
On Mon, Mar 03, 2025 at 01:06:30PM +0100, Jedrzej Jagielski wrote:
> Legacy implementation of .set_phys_id() ethtool callback is not
> applicable for E610 device.
>
> Add new implementation which uses 0x06E9 command by calling
> ixgbe_aci_set_port_id_led().
>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
> ---
> v3: move the #defines related to ixgbe_aci_cmd_set_port_id_led out of the
> struct definition
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-03-05 11:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 12:06 [Intel-wired-lan] [PATCH iwl-next v3 0/4] ixgbe: add ethtool support for E610 Jedrzej Jagielski
2025-03-03 12:06 ` Jedrzej Jagielski
2025-03-03 12:06 ` [Intel-wired-lan] [PATCH iwl-next v3 1/4] ixgbe: create E610 specific ethtool_ops structure Jedrzej Jagielski
2025-03-03 12:06 ` Jedrzej Jagielski
2025-03-05 11:15 ` [Intel-wired-lan] " Simon Horman
2025-03-05 11:15 ` Simon Horman
2025-03-07 14:32 ` [Intel-wired-lan] " R, Bharath
2025-03-07 14:32 ` R, Bharath
2025-03-03 12:06 ` [Intel-wired-lan] [PATCH iwl-next v3 2/4] ixgbe: add support for ACPI WOL for E610 Jedrzej Jagielski
2025-03-03 12:06 ` Jedrzej Jagielski
2025-03-05 11:16 ` [Intel-wired-lan] " Simon Horman
2025-03-05 11:16 ` Simon Horman
2025-03-07 10:55 ` [Intel-wired-lan] " R, Bharath
2025-03-07 10:55 ` R, Bharath
2025-03-03 12:06 ` [Intel-wired-lan] [PATCH iwl-next v3 3/4] ixgbe: apply different rules for setting FC on E610 Jedrzej Jagielski
2025-03-03 12:06 ` Jedrzej Jagielski
2025-03-05 11:16 ` [Intel-wired-lan] " Simon Horman
2025-03-05 11:16 ` Simon Horman
2025-03-07 10:53 ` [Intel-wired-lan] " R, Bharath
2025-03-07 10:53 ` R, Bharath
2025-03-03 12:06 ` [Intel-wired-lan] [PATCH iwl-next v3 4/4] ixgbe: add E610 .set_phys_id() callback implementation Jedrzej Jagielski
2025-03-03 12:06 ` Jedrzej Jagielski
2025-03-05 11:17 ` Simon Horman [this message]
2025-03-05 11:17 ` Simon Horman
2025-03-11 7:39 ` [Intel-wired-lan] " R, Bharath
2025-03-11 7:39 ` R, Bharath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250305111707.GM3666230@kernel.org \
--to=horms@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jedrzej.jagielski@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.