[PATCH] tests/util/grub-shell: Default qemuopts to envvar $GRUB_QEMU_OPTS

[PATCH] tests/util/grub-shell: Default qemuopts to envvar $GRUB_QEMU_OPTS

[Glenn Washburn]

Fix a regression where qemuopts was mistakenly defaulted to the empty
string. This prevents the sending of arbitrary QEMU options to tests,
which may be desirable for overriding the machine type. There was a
concern that allowing the tester to accept arbitrary options would add
headaches for another deveoper trying to diagnose why a test failed on
the testers machine because he could not be sure if any additional
options were passed to make the test fail. However, all the options are
recorded in the run.sh generated script, so this concern is unwarranted.

Fixes: 6d729ced70 (tests/util/grub-shell: Add $GRUB_QEMU_OPTS to run.sh to easily see unofficial QEMU arguments)
Signed-off-by: Glenn Washburn <development@efficientek.com>
---
 tests/util/grub-shell.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in
index 4867b6786895..228939a34d16 100644
--- a/tests/util/grub-shell.in
+++ b/tests/util/grub-shell.in
@@ -74,7 +74,7 @@ exec_show_error () {
 work_directory=${WORKDIR:-`mktemp -d "${TMPDIR:-/tmp}/grub-shell.XXXXXXXXXX"`} || exit 1
 
 . "${builddir}/grub-core/modinfo.sh"
-qemuopts=
+qemuopts=${GRUB_QEMU_OPTS}
 emuopts=
 serial_port=com0
 serial_null=
-- 
2.34.1


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] tests/util/grub-shell: Default qemuopts to envvar $GRUB_QEMU_OPTS

[Daniel Kiper]

On Thu, Mar 06, 2025 at 12:48:13AM -0600, Glenn Washburn wrote:
> Fix a regression where qemuopts was mistakenly defaulted to the empty
> string. This prevents the sending of arbitrary QEMU options to tests,
> which may be desirable for overriding the machine type. There was a
> concern that allowing the tester to accept arbitrary options would add
> headaches for another deveoper trying to diagnose why a test failed on
> the testers machine because he could not be sure if any additional
> options were passed to make the test fail. However, all the options are
> recorded in the run.sh generated script, so this concern is unwarranted.
>
> Fixes: 6d729ced70 (tests/util/grub-shell: Add $GRUB_QEMU_OPTS to run.sh to easily see unofficial QEMU arguments)
> Signed-off-by: Glenn Washburn <development@efficientek.com>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel