From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Tariq Toukan <ttoukan.linux@gmail.com>
Cc: linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Joe Damato <jdamato@fastly.com>,
Leon Romanovsky <leon@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Thomas Gleixner <tglx@linutronix.de>,
Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [PATCH net-next] net/mlnx5: Use generic code for page_pool statistics.
Date: Thu, 6 Mar 2025 08:38:50 +0100 [thread overview]
Message-ID: <20250306073850.yA23Fs1V@linutronix.de> (raw)
In-Reply-To: <42892aa7-f7a9-4227-9f3f-24a0f1c96992@gmail.com>
On 2025-03-06 08:49:55 [+0200], Tariq Toukan wrote:
> > > I like the direction of this patch, but we won't give up the per-ring
> > > counters. Please keep them.
> >
> > Hmm. Okay. I guess I could stuff a struct there. But it really looks
> > like waste since it is not used.
> >
>
> Of course they are used.
> Per-ring (per-pool) counters are exposed via ethtool -S.
That is true for some stats and they are prefixed with a number for the
individual ring. In case of page_pool_stats they are not exposed
individually. The individual page_pool_stats counters from each ring are
merged into one counter and as exposed as one (not per ring).
Sebastian
next prev parent reply other threads:[~2025-03-06 7:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 12:14 [PATCH net-next] net/mlnx5: Use generic code for page_pool statistics Sebastian Andrzej Siewior
2025-03-05 16:21 ` Andrew Lunn
2025-03-05 16:26 ` Sebastian Andrzej Siewior
2025-03-05 17:43 ` Andrew Lunn
2025-03-05 18:52 ` Sebastian Andrzej Siewior
2025-03-05 19:44 ` Tariq Toukan
2025-03-05 20:20 ` Sebastian Andrzej Siewior
2025-03-06 6:49 ` Tariq Toukan
2025-03-06 7:38 ` Sebastian Andrzej Siewior [this message]
2025-03-06 8:32 ` Sebastian Andrzej Siewior
2025-03-06 9:50 ` Tariq Toukan
2025-03-06 9:56 ` Sebastian Andrzej Siewior
2025-03-06 10:22 ` Tariq Toukan
2025-03-06 10:38 ` Sebastian Andrzej Siewior
2025-03-06 11:10 ` Tariq Toukan
2025-03-06 13:16 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306073850.yA23Fs1V@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=tglx@linutronix.de \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.