From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Tariq Toukan <ttoukan.linux@gmail.com>
Cc: linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Joe Damato <jdamato@fastly.com>,
Leon Romanovsky <leon@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Thomas Gleixner <tglx@linutronix.de>,
Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [PATCH net-next] net/mlnx5: Use generic code for page_pool statistics.
Date: Thu, 6 Mar 2025 14:16:20 +0100 [thread overview]
Message-ID: <20250306131620.LvXx2kNB@linutronix.de> (raw)
In-Reply-To: <59987f5c-daa1-4063-9781-ac50f7eabb6c@gmail.com>
On 2025-03-06 13:10:12 [+0200], Tariq Toukan wrote:
>
>
> On 06/03/2025 11:56, Sebastian Andrzej Siewior wrote:
> > On 2025-03-06 11:50:27 [+0200], Tariq Toukan wrote:
> > > On 06/03/2025 10:32, Sebastian Andrzej Siewior wrote:
> > > > Could I keep it as-is for now with the removal of the counter from the
> > > > RQ since we don't have the per-queue/ ring API for it now?
> > >
> > > I'm fine with transition to generic APIs, as long as we get no regression.
> > > We must keep the per-ring counters exposed.
> >
> > I don't see a regression.
> > Could you please show me how per-ring counters for page_pool_stats are
> > exposed at the moment? Maybe I am missing something important.
> >
>
> What do you see in your ethtool -S?
Now, after comparing it again I noticed that there is
| rx_pp_alloc_fast: 27783
| rx0_pp_alloc_fast: 441
| rx1_pp_alloc_fast: 441
which I didn't noticed earlier. I didn't rx0,1,… for pp_alloc_fast.
Thanks.
Sebastian
prev parent reply other threads:[~2025-03-06 13:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 12:14 [PATCH net-next] net/mlnx5: Use generic code for page_pool statistics Sebastian Andrzej Siewior
2025-03-05 16:21 ` Andrew Lunn
2025-03-05 16:26 ` Sebastian Andrzej Siewior
2025-03-05 17:43 ` Andrew Lunn
2025-03-05 18:52 ` Sebastian Andrzej Siewior
2025-03-05 19:44 ` Tariq Toukan
2025-03-05 20:20 ` Sebastian Andrzej Siewior
2025-03-06 6:49 ` Tariq Toukan
2025-03-06 7:38 ` Sebastian Andrzej Siewior
2025-03-06 8:32 ` Sebastian Andrzej Siewior
2025-03-06 9:50 ` Tariq Toukan
2025-03-06 9:56 ` Sebastian Andrzej Siewior
2025-03-06 10:22 ` Tariq Toukan
2025-03-06 10:38 ` Sebastian Andrzej Siewior
2025-03-06 11:10 ` Tariq Toukan
2025-03-06 13:16 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306131620.LvXx2kNB@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=tglx@linutronix.de \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.