* [PATCH] nvme-pci: remove stale comment
@ 2025-03-06 8:53 ` Baruch Siach
2025-03-06 14:13 ` Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Baruch Siach @ 2025-03-06 8:53 UTC (permalink / raw)
To: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg
Cc: linux-nvme, Baruch Siach
The ns variable has been removed in commit 62451a2b2e7e ("nvme: separate
command prep and issue"). Drop reference to ns in comment.
Fixes: 62451a2b2e7e ("nvme: separate command prep and issue")
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
drivers/nvme/host/pci.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 950289405ef2..caf5447f1af4 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -953,9 +953,6 @@ static blk_status_t nvme_prep_rq(struct nvme_dev *dev, struct request *req)
return ret;
}
-/*
- * NOTE: ns is NULL when called on the admin queue.
- */
static blk_status_t nvme_queue_rq(struct blk_mq_hw_ctx *hctx,
const struct blk_mq_queue_data *bd)
{
--
2.47.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme-pci: remove stale comment
2025-03-06 8:53 ` [PATCH] nvme-pci: remove stale comment Baruch Siach
@ 2025-03-06 14:13 ` Christoph Hellwig
2025-03-10 10:38 ` Anuj Gupta
2025-03-10 17:32 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2025-03-06 14:13 UTC (permalink / raw)
To: Baruch Siach
Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
linux-nvme
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme-pci: remove stale comment
2025-03-06 8:53 ` [PATCH] nvme-pci: remove stale comment Baruch Siach
2025-03-06 14:13 ` Christoph Hellwig
@ 2025-03-10 10:38 ` Anuj Gupta
2025-03-10 17:32 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Anuj Gupta @ 2025-03-10 10:38 UTC (permalink / raw)
To: Baruch Siach
Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
linux-nvme
[-- Attachment #1: Type: text/plain, Size: 47 bytes --]
Reviewed-by: Anuj Gupta <anuj20.g@samsung.com>
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme-pci: remove stale comment
2025-03-06 8:53 ` [PATCH] nvme-pci: remove stale comment Baruch Siach
2025-03-06 14:13 ` Christoph Hellwig
2025-03-10 10:38 ` Anuj Gupta
@ 2025-03-10 17:32 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Keith Busch @ 2025-03-10 17:32 UTC (permalink / raw)
To: Baruch Siach; +Cc: Jens Axboe, Christoph Hellwig, Sagi Grimberg, linux-nvme
On Thu, Mar 06, 2025 at 10:53:31AM +0200, Baruch Siach wrote:
> The ns variable has been removed in commit 62451a2b2e7e ("nvme: separate
> command prep and issue"). Drop reference to ns in comment.
Thanks, applied to nvme-6.15.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-10 18:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20250310104708epcas5p47a8a441dde01467ee724444a77c0a9a9@epcas5p4.samsung.com>
2025-03-06 8:53 ` [PATCH] nvme-pci: remove stale comment Baruch Siach
2025-03-06 14:13 ` Christoph Hellwig
2025-03-10 10:38 ` Anuj Gupta
2025-03-10 17:32 ` Keith Busch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.