Re: [PATCH] nvme: remove multipath module parameter

[Christoph Hellwig <hch@lst.de>]

On Thu, Mar 06, 2025 at 08:01:19AM -0700, Keith Busch wrote:
> > If the device is indeed entirely single ported and Samsung can confirm
> > the setting is incorret and not easily fixable by a firmware update
> > we can quirk it.
> 
> It's not one vendor or device.

I've not seen in in the wild so it can't be that common.

> Or consider a true multiport PCIe where each port connects to a
> different host. Each host sees a single port so they're not using
> multipath capabilities, and the admin wants the MD behavior that removes
> a disk on hot plug. Or even if one host sees both paths of a multiport
> PCIe, they still might want that hot plug behavior. The module parameter
> makes that possible, so some equivalent should be available before
> removing it.

A module-wide parameter is absolutely the wrong way to configure it.
You'd ad best want it per-controller or even per-namespace.  One
tradeoff would be to disable the multipath code for private namespaces,
although that would cause problems when rescanning changes the flag.