All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
To: miguel.ojeda.sandonis@gmail.com
Cc: a.hindborg@kernel.org, alex.gaynor@gmail.com,
	aliceryhl@google.com, apw@canonical.com, arnd@arndb.de,
	aswinunni01@gmail.com, axboe@kernel.dk, benno.lossin@proton.me,
	bhelgaas@google.com, bjorn3_gh@protonmail.com,
	boqun.feng@gmail.com, dakr@kernel.org, dwaipayanray1@gmail.com,
	ethan.twardy@gmail.com, fujita.tomonori@gmail.com,
	gary@garyguo.net, gregkh@linuxfoundation.org, joe@perches.com,
	linux-kernel@vger.kernel.org, lukas.bulwahn@gmail.com,
	ojeda@kernel.org, pbonzini@redhat.com,
	rust-for-linux@vger.kernel.org, tmgross@umich.edu,
	trintaeoitogc@gmail.com, walmeida@microsoft.com
Subject: Re: [PATCH V6 2/2] checkpatch: check format of Vec<String> in modules
Date: Thu,  6 Mar 2025 13:32:06 -0300	[thread overview]
Message-ID: <20250306163206.301564-1-trintaeoitogc@gmail.com> (raw)
In-Reply-To: <CANiq72md_orajH_TREr=ng8Y=o3Xkgw-V5oxbX8vYXOE2UDNaQ@mail.gmail.com>

Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:
> In any case, landing checks here is fine (as long as Joe et al.
> agree), they can be moved or removed later if needed.
The only thing bad in this check, is when the array is very very big, like:
    authors: [ 
        "author_1"
        "author_2"
        "author_3"
        "author_4"
        "author_5"
        "author_6"
        "author_8"        
		"author_9" 
        "author_10" 
        "author_11" 
        "author_12" 
        "author_13" 
        "author_14" 
        "author_15" 
        "author_16" 
        "author_17" 
    ],


if I set a new author_18, the diff will be:
         "author_15" 
         "author_16" 
         "author_17" 
+        "author_18" 
     ],
And, in this case, if I make a wrong change, like:

         "author_15" 
         "author_16" 
         "author_17" 
+        "author_18" , "author_19"
     ],
the checkpatch don't will throw a warning message, because, he don't can
perceive that he is within of array of author, firmware or alias of module!. 

I couldn't do a better check for this.. 

thoughs? 

Thanks,
Guilherme

  parent reply	other threads:[~2025-03-06 16:32 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <GQqgXevDlPrbDVqybjdBe8eWBr-bsr56Nmbydqom2kJLDE2mrH7hfWC0ORBSY3Qz7yaBd3mIoy9TcKjNz96hzA==@protonmail.internalid>
2025-02-23 17:42 ` [PATCH V6 0/2] author field in module! macro should be a array Guilherme Giacomo Simoes
2025-02-23 17:42   ` [PATCH V6 1/2] rust: module: change author to an array Guilherme Giacomo Simoes
2025-02-24 22:07     ` Charalampos Mitrodimas
2025-03-04 12:09     ` Andreas Hindborg
2025-03-04 12:52     ` Alice Ryhl
2025-02-23 17:42   ` [PATCH V6 2/2] checkpatch: check format of Vec<String> in modules Guilherme Giacomo Simoes
2025-03-04 12:16     ` Andreas Hindborg
2025-03-04 20:50       ` Guilherme Giacomo Simoes
2025-03-04 21:00         ` Miguel Ojeda
2025-03-04 21:01           ` Miguel Ojeda
2025-03-05  7:53             ` Andreas Hindborg
2025-03-05 11:04               ` Miguel Ojeda
2025-03-05 11:08                 ` Andreas Hindborg
2025-03-06 16:18                 ` Guilherme Giacomo Simoes
2025-03-06 16:32                 ` Guilherme Giacomo Simoes [this message]
2025-03-06 16:33                   ` Miguel Ojeda
2025-03-06  1:59           ` Guilherme Giacomo Simoes
2025-03-06 11:39             ` Miguel Ojeda
2025-03-06 16:08               ` Guilherme Giacomo Simoes
2025-03-06 16:36                 ` Miguel Ojeda
2025-03-06 17:18                   ` Guilherme Giacomo Simoes
2025-03-06 17:19                     ` Miguel Ojeda
2025-03-04 11:59   ` [PATCH V6 0/2] author field in module! macro should be a array Andreas Hindborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250306163206.301564-1-trintaeoitogc@gmail.com \
    --to=trintaeoitogc@gmail.com \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=apw@canonical.com \
    --cc=arnd@arndb.de \
    --cc=aswinunni01@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=benno.lossin@proton.me \
    --cc=bhelgaas@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=dwaipayanray1@gmail.com \
    --cc=ethan.twardy@gmail.com \
    --cc=fujita.tomonori@gmail.com \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    --cc=walmeida@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.