From: Andreas Hindborg <a.hindborg@kernel.org>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>
Cc: "Guilherme Giacomo Simoes" <trintaeoitogc@gmail.com>,
<alex.gaynor@gmail.com>, <aliceryhl@google.com>,
<apw@canonical.com>, <arnd@arndb.de>, <aswinunni01@gmail.com>,
<axboe@kernel.dk>, <benno.lossin@proton.me>,
<bhelgaas@google.com>, <bjorn3_gh@protonmail.com>,
<boqun.feng@gmail.com>, <dakr@kernel.org>,
<dwaipayanray1@gmail.com>, <ethan.twardy@gmail.com>,
<fujita.tomonori@gmail.com>, <gary@garyguo.net>,
<gregkh@linuxfoundation.org>, <joe@perches.com>,
<linux-kernel@vger.kernel.org>, <lukas.bulwahn@gmail.com>,
<ojeda@kernel.org>, <pbonzini@redhat.com>,
<rust-for-linux@vger.kernel.org>, <tmgross@umich.edu>,
<walmeida@microsoft.com>
Subject: Re: [PATCH V6 2/2] checkpatch: check format of Vec<String> in modules
Date: Wed, 05 Mar 2025 08:53:18 +0100 [thread overview]
Message-ID: <87v7sngbgx.fsf@kernel.org> (raw)
In-Reply-To: <CANiq72kNG7jZf+hZARjyAp-uG=x99CrUKZvJYT_icaF0x0G6iw@mail.gmail.com> (Miguel Ojeda's message of "Tue, 04 Mar 2025 22:01:05 +0100")
"Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com> writes:
> On Tue, Mar 4, 2025 at 10:00 PM Miguel Ojeda
> <miguel.ojeda.sandonis@gmail.com> wrote:
>>
>> I think it could be a good idea (it would be lovely to write the
>> checker in Rust -- I also had a checker bot in Python from the old
>> days of the old `rust` branch in GitHub), but `checkpatch.pl` doesn't
>> need a built kernel, so it would be a disadvantage or at least a
>> difference w.r.t. the usual `checkpatch.pl`, and we may not be able to
>> call it from `checkpatch.pl`.
>
> By "built kernel", I don't mean an entire kernel, but rather having to
> call `make` in general, i.e. we could have a target to build just the
> script, but still, it is a difference.
Right, it needs a bit more tool support than running checkpatch.pl
needs. Perhaps we could move it from checkpatch.pl to the rustfmt make
target?
Best regards,
Andreas Hindborg
next prev parent reply other threads:[~2025-03-05 7:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <GQqgXevDlPrbDVqybjdBe8eWBr-bsr56Nmbydqom2kJLDE2mrH7hfWC0ORBSY3Qz7yaBd3mIoy9TcKjNz96hzA==@protonmail.internalid>
2025-02-23 17:42 ` [PATCH V6 0/2] author field in module! macro should be a array Guilherme Giacomo Simoes
2025-02-23 17:42 ` [PATCH V6 1/2] rust: module: change author to an array Guilherme Giacomo Simoes
2025-02-24 22:07 ` Charalampos Mitrodimas
2025-03-04 12:09 ` Andreas Hindborg
2025-03-04 12:52 ` Alice Ryhl
2025-02-23 17:42 ` [PATCH V6 2/2] checkpatch: check format of Vec<String> in modules Guilherme Giacomo Simoes
2025-03-04 12:16 ` Andreas Hindborg
2025-03-04 20:50 ` Guilherme Giacomo Simoes
2025-03-04 21:00 ` Miguel Ojeda
2025-03-04 21:01 ` Miguel Ojeda
2025-03-05 7:53 ` Andreas Hindborg [this message]
2025-03-05 11:04 ` Miguel Ojeda
2025-03-05 11:08 ` Andreas Hindborg
2025-03-06 16:18 ` Guilherme Giacomo Simoes
2025-03-06 16:32 ` Guilherme Giacomo Simoes
2025-03-06 16:33 ` Miguel Ojeda
2025-03-06 1:59 ` Guilherme Giacomo Simoes
2025-03-06 11:39 ` Miguel Ojeda
2025-03-06 16:08 ` Guilherme Giacomo Simoes
2025-03-06 16:36 ` Miguel Ojeda
2025-03-06 17:18 ` Guilherme Giacomo Simoes
2025-03-06 17:19 ` Miguel Ojeda
2025-03-04 11:59 ` [PATCH V6 0/2] author field in module! macro should be a array Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7sngbgx.fsf@kernel.org \
--to=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apw@canonical.com \
--cc=arnd@arndb.de \
--cc=aswinunni01@gmail.com \
--cc=axboe@kernel.dk \
--cc=benno.lossin@proton.me \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=dwaipayanray1@gmail.com \
--cc=ethan.twardy@gmail.com \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=pbonzini@redhat.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=trintaeoitogc@gmail.com \
--cc=walmeida@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.