From: Petr Vorel <pvorel@suse.cz>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: ltp@lists.linux.it, Stefan Berger <stefanb@linux.ibm.com>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH v3 5/5] ima_violations.sh: require kernel v6.14 for minimizing violations tests
Date: Thu, 6 Mar 2025 18:26:22 +0100 [thread overview]
Message-ID: <20250306172622.GB186319@pevik> (raw)
In-Reply-To: <20250305145421.638857-5-zohar@linux.ibm.com>
Hi Mimi,
> Depending on the IMA policy and the number of violations, the kernel
> patches for minimizing the number of open-writers and ToMToU (Time of
> Measure Time of Use) violations may be a major performance improvement.
I would prefer this to be squashed into "ima_violations.sh: additional
open-writer violation tests" commit, which adds this incompatibility.
But it's a minor detail, therefore I merged whole patchset as is.
Thanks!
Kind regards,
Petr
> Most likely the kernel patches will be back ported, but for now limit
> the new tests to new kernels with the applied patches. Bail after the
> first new test.
> Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
> ---
> .../kernel/security/integrity/ima/tests/ima_violations.sh | 4 ++++
> 1 file changed, 4 insertions(+)
> diff --git a/testcases/kernel/security/integrity/ima/tests/ima_violations.sh b/testcases/kernel/security/integrity/ima/tests/ima_violations.sh
> index 0395f8d0a..8e988fca6 100755
> --- a/testcases/kernel/security/integrity/ima/tests/ima_violations.sh
> +++ b/testcases/kernel/security/integrity/ima/tests/ima_violations.sh
> @@ -177,6 +177,10 @@ test4()
> {
> tst_res TINFO "verify limiting single open writer violation"
> + if tst_kvcmp -lt 6.14; then
> + tst_brk TCONF "Minimizing violations requires kernel 6.14 or newer"
> + fi
> +
> local search="open_writers"
> local count num_violations
WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org, ltp@lists.linux.it,
Stefan Berger <stefanb@linux.ibm.com>
Subject: Re: [LTP] [PATCH v3 5/5] ima_violations.sh: require kernel v6.14 for minimizing violations tests
Date: Thu, 6 Mar 2025 18:26:22 +0100 [thread overview]
Message-ID: <20250306172622.GB186319@pevik> (raw)
In-Reply-To: <20250305145421.638857-5-zohar@linux.ibm.com>
Hi Mimi,
> Depending on the IMA policy and the number of violations, the kernel
> patches for minimizing the number of open-writers and ToMToU (Time of
> Measure Time of Use) violations may be a major performance improvement.
I would prefer this to be squashed into "ima_violations.sh: additional
open-writer violation tests" commit, which adds this incompatibility.
But it's a minor detail, therefore I merged whole patchset as is.
Thanks!
Kind regards,
Petr
> Most likely the kernel patches will be back ported, but for now limit
> the new tests to new kernels with the applied patches. Bail after the
> first new test.
> Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
> ---
> .../kernel/security/integrity/ima/tests/ima_violations.sh | 4 ++++
> 1 file changed, 4 insertions(+)
> diff --git a/testcases/kernel/security/integrity/ima/tests/ima_violations.sh b/testcases/kernel/security/integrity/ima/tests/ima_violations.sh
> index 0395f8d0a..8e988fca6 100755
> --- a/testcases/kernel/security/integrity/ima/tests/ima_violations.sh
> +++ b/testcases/kernel/security/integrity/ima/tests/ima_violations.sh
> @@ -177,6 +177,10 @@ test4()
> {
> tst_res TINFO "verify limiting single open writer violation"
> + if tst_kvcmp -lt 6.14; then
> + tst_brk TCONF "Minimizing violations requires kernel 6.14 or newer"
> + fi
> +
> local search="open_writers"
> local count num_violations
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-03-06 17:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 14:54 [PATCH v3 1/5] ima_violations.sh: force $LOG ToMToU violation earlier Mimi Zohar
2025-03-05 14:54 ` [LTP] " Mimi Zohar
2025-03-05 14:54 ` [PATCH v3 2/5] ima_violations.sh: Update validate() to support multiple violations Mimi Zohar
2025-03-05 14:54 ` [LTP] " Mimi Zohar
2025-03-05 14:54 ` [PATCH v3 3/5] ima_violations.sh: additional open-writer violation tests Mimi Zohar
2025-03-05 14:54 ` [LTP] " Mimi Zohar
2025-03-05 14:54 ` [PATCH v3 4/5] ima_violations.sh: additional ToMToU " Mimi Zohar
2025-03-05 14:54 ` [LTP] " Mimi Zohar
2025-03-05 14:54 ` [PATCH v3 5/5] ima_violations.sh: require kernel v6.14 for minimizing violations tests Mimi Zohar
2025-03-05 14:54 ` [LTP] " Mimi Zohar
2025-03-06 17:26 ` Petr Vorel [this message]
2025-03-06 17:26 ` Petr Vorel
2025-03-06 21:02 ` Mimi Zohar
2025-03-06 21:02 ` [LTP] " Mimi Zohar
2025-03-06 17:07 ` [PATCH v3 1/5] ima_violations.sh: force $LOG ToMToU violation earlier Petr Vorel
2025-03-06 17:07 ` [LTP] " Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306172622.GB186319@pevik \
--to=pvorel@suse.cz \
--cc=linux-integrity@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=stefanb@linux.ibm.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.