From: David Disseldorp <ddiss@suse.de>
To: Chao Yu <chao@kernel.org>
Cc: Zorro Lang <zlang@kernel.org>,
fstests@vger.kernel.org, jaegeuk@kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/4] common/config: remove redundant export of F2FS_IO_PROG
Date: Fri, 7 Mar 2025 14:56:29 +1100 [thread overview]
Message-ID: <20250307145629.2b2c6e99.ddiss@suse.de> (raw)
In-Reply-To: <20250306081809.2397527-1-chao@kernel.org>
On Thu, 6 Mar 2025 16:18:06 +0800, Chao Yu wrote:
> F2FS_IO_PROG was been exported twice, remove the redudant one.
>
> Cc: Jaegeuk Kim <jaegeuk@kernel.org>
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
> common/config | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/common/config b/common/config
> index 2afbda14..8d3047a5 100644
> --- a/common/config
> +++ b/common/config
> @@ -191,7 +191,6 @@ export XFS_COPY_PROG="$(type -P xfs_copy)"
> export FSTRIM_PROG="$(type -P fstrim)"
> export DUMPE2FS_PROG="$(type -P dumpe2fs)"
> export RESIZE2FS_PROG="$(type -P resize2fs)"
> -export F2FS_IO_PROG="$(type -P f2fs_io)"
> export FIO_PROG="$(type -P fio)"
> export FILEFRAG_PROG="$(type -P filefrag)"
> export E4DEFRAG_PROG="$(type -P e4defrag)"
Looks good. @Zorro, might as well squash in removal of the duplicate
TIMEOUT_PROG export too.
Reviewed-by: David Disseldorp <ddiss@suse.de>
WARNING: multiple messages have this Message-ID (diff)
From: David Disseldorp <ddiss@suse.de>
To: Chao Yu <chao@kernel.org>
Cc: jaegeuk@kernel.org, Zorro Lang <zlang@kernel.org>,
fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 1/4] common/config: remove redundant export of F2FS_IO_PROG
Date: Fri, 7 Mar 2025 14:56:29 +1100 [thread overview]
Message-ID: <20250307145629.2b2c6e99.ddiss@suse.de> (raw)
In-Reply-To: <20250306081809.2397527-1-chao@kernel.org>
On Thu, 6 Mar 2025 16:18:06 +0800, Chao Yu wrote:
> F2FS_IO_PROG was been exported twice, remove the redudant one.
>
> Cc: Jaegeuk Kim <jaegeuk@kernel.org>
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
> common/config | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/common/config b/common/config
> index 2afbda14..8d3047a5 100644
> --- a/common/config
> +++ b/common/config
> @@ -191,7 +191,6 @@ export XFS_COPY_PROG="$(type -P xfs_copy)"
> export FSTRIM_PROG="$(type -P fstrim)"
> export DUMPE2FS_PROG="$(type -P dumpe2fs)"
> export RESIZE2FS_PROG="$(type -P resize2fs)"
> -export F2FS_IO_PROG="$(type -P f2fs_io)"
> export FIO_PROG="$(type -P fio)"
> export FILEFRAG_PROG="$(type -P filefrag)"
> export E4DEFRAG_PROG="$(type -P e4defrag)"
Looks good. @Zorro, might as well squash in removal of the duplicate
TIMEOUT_PROG export too.
Reviewed-by: David Disseldorp <ddiss@suse.de>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2025-03-07 3:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 8:18 [PATCH 1/4] common/config: remove redundant export of F2FS_IO_PROG Chao Yu
2025-03-06 8:18 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-03-06 8:18 ` [PATCH 2/4] common/config: export F2FS_INJECT_PROG Chao Yu
2025-03-06 8:18 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-03-07 3:57 ` David Disseldorp
2025-03-07 3:57 ` [f2fs-dev] " David Disseldorp
2025-03-06 8:18 ` [PATCH 3/4] common/rc: support f2fs in _repair_scratch_fs Chao Yu
2025-03-06 8:18 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-03-07 3:57 ` David Disseldorp
2025-03-07 3:57 ` [f2fs-dev] " David Disseldorp
2025-03-06 8:18 ` [PATCH 4/4] f2fs/009: detect and repair nlink corruption Chao Yu
2025-03-06 8:18 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-03-07 4:02 ` David Disseldorp
2025-03-07 4:02 ` [f2fs-dev] " David Disseldorp
2025-03-10 9:46 ` Chao Yu
2025-03-10 9:46 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-03-10 8:00 ` Zorro Lang
2025-03-10 8:00 ` [f2fs-dev] " Zorro Lang
2025-03-10 9:59 ` Chao Yu
2025-03-10 9:59 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-03-10 19:48 ` Zorro Lang
2025-03-10 19:48 ` [f2fs-dev] " Zorro Lang
2025-03-11 2:24 ` Chao Yu
2025-03-11 2:24 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-03-07 3:56 ` David Disseldorp [this message]
2025-03-07 3:56 ` [f2fs-dev] [PATCH 1/4] common/config: remove redundant export of F2FS_IO_PROG David Disseldorp
2025-03-10 7:16 ` Zorro Lang
2025-03-10 7:16 ` [f2fs-dev] " Zorro Lang
2025-03-10 8:02 ` Zorro Lang
2025-03-10 8:02 ` [f2fs-dev] " Zorro Lang
2025-03-10 10:01 ` Chao Yu
2025-03-10 10:01 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250307145629.2b2c6e99.ddiss@suse.de \
--to=ddiss@suse.de \
--cc=chao@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.