All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
	syzbot <syzbot+019072ad24ab1d948228@syzkaller.appspotmail.com>,
	jk@ozlabs.org, linux-efi@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [efi?] [fs?] possible deadlock in efivarfs_actor
Date: Mon, 10 Mar 2025 23:58:31 +0000	[thread overview]
Message-ID: <20250310235831.GL2023217@ZenIV> (raw)
In-Reply-To: <CAMj1kXH0Myy3bV-hFNWnoUk6ZAa6MAd1zFTM-X6dXiJPx==w0A@mail.gmail.com>

On Mon, Mar 10, 2025 at 07:21:53PM +0100, Ard Biesheuvel wrote:

> The repro log also has
> 
> program crashed: BUG: unable to handle kernel paging request in
> efivarfs_pm_notify
> 
> preceding the other log output regarding the locks, so the deadlock
> might be a symptom of another problem.

This:
        struct path path = { .mnt = NULL, .dentry = sfi->sb->s_root, };

_What_ .mnt = NULL?  That's already a bug.  There is no such thing
as mountless open file; how would the kernel know not to shut the
damn thing down right under you?

      parent reply	other threads:[~2025-03-10 23:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-09  2:52 [syzbot] [efi?] [fs?] possible deadlock in efivarfs_actor syzbot
2025-03-09  9:21 ` Hillf Danton
2025-03-09  9:51   ` syzbot
2025-03-10  7:21 ` Ard Biesheuvel
2025-03-10 16:50 ` James Bottomley
2025-03-10 18:21   ` Ard Biesheuvel
2025-03-10 18:24     ` Ard Biesheuvel
2025-03-10 23:25       ` Al Viro
2025-03-10 23:58     ` Al Viro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250310235831.GL2023217@ZenIV \
    --to=viro@zeniv.linux.org.uk \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=ardb@kernel.org \
    --cc=jk@ozlabs.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+019072ad24ab1d948228@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.