[rppt:kho/v5 11/14] kernel/kexec_handover.c:386:9: warning: variable 'err' is uninitialized when used here

[rppt:kho/v5 11/14] kernel/kexec_handover.c:386:9: warning: variable 'err' is uninitialized when used here

[kernel test robot]

Hi Alexander,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rppt/linux.git kho/v5
head:   d5a7d2cfaba824b4c5af065e4a88b5d5676ce370
commit: 4381c43cfcbab7c3822ade60ab9547007ea1bbcf [11/14] arm64: Add KHO support
config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20250312/202503121551.InIOkfiZ-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250312/202503121551.InIOkfiZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503121551.InIOkfiZ-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> kernel/kexec_handover.c:386:9: warning: variable 'err' is uninitialized when used here [-Wuninitialized]
     386 |         return err;
         |                ^~~
   kernel/kexec_handover.c:370:9: note: initialize the variable 'err' to silence this warning
     370 |         int err;
         |                ^
         |                 = 0
   1 warning generated.
--
>> kernel/kexec_handover.c:798: warning: Function parameter or struct member 'size' not described in 'kho_preserve_phys'


vim +/err +386 kernel/kexec_handover.c

6d6f81c097d286f Alexander Graf 2024-01-17  365  
fab9bce0dd59678 Alexander Graf 2024-01-17  366  /* Handling for debugfs/kho/in */
fab9bce0dd59678 Alexander Graf 2024-01-17  367  static __init int kho_in_debugfs_init(const void *fdt)
fab9bce0dd59678 Alexander Graf 2024-01-17  368  {
fab9bce0dd59678 Alexander Graf 2024-01-17  369  	struct dentry *file;
fab9bce0dd59678 Alexander Graf 2024-01-17  370  	int err;
fab9bce0dd59678 Alexander Graf 2024-01-17  371  
fab9bce0dd59678 Alexander Graf 2024-01-17  372  	kho_in.dir = debugfs_create_dir("in", debugfs_root);
fab9bce0dd59678 Alexander Graf 2024-01-17  373  	if (!kho_in.dir)
fab9bce0dd59678 Alexander Graf 2024-01-17  374  		return -ENOMEM;
fab9bce0dd59678 Alexander Graf 2024-01-17  375  
fab9bce0dd59678 Alexander Graf 2024-01-17  376  	kho_in.fdt.size = fdt_totalsize(fdt);
fab9bce0dd59678 Alexander Graf 2024-01-17  377  	kho_in.fdt.data = (void *)fdt;
fab9bce0dd59678 Alexander Graf 2024-01-17  378  	file = debugfs_create_blob("fdt", 0400, kho_in.dir, &kho_in.fdt);
fab9bce0dd59678 Alexander Graf 2024-01-17  379  	if (!file)
fab9bce0dd59678 Alexander Graf 2024-01-17  380  		goto err_rmdir;
fab9bce0dd59678 Alexander Graf 2024-01-17  381  
fab9bce0dd59678 Alexander Graf 2024-01-17  382  	return 0;
fab9bce0dd59678 Alexander Graf 2024-01-17  383  
fab9bce0dd59678 Alexander Graf 2024-01-17  384  err_rmdir:
fab9bce0dd59678 Alexander Graf 2024-01-17  385  	debugfs_remove(kho_in.dir);
fab9bce0dd59678 Alexander Graf 2024-01-17 @386  	return err;
fab9bce0dd59678 Alexander Graf 2024-01-17  387  }
fab9bce0dd59678 Alexander Graf 2024-01-17  388  

:::::: The code at line 386 was first introduced by commit
:::::: fab9bce0dd59678d69807e8ee4864ce8af2f2d42 kexec: Add KHO parsing support

:::::: TO: Alexander Graf <graf@amazon.com>
:::::: CC: Mike Rapoport (Microsoft) <rppt@kernel.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki