* [PATCH] phy: qcom: uniphy-28lp: add COMMON_CLK dependency
@ 2025-03-14 15:49 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2025-03-14 15:49 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Nitheesh Sekar,
Dmitry Baryshkov, Varadarajan Narayanan
Cc: Arnd Bergmann, linux-arm-msm, linux-phy, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
In configurations without CONFIG_COMMON_CLK, the driver fails to build:
aarch64-linux-ld: drivers/phy/qualcomm/phy-qcom-uniphy-pcie-28lp.o: in function `qcom_uniphy_pcie_probe':
phy-qcom-uniphy-pcie-28lp.c:(.text+0x200): undefined reference to `__clk_hw_register_fixed_rate'
aarch64-linux-ld: phy-qcom-uniphy-pcie-28lp.c:(.text+0x238): undefined reference to `of_clk_hw_simple_get'
phy-qcom-uniphy-pcie-28lp.c:(.text+0x238): dangerous relocation: unsupported relocation
aarch64-linux-ld: phy-qcom-uniphy-pcie-28lp.c:(.text+0x240): undefined reference to `of_clk_hw_simple_get'
aarch64-linux-ld: phy-qcom-uniphy-pcie-28lp.c:(.text+0x248): undefined reference to `devm_of_clk_add_hw_provider'
Add that as a Kconfig dependencies.
Fixes: 74badb8b0b14 ("phy: qcom: Introduce PCIe UNIPHY 28LP driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/phy/qualcomm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/qualcomm/Kconfig b/drivers/phy/qualcomm/Kconfig
index a6b71fda1b9c..c1e0a11ddd76 100644
--- a/drivers/phy/qualcomm/Kconfig
+++ b/drivers/phy/qualcomm/Kconfig
@@ -157,6 +157,7 @@ config PHY_QCOM_M31_USB
config PHY_QCOM_UNIPHY_PCIE_28LP
bool "PCIE UNIPHY 28LP PHY driver"
depends on ARCH_QCOM
+ depends on COMMON_CLK
depends on HAS_IOMEM
depends on OF
select GENERIC_PHY
--
2.39.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] phy: qcom: uniphy-28lp: add COMMON_CLK dependency
@ 2025-03-14 15:49 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2025-03-14 15:49 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Nitheesh Sekar,
Dmitry Baryshkov, Varadarajan Narayanan
Cc: Arnd Bergmann, linux-arm-msm, linux-phy, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
In configurations without CONFIG_COMMON_CLK, the driver fails to build:
aarch64-linux-ld: drivers/phy/qualcomm/phy-qcom-uniphy-pcie-28lp.o: in function `qcom_uniphy_pcie_probe':
phy-qcom-uniphy-pcie-28lp.c:(.text+0x200): undefined reference to `__clk_hw_register_fixed_rate'
aarch64-linux-ld: phy-qcom-uniphy-pcie-28lp.c:(.text+0x238): undefined reference to `of_clk_hw_simple_get'
phy-qcom-uniphy-pcie-28lp.c:(.text+0x238): dangerous relocation: unsupported relocation
aarch64-linux-ld: phy-qcom-uniphy-pcie-28lp.c:(.text+0x240): undefined reference to `of_clk_hw_simple_get'
aarch64-linux-ld: phy-qcom-uniphy-pcie-28lp.c:(.text+0x248): undefined reference to `devm_of_clk_add_hw_provider'
Add that as a Kconfig dependencies.
Fixes: 74badb8b0b14 ("phy: qcom: Introduce PCIe UNIPHY 28LP driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/phy/qualcomm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/qualcomm/Kconfig b/drivers/phy/qualcomm/Kconfig
index a6b71fda1b9c..c1e0a11ddd76 100644
--- a/drivers/phy/qualcomm/Kconfig
+++ b/drivers/phy/qualcomm/Kconfig
@@ -157,6 +157,7 @@ config PHY_QCOM_M31_USB
config PHY_QCOM_UNIPHY_PCIE_28LP
bool "PCIE UNIPHY 28LP PHY driver"
depends on ARCH_QCOM
+ depends on COMMON_CLK
depends on HAS_IOMEM
depends on OF
select GENERIC_PHY
--
2.39.5
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] phy: qcom: uniphy-28lp: add COMMON_CLK dependency
2025-03-14 15:49 ` Arnd Bergmann
@ 2025-03-14 16:31 ` Dmitry Baryshkov
-1 siblings, 0 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2025-03-14 16:31 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Vinod Koul, Kishon Vijay Abraham I, Nitheesh Sekar,
Dmitry Baryshkov, Varadarajan Narayanan, Arnd Bergmann,
linux-arm-msm, linux-phy, linux-kernel
On Fri, Mar 14, 2025 at 04:49:10PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> In configurations without CONFIG_COMMON_CLK, the driver fails to build:
>
> aarch64-linux-ld: drivers/phy/qualcomm/phy-qcom-uniphy-pcie-28lp.o: in function `qcom_uniphy_pcie_probe':
> phy-qcom-uniphy-pcie-28lp.c:(.text+0x200): undefined reference to `__clk_hw_register_fixed_rate'
> aarch64-linux-ld: phy-qcom-uniphy-pcie-28lp.c:(.text+0x238): undefined reference to `of_clk_hw_simple_get'
> phy-qcom-uniphy-pcie-28lp.c:(.text+0x238): dangerous relocation: unsupported relocation
> aarch64-linux-ld: phy-qcom-uniphy-pcie-28lp.c:(.text+0x240): undefined reference to `of_clk_hw_simple_get'
> aarch64-linux-ld: phy-qcom-uniphy-pcie-28lp.c:(.text+0x248): undefined reference to `devm_of_clk_add_hw_provider'
>
> Add that as a Kconfig dependencies.
>
> Fixes: 74badb8b0b14 ("phy: qcom: Introduce PCIe UNIPHY 28LP driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/phy/qualcomm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] phy: qcom: uniphy-28lp: add COMMON_CLK dependency
@ 2025-03-14 16:31 ` Dmitry Baryshkov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2025-03-14 16:31 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Vinod Koul, Kishon Vijay Abraham I, Nitheesh Sekar,
Dmitry Baryshkov, Varadarajan Narayanan, Arnd Bergmann,
linux-arm-msm, linux-phy, linux-kernel
On Fri, Mar 14, 2025 at 04:49:10PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> In configurations without CONFIG_COMMON_CLK, the driver fails to build:
>
> aarch64-linux-ld: drivers/phy/qualcomm/phy-qcom-uniphy-pcie-28lp.o: in function `qcom_uniphy_pcie_probe':
> phy-qcom-uniphy-pcie-28lp.c:(.text+0x200): undefined reference to `__clk_hw_register_fixed_rate'
> aarch64-linux-ld: phy-qcom-uniphy-pcie-28lp.c:(.text+0x238): undefined reference to `of_clk_hw_simple_get'
> phy-qcom-uniphy-pcie-28lp.c:(.text+0x238): dangerous relocation: unsupported relocation
> aarch64-linux-ld: phy-qcom-uniphy-pcie-28lp.c:(.text+0x240): undefined reference to `of_clk_hw_simple_get'
> aarch64-linux-ld: phy-qcom-uniphy-pcie-28lp.c:(.text+0x248): undefined reference to `devm_of_clk_add_hw_provider'
>
> Add that as a Kconfig dependencies.
>
> Fixes: 74badb8b0b14 ("phy: qcom: Introduce PCIe UNIPHY 28LP driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/phy/qualcomm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] phy: qcom: uniphy-28lp: add COMMON_CLK dependency
2025-03-14 15:49 ` Arnd Bergmann
@ 2025-03-16 17:19 ` Vinod Koul
-1 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2025-03-16 17:19 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Nitheesh Sekar, Dmitry Baryshkov,
Varadarajan Narayanan, Arnd Bergmann
Cc: Arnd Bergmann, linux-arm-msm, linux-phy, linux-kernel
On Fri, 14 Mar 2025 16:49:10 +0100, Arnd Bergmann wrote:
> In configurations without CONFIG_COMMON_CLK, the driver fails to build:
>
> aarch64-linux-ld: drivers/phy/qualcomm/phy-qcom-uniphy-pcie-28lp.o: in function `qcom_uniphy_pcie_probe':
> phy-qcom-uniphy-pcie-28lp.c:(.text+0x200): undefined reference to `__clk_hw_register_fixed_rate'
> aarch64-linux-ld: phy-qcom-uniphy-pcie-28lp.c:(.text+0x238): undefined reference to `of_clk_hw_simple_get'
> phy-qcom-uniphy-pcie-28lp.c:(.text+0x238): dangerous relocation: unsupported relocation
> aarch64-linux-ld: phy-qcom-uniphy-pcie-28lp.c:(.text+0x240): undefined reference to `of_clk_hw_simple_get'
> aarch64-linux-ld: phy-qcom-uniphy-pcie-28lp.c:(.text+0x248): undefined reference to `devm_of_clk_add_hw_provider'
>
> [...]
Applied, thanks!
[1/1] phy: qcom: uniphy-28lp: add COMMON_CLK dependency
commit: be8f23cebdb9546beb30ad15ff59130b66c8f2ac
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] phy: qcom: uniphy-28lp: add COMMON_CLK dependency
@ 2025-03-16 17:19 ` Vinod Koul
0 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2025-03-16 17:19 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Nitheesh Sekar, Dmitry Baryshkov,
Varadarajan Narayanan, Arnd Bergmann
Cc: Arnd Bergmann, linux-arm-msm, linux-phy, linux-kernel
On Fri, 14 Mar 2025 16:49:10 +0100, Arnd Bergmann wrote:
> In configurations without CONFIG_COMMON_CLK, the driver fails to build:
>
> aarch64-linux-ld: drivers/phy/qualcomm/phy-qcom-uniphy-pcie-28lp.o: in function `qcom_uniphy_pcie_probe':
> phy-qcom-uniphy-pcie-28lp.c:(.text+0x200): undefined reference to `__clk_hw_register_fixed_rate'
> aarch64-linux-ld: phy-qcom-uniphy-pcie-28lp.c:(.text+0x238): undefined reference to `of_clk_hw_simple_get'
> phy-qcom-uniphy-pcie-28lp.c:(.text+0x238): dangerous relocation: unsupported relocation
> aarch64-linux-ld: phy-qcom-uniphy-pcie-28lp.c:(.text+0x240): undefined reference to `of_clk_hw_simple_get'
> aarch64-linux-ld: phy-qcom-uniphy-pcie-28lp.c:(.text+0x248): undefined reference to `devm_of_clk_add_hw_provider'
>
> [...]
Applied, thanks!
[1/1] phy: qcom: uniphy-28lp: add COMMON_CLK dependency
commit: be8f23cebdb9546beb30ad15ff59130b66c8f2ac
Best regards,
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-03-16 17:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-14 15:49 [PATCH] phy: qcom: uniphy-28lp: add COMMON_CLK dependency Arnd Bergmann
2025-03-14 15:49 ` Arnd Bergmann
2025-03-14 16:31 ` Dmitry Baryshkov
2025-03-14 16:31 ` Dmitry Baryshkov
2025-03-16 17:19 ` Vinod Koul
2025-03-16 17:19 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.