[meta-arago][scarthgap/master][PATCH] packagegroup-arago-tisdk-graphics : Add ti-gc320-libs-dev package

[meta-arago][scarthgap/master][PATCH] packagegroup-arago-tisdk-graphics : Add ti-gc320-libs-dev package

[a-christidis]

From: Antonios Christidis <a-christidis@ti.com>

Reformat the packagegroup, by creating the GFX_GC320 variable which now
includes ti-gc320-tests and the ti-gc320-libs-dev package. This is needed as
the -dev package includes the symb link for the library.

This patch goes hand in hand with a patch series sent to meta-ti porting gc320
to kernel 6.12 .

Signed-off-by: Antonios Christidis <a-christidis@ti.com>
---
 .../packagegroups/packagegroup-arago-tisdk-graphics.bb    | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb
index a82db154..60806446 100644
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb
@@ -16,11 +16,17 @@ GFX_UTILS:append:omap-a15  = "\
     glsdk-util-scripts \
 "
 
+GFX_GC320 = "\
+    ti-gc320-libs-dev\
+    ti-gc320-tests\
+"
+    
+
 RDEPENDS:${PN} = "\
     libegl \
     glmark2 \
     kmscube \
-    ${@bb.utils.contains('MACHINE_FEATURES', 'gc320', 'ti-gc320-tests', '', d)} \
+    ${@bb.utils.contains('MACHINE_FEATURES', 'gc320', "${GFX_GC320}", '', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', "${GFX_WAYLAND}", '', d)} \
     ${GFX_UTILS} \
 "
-- 
2.34.1

Re: [meta-arago][scarthgap/master][PATCH] packagegroup-arago-tisdk-graphics : Add ti-gc320-libs-dev package

[Andrew Davis]

On 3/5/25 10:16 AM, Antonios Christidis via lists.yoctoproject.org wrote:
> From: Antonios Christidis <a-christidis@ti.com>
> 
> Reformat the packagegroup, by creating the GFX_GC320 variable which now
> includes ti-gc320-tests and the ti-gc320-libs-dev package. This is needed as
> the -dev package includes the symb link for the library.
> 
> This patch goes hand in hand with a patch series sent to meta-ti porting gc320
> to kernel 6.12 .
> 
> Signed-off-by: Antonios Christidis <a-christidis@ti.com>
> ---
>   .../packagegroups/packagegroup-arago-tisdk-graphics.bb    | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb
> index a82db154..60806446 100644
> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb
> @@ -16,11 +16,17 @@ GFX_UTILS:append:omap-a15  = "\
>       glsdk-util-scripts \
>   "
>   
> +GFX_GC320 = "\
> +    ti-gc320-libs-dev\

Do you really need this? The -dev package will be pulled into
the sysroot for any package that DEPENDS on the library.

> +    ti-gc320-tests\
> +"
> +
> +

Extra newline?

>   RDEPENDS:${PN} = "\
>       libegl \
>       glmark2 \
>       kmscube \
> -    ${@bb.utils.contains('MACHINE_FEATURES', 'gc320', 'ti-gc320-tests', '', d)} \
> +    ${@bb.utils.contains('MACHINE_FEATURES', 'gc320', "${GFX_GC320}", '', d)} \

Is there some test package that depends on ti-gc320-tests, maybe ltp-ddt?
If so then this should be a RDEPENDS in that package instead.

Andrew

>       ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', "${GFX_WAYLAND}", '', d)} \
>       ${GFX_UTILS} \
>   "

Re: [meta-arago][scarthgap/master][PATCH] packagegroup-arago-tisdk-graphics : Add ti-gc320-libs-dev package

[Antonios Christidis]

On 3/5/25 12:32 PM, Andrew Davis wrote:
> On 3/5/25 10:16 AM, Antonios Christidis via lists.yoctoproject.org wrote:
>> From: Antonios Christidis <a-christidis@ti.com>
>>
>> Reformat the packagegroup, by creating the GFX_GC320 variable which now
>> includes ti-gc320-tests and the ti-gc320-libs-dev package. This is 
>> needed as
>> the -dev package includes the symb link for the library.
>>
>> This patch goes hand in hand with a patch series sent to meta-ti 
>> porting gc320
>> to kernel 6.12 .
>>
>> Signed-off-by: Antonios Christidis <a-christidis@ti.com>
>> ---
>>   .../packagegroups/packagegroup-arago-tisdk-graphics.bb    | 8 +++++++-
>>   1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git 
>> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb 
>> b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb 
>>
>> index a82db154..60806446 100644
>> --- 
>> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb
>> +++ 
>> b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb
>> @@ -16,11 +16,17 @@ GFX_UTILS:append:omap-a15  = "\
>>       glsdk-util-scripts \
>>   "
>>   +GFX_GC320 = "\
>> +    ti-gc320-libs-dev\
>
> Do you really need this? The -dev package will be pulled into
> the sysroot for any package that DEPENDS on the library.
>
Good point, the only package that needs libs-dev is ti-gc320-tests, I'll 
update that recipe RRDEPENDS instead of going this route.

>> +    ti-gc320-tests\
>> +"
>> +
>> +
>
> Extra newline?

I'll fix this.

>
>>   RDEPENDS:${PN} = "\
>>       libegl \
>>       glmark2 \
>>       kmscube \
>> -    ${@bb.utils.contains('MACHINE_FEATURES', 'gc320', 
>> 'ti-gc320-tests', '', d)} \
>> +    ${@bb.utils.contains('MACHINE_FEATURES', 'gc320', 
>> "${GFX_GC320}", '', d)} \
>
> Is there some test package that depends on ti-gc320-tests, maybe ltp-ddt?
> If so then this should be a RDEPENDS in that package instead.
>
There's no package that depends on it.
> Andrew
>
>> ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', "${GFX_WAYLAND}", 
>> '', d)} \
>>       ${GFX_UTILS} \
>>   "

Re: [meta-arago][scarthgap/master][PATCH] packagegroup-arago-tisdk-graphics : Add ti-gc320-libs-dev package

[Antonios Christidis]

Ryan reject this patch, I'm sending a new patch that will edit the 
ti-gc320-tests recipe that will achieve the same thing.

On 3/5/25 1:22 PM, Antonios Christidis wrote:
>
> On 3/5/25 12:32 PM, Andrew Davis wrote:
>> On 3/5/25 10:16 AM, Antonios Christidis via lists.yoctoproject.org 
>> wrote:
>>> From: Antonios Christidis <a-christidis@ti.com>
>>>
>>> Reformat the packagegroup, by creating the GFX_GC320 variable which now
>>> includes ti-gc320-tests and the ti-gc320-libs-dev package. This is 
>>> needed as
>>> the -dev package includes the symb link for the library.
>>>
>>> This patch goes hand in hand with a patch series sent to meta-ti 
>>> porting gc320
>>> to kernel 6.12 .
>>>
>>> Signed-off-by: Antonios Christidis <a-christidis@ti.com>
>>> ---
>>>   .../packagegroups/packagegroup-arago-tisdk-graphics.bb    | 8 
>>> +++++++-
>>>   1 file changed, 7 insertions(+), 1 deletion(-)
>>>
>>> diff --git 
>>> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb 
>>> b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb 
>>>
>>> index a82db154..60806446 100644
>>> --- 
>>> a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb
>>> +++ 
>>> b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb
>>> @@ -16,11 +16,17 @@ GFX_UTILS:append:omap-a15  = "\
>>>       glsdk-util-scripts \
>>>   "
>>>   +GFX_GC320 = "\
>>> +    ti-gc320-libs-dev\
>>
>> Do you really need this? The -dev package will be pulled into
>> the sysroot for any package that DEPENDS on the library.
>>
> Good point, the only package that needs libs-dev is ti-gc320-tests, 
> I'll update that recipe RRDEPENDS instead of going this route.
>
>>> +    ti-gc320-tests\
>>> +"
>>> +
>>> +
>>
>> Extra newline?
>
> I'll fix this.
>
>>
>>>   RDEPENDS:${PN} = "\
>>>       libegl \
>>>       glmark2 \
>>>       kmscube \
>>> -    ${@bb.utils.contains('MACHINE_FEATURES', 'gc320', 
>>> 'ti-gc320-tests', '', d)} \
>>> +    ${@bb.utils.contains('MACHINE_FEATURES', 'gc320', 
>>> "${GFX_GC320}", '', d)} \
>>
>> Is there some test package that depends on ti-gc320-tests, maybe 
>> ltp-ddt?
>> If so then this should be a RDEPENDS in that package instead.
>>
> There's no package that depends on it.
>> Andrew
>>
>>> ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', "${GFX_WAYLAND}", 
>>> '', d)} \
>>>       ${GFX_UTILS} \
>>>   "

Re: [meta-arago][scarthgap/master][PATCH] packagegroup-arago-tisdk-graphics : Add ti-gc320-libs-dev package

[Denys Dmytriyenko]

On Wed, Mar 05, 2025 at 04:31:17PM -0600, Antonios Christidis via lists.yoctoproject.org wrote:
> Ryan reject this patch, I'm sending a new patch that will edit the
> ti-gc320-tests recipe that will achieve the same thing.

Ryan,

I see this on master-wip, while it was requested to be rejected. Thanks.


> On 3/5/25 1:22 PM, Antonios Christidis wrote:
> >
> >On 3/5/25 12:32 PM, Andrew Davis wrote:
> >>On 3/5/25 10:16 AM, Antonios Christidis via
> >>lists.yoctoproject.org wrote:
> >>>From: Antonios Christidis <a-christidis@ti.com>
> >>>
> >>>Reformat the packagegroup, by creating the GFX_GC320 variable which now
> >>>includes ti-gc320-tests and the ti-gc320-libs-dev package.
> >>>This is needed as
> >>>the -dev package includes the symb link for the library.
> >>>
> >>>This patch goes hand in hand with a patch series sent to
> >>>meta-ti porting gc320
> >>>to kernel 6.12 .
> >>>
> >>>Signed-off-by: Antonios Christidis <a-christidis@ti.com>
> >>>---
> >>>  .../packagegroups/packagegroup-arago-tisdk-graphics.bb    |
> >>>8 +++++++-
> >>>  1 file changed, 7 insertions(+), 1 deletion(-)
> >>>
> >>>diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb
> >>>
> >>>index a82db154..60806446 100644
> >>>--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb
> >>>+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics.bb
> >>>@@ -16,11 +16,17 @@ GFX_UTILS:append:omap-a15  = "\
> >>>      glsdk-util-scripts \
> >>>  "
> >>>  +GFX_GC320 = "\
> >>>+    ti-gc320-libs-dev\
> >>
> >>Do you really need this? The -dev package will be pulled into
> >>the sysroot for any package that DEPENDS on the library.
> >>
> >Good point, the only package that needs libs-dev is
> >ti-gc320-tests, I'll update that recipe RRDEPENDS instead of going
> >this route.
> >
> >>>+    ti-gc320-tests\
> >>>+"
> >>>+
> >>>+
> >>
> >>Extra newline?
> >
> >I'll fix this.
> >
> >>
> >>>  RDEPENDS:${PN} = "\
> >>>      libegl \
> >>>      glmark2 \
> >>>      kmscube \
> >>>-    ${@bb.utils.contains('MACHINE_FEATURES', 'gc320',
> >>>'ti-gc320-tests', '', d)} \
> >>>+    ${@bb.utils.contains('MACHINE_FEATURES', 'gc320',
> >>>"${GFX_GC320}", '', d)} \
> >>
> >>Is there some test package that depends on ti-gc320-tests, maybe
> >>ltp-ddt?
> >>If so then this should be a RDEPENDS in that package instead.
> >>
> >There's no package that depends on it.
> >>Andrew
> >>
> >>>${@bb.utils.contains('DISTRO_FEATURES', 'wayland',
> >>>"${GFX_WAYLAND}", '', d)} \
> >>>      ${GFX_UTILS} \
> >>>  "