From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: Qu Wenruo <quwenruo.btrfs@gmx.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/7] btrfs: send: remove the again label inside put_file_data()
Date: Sat, 15 Mar 2025 00:38:13 +0100 [thread overview]
Message-ID: <20250314233813.GU32661@suse.cz> (raw)
In-Reply-To: <eb9c52ec-a902-4750-9b1f-3d0a2fea963e@suse.com>
On Sat, Mar 15, 2025 at 09:55:31AM +1030, Qu Wenruo wrote:
>
>
> 在 2025/3/15 09:28, David Sterba 写道:
> > On Sat, Mar 15, 2025 at 08:20:43AM +1030, Qu Wenruo wrote:
> >> 在 2025/3/15 03:22, David Sterba 写道:
> >>> On Thu, Mar 13, 2025 at 02:50:43PM +1030, Qu Wenruo wrote:
> >>>> The again label is not really necessary and can be replaced by a simple
> >>>> continue.
> >>>
> >>> This should also say why it's needed.
> >>
> >> Do you mean why we need to continue, or why the old label was needed?
> >
> > Something about that old and new code is equivalent and what implies
> > that (no changes in the variables). Changes in the control flow could
> > change invariants.
>
> I thought all developers here should understand what "continue" keyword
> does.
>
> Do you really want me to copy the official definition of "continue"
> keyword here as a commit message?
Do you really think this is my point and that I need this kind of
information? Or that I'm asking to give a brief explanation 'why the
change is ok', the changelog only says 'what' the code does.
next prev parent reply other threads:[~2025-03-14 23:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 4:20 [PATCH 0/7] btrfs: remove ASSERT()s for folio_order() and folio_test_large() Qu Wenruo
2025-03-13 4:20 ` [PATCH 1/7] btrfs: send: remove the again label inside put_file_data() Qu Wenruo
2025-03-14 16:52 ` David Sterba
2025-03-14 21:50 ` Qu Wenruo
2025-03-14 22:58 ` David Sterba
2025-03-14 23:25 ` Qu Wenruo
2025-03-14 23:38 ` David Sterba [this message]
2025-03-13 4:20 ` [PATCH 2/7] btrfs: send: prepare put_file_data() for larger data folios Qu Wenruo
2025-03-13 4:20 ` [PATCH 3/7] btrfs: prepare btrfs_page_mkwrite() " Qu Wenruo
2025-03-13 4:20 ` [PATCH 4/7] btrfs: prepare prepare_one_folio() " Qu Wenruo
2025-03-13 4:20 ` [PATCH 5/7] btrfs: prepare end_bbio_data_write() " Qu Wenruo
2025-03-13 4:20 ` [PATCH 6/7] btrfs: subpage: prepare " Qu Wenruo
2025-03-13 4:20 ` [PATCH 7/7] btrfs: zlib: prepare copy_data_into_buffer() " Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250314233813.GU32661@suse.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.