Re: [PATCH 1/7] btrfs: send: remove the again label inside put_file_data()

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

在 2025/3/15 03:22, David Sterba 写道:
> On Thu, Mar 13, 2025 at 02:50:43PM +1030, Qu Wenruo wrote:
>> The again label is not really necessary and can be replaced by a simple
>> continue.
>
> This should also say why it's needed.

Do you mean why we need to continue, or why the old label was needed?

Thanks,
Qu

>
>>
>> Signed-off-by: Qu Wenruo <wqu@suse.com>
>> ---
>>   fs/btrfs/send.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
>> index 0c8c58c4f29b..43c29295f477 100644
>> --- a/fs/btrfs/send.c
>> +++ b/fs/btrfs/send.c
>> @@ -5280,7 +5280,6 @@ static int put_file_data(struct send_ctx *sctx, u64 offset, u32 len)
>>   		unsigned cur_len = min_t(unsigned, len,
>>   					 PAGE_SIZE - pg_offset);
>>
>> -again:
>>   		folio = filemap_lock_folio(mapping, index);
>>   		if (IS_ERR(folio)) {
>>   			page_cache_sync_readahead(mapping,
>> @@ -5316,7 +5315,7 @@ static int put_file_data(struct send_ctx *sctx, u64 offset, u32 len)
>>   			if (folio->mapping != mapping) {
>>   				folio_unlock(folio);
>>   				folio_put(folio);
>> -				goto again;
>> +				continue;
>>   			}
>>   		}
>>
>> --
>> 2.48.1
>>
>