All of lore.kernel.org
 help / color / mirror / Atom feed
* [merged mm-stable] selftests-mm-skip-mlock-tests-if-nobody-user-cant-read-it.patch removed from -mm tree
@ 2025-03-17  5:14 Andrew Morton
  0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2025-03-17  5:14 UTC (permalink / raw)
  To: mm-commits, shuah, mjguzik, lorenzo.stoakes, dev.jain, jackmanb,
	akpm


The quilt patch titled
     Subject: selftests/mm: skip mlock tests if nobody user can't read it
has been removed from the -mm tree.  Its filename was
     selftests-mm-skip-mlock-tests-if-nobody-user-cant-read-it.patch

This patch was dropped because it was merged into the mm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Brendan Jackman <jackmanb@google.com>
Subject: selftests/mm: skip mlock tests if nobody user can't read it
Date: Tue, 11 Mar 2025 13:18:22 +0000

If running from a directory that can't be read by unprivileged users,
executing on-fault-test via the nobody user will fail.

The kselftest build does give the file the correct permissions, but after
being installed it might be in a directory without global execute
permissions.

Since the script can't safely fix that, just skip if it happens.  Note
that the stderr of the `ls` command is unfiltered meaning the user sees a
"permission denied" error that can help inform them why the test was
skipped.

Link: https://lkml.kernel.org/r/20250311-mm-selftests-v4-11-dec210a658f5@google.com
Signed-off-by: Brendan Jackman <jackmanb@google.com>
Cc: Dev Jain <dev.jain@arm.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Mateusz Guzik <mjguzik@gmail.com>
Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 tools/testing/selftests/mm/run_vmtests.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/tools/testing/selftests/mm/run_vmtests.sh~selftests-mm-skip-mlock-tests-if-nobody-user-cant-read-it
+++ a/tools/testing/selftests/mm/run_vmtests.sh
@@ -353,7 +353,7 @@ echo "$nr_hugepgs" > /proc/sys/vm/nr_hug
 
 CATEGORY="compaction" run_test ./compaction_test
 
-if command -v sudo &> /dev/null;
+if command -v sudo &> /dev/null && sudo -u nobody ls ./on-fault-limit >/dev/null;
 then
 	CATEGORY="mlock" run_test sudo -u nobody ./on-fault-limit
 else
_

Patches currently in -mm which might be from jackmanb@google.com are

scripts-gdb-add-lx_per_cpu_ptr.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-03-17  5:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-17  5:14 [merged mm-stable] selftests-mm-skip-mlock-tests-if-nobody-user-cant-read-it.patch removed from -mm tree Andrew Morton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.