From: Simon Horman <horms@kernel.org>
To: Grzegorz Nitka <grzegorz.nitka@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Karol Kolacinski <karol.kolacinski@intel.com>,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 1/3] ice: remove SW side band access workaround for E825
Date: Mon, 17 Mar 2025 16:36:07 +0000 [thread overview]
Message-ID: <20250317163607.GD688833@kernel.org> (raw)
In-Reply-To: <20250310122439.3327908-2-grzegorz.nitka@intel.com>
On Mon, Mar 10, 2025 at 01:24:37PM +0100, Grzegorz Nitka wrote:
> From: Karol Kolacinski <karol.kolacinski@intel.com>
>
> Due to the bug in FW/NVM autoload mechanism (wrong default
> SB_REM_DEV_CTL register settings), the access to peer PHY and CGU
> clients was disabled by default.
>
> As the workaround solution, the register value was overwritten by the
> driver at the probe or reset handling.
> Remove workaround as it's not needed anymore. The fix in autoload
> procedure has been provided with NVM 3.80 version.
Hi Grzegorz,
As per my belated comment on v2 [*], I think it would be worth adding
a brief comment here regarding this not being expected to cause
a regression in HW+FW seen in the wild.
[*] https://lore.kernel.org/netdev/20250317163359.GC688833@kernel.org/
>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>
> Signed-off-by: Grzegorz Nitka <grzegorz.nitka@intel.com>
...
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Grzegorz Nitka <grzegorz.nitka@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Karol Kolacinski <karol.kolacinski@intel.com>,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH iwl-next v2 1/3] ice: remove SW side band access workaround for E825
Date: Mon, 17 Mar 2025 16:36:07 +0000 [thread overview]
Message-ID: <20250317163607.GD688833@kernel.org> (raw)
In-Reply-To: <20250310122439.3327908-2-grzegorz.nitka@intel.com>
On Mon, Mar 10, 2025 at 01:24:37PM +0100, Grzegorz Nitka wrote:
> From: Karol Kolacinski <karol.kolacinski@intel.com>
>
> Due to the bug in FW/NVM autoload mechanism (wrong default
> SB_REM_DEV_CTL register settings), the access to peer PHY and CGU
> clients was disabled by default.
>
> As the workaround solution, the register value was overwritten by the
> driver at the probe or reset handling.
> Remove workaround as it's not needed anymore. The fix in autoload
> procedure has been provided with NVM 3.80 version.
Hi Grzegorz,
As per my belated comment on v2 [*], I think it would be worth adding
a brief comment here regarding this not being expected to cause
a regression in HW+FW seen in the wild.
[*] https://lore.kernel.org/netdev/20250317163359.GC688833@kernel.org/
>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>
> Signed-off-by: Grzegorz Nitka <grzegorz.nitka@intel.com>
...
next prev parent reply other threads:[~2025-03-17 16:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 12:24 [Intel-wired-lan] [PATCH iwl-next v2 0/3] E825C timesync dual NAC support Grzegorz Nitka
2025-03-10 12:24 ` Grzegorz Nitka
2025-03-10 12:24 ` [Intel-wired-lan] [PATCH iwl-next v2 1/3] ice: remove SW side band access workaround for E825 Grzegorz Nitka
2025-03-10 12:24 ` Grzegorz Nitka
2025-03-17 16:36 ` Simon Horman [this message]
2025-03-17 16:36 ` Simon Horman
2025-03-18 14:00 ` [Intel-wired-lan] " Nitka, Grzegorz
2025-03-18 14:00 ` Nitka, Grzegorz
2025-03-10 12:24 ` [Intel-wired-lan] [PATCH iwl-next v2 2/3] ice: refactor ice_sbq_msg_dev enum Grzegorz Nitka
2025-03-10 12:24 ` Grzegorz Nitka
2025-03-10 12:24 ` [Intel-wired-lan] [PATCH iwl-next v2 3/3] ice: enable timesync operation on 2xNAC E825 devices Grzegorz Nitka
2025-03-10 12:24 ` Grzegorz Nitka
2025-03-17 16:36 ` [Intel-wired-lan] " Simon Horman
2025-03-17 16:36 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250317163607.GD688833@kernel.org \
--to=horms@kernel.org \
--cc=grzegorz.nitka@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=karol.kolacinski@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.