[efi:urgent 10/10] fs/efivarfs/super.c:424:27: error: use of undeclared identifier 'INODE_CHILD'

[efi:urgent 10/10] fs/efivarfs/super.c:424:27: error: use of undeclared identifier 'INODE_CHILD'

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git urgent
head:   2379221e8c43a4be62811f4d8a71cfffc23df5b0
commit: 2379221e8c43a4be62811f4d8a71cfffc23df5b0 [10/10] efivarfs: use INODE_CHILD nested lock to traverse variables on resume
config: arm-randconfig-004-20250317 (https://download.01.org/0day-ci/archive/20250317/202503171938.8Qee3VKa-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 87916f8c32ebd8e284091db9b70339df57fd1e90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250317/202503171938.8Qee3VKa-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503171938.8Qee3VKa-lkp@intel.com/

All errors (new ones prefixed by >>):

>> fs/efivarfs/super.c:424:27: error: use of undeclared identifier 'INODE_CHILD'
     424 |         inode_lock_nested(inode, INODE_CHILD);
         |                                  ^
   1 error generated.


vim +/INODE_CHILD +424 fs/efivarfs/super.c

   401	
   402	static bool efivarfs_actor(struct dir_context *ctx, const char *name, int len,
   403				   loff_t offset, u64 ino, unsigned mode)
   404	{
   405		unsigned long size;
   406		struct efivarfs_ctx *ectx = container_of(ctx, struct efivarfs_ctx, ctx);
   407		struct qstr qstr = { .name = name, .len = len };
   408		struct dentry *dentry = d_hash_and_lookup(ectx->sb->s_root, &qstr);
   409		struct inode *inode;
   410		struct efivar_entry *entry;
   411		int err;
   412	
   413		if (IS_ERR_OR_NULL(dentry))
   414			return true;
   415	
   416		inode = d_inode(dentry);
   417		entry = efivar_entry(inode);
   418	
   419		err = efivar_entry_size(entry, &size);
   420		size += sizeof(__u32);	/* attributes */
   421		if (err)
   422			size = 0;
   423	
 > 424		inode_lock_nested(inode, INODE_CHILD);
   425		i_size_write(inode, size);
   426		inode_unlock(inode);
   427	
   428		if (!size) {
   429			ectx->dentry = dentry;
   430			return false;
   431		}
   432	
   433		dput(dentry);
   434	
   435		return true;
   436	}
   437	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [efi:urgent 10/10] fs/efivarfs/super.c:424:27: error: use of undeclared identifier 'INODE_CHILD'

[James Bottomley]

On Mon, 2025-03-17 at 19:49 +0800, kernel test robot wrote:
>  > 424		inode_lock_nested(inode, INODE_CHILD);

Sorry, was going to say on the other thread: the flag has to be
I_MUTEX_CHILD, Al just had a thinko when he wrote the above.

Regards,

James

Re: [efi:urgent 10/10] fs/efivarfs/super.c:424:27: error: use of undeclared identifier 'INODE_CHILD'

[Ard Biesheuvel]

On Mon, 17 Mar 2025 at 13:33, James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
>
> On Mon, 2025-03-17 at 19:49 +0800, kernel test robot wrote:
> >  > 424                inode_lock_nested(inode, INODE_CHILD);
>
> Sorry, was going to say on the other thread: the flag has to be
> I_MUTEX_CHILD, Al just had a thinko when he wrote the above.
>

Yeah - I might have build tested that myself, so mea culpa.